mirrors/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2024-11-28 05:27:15 +03:00
Code Issues Projects Releases Packages Wiki Activity

Use implicit sharing when getting categories from Session class

Browse source
This commit is contained in:
Chocobo1 2019-10-01 16:23:32 +08:00
parent 865394a59c
commit e32ef7f5c5
No known key found for this signature in database
GPG key ID: 210D9C873253A68C
4 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/base/bittorrent/session.cpp
View file

@ -585,7 +585,7 @@ QStringList Session::expandCategory(const QString &category)
return result; return result;
} }
const QStringMap &Session::categories() const QStringMap Session::categories() const
{ {
return m_categories; return m_categories;
} }

2
src/base/bittorrent/session.h
View file

@ -201,7 +201,7 @@ namespace BitTorrent
// returns category itself and all top level categories // returns category itself and all top level categories
static QStringList expandCategory(const QString &category); static QStringList expandCategory(const QString &category);
const QStringMap &categories() const; QStringMap categories() const;
QString categorySavePath(const QString &categoryName) const; QString categorySavePath(const QString &categoryName) const;
bool addCategory(const QString &name, const QString &savePath = ""); bool addCategory(const QString &name, const QString &savePath = "");
bool editCategory(const QString &name, const QString &savePath); bool editCategory(const QString &name, const QString &savePath);

2
src/webui/api/synccontroller.cpp
View file

@ -446,7 +446,7 @@ void SyncController::maindataAction()
data["torrents"] = torrents; data["torrents"] = torrents;
QVariantHash categories; QVariantHash categories;
const auto &categoriesList = session->categories(); const QStringMap categoriesList = session->categories();
for (auto it = categoriesList.cbegin(); it != categoriesList.cend(); ++it) { for (auto it = categoriesList.cbegin(); it != categoriesList.cend(); ++it) {
const QString &key = it.key(); const QString &key = it.key();
categories[key] = QVariantMap { categories[key] = QVariantMap {

4
src/webui/api/torrentscontroller.cpp
View file

@ -1077,8 +1077,8 @@ void TorrentsController::removeCategoriesAction()
void TorrentsController::categoriesAction() void TorrentsController::categoriesAction()
{ {
QJsonObject categories; QJsonObject categories;
const auto categoriesList = BitTorrent::Session::instance()->categories(); const QStringMap categoriesMap = BitTorrent::Session::instance()->categories();
for (auto it = categoriesList.cbegin(); it != categoriesList.cend(); ++it) { for (auto it = categoriesMap.cbegin(); it != categoriesMap.cend(); ++it) {
const auto &key = it.key(); const auto &key = it.key();
categories[key] = QJsonObject { categories[key] = QJsonObject {
{"name", key}, {"name", key},