Use implicit sharing when getting categories from Session class

This commit is contained in:
Chocobo1 2019-10-01 16:23:32 +08:00
parent 865394a59c
commit e32ef7f5c5
No known key found for this signature in database
GPG key ID: 210D9C873253A68C
4 changed files with 5 additions and 5 deletions

View file

@ -585,7 +585,7 @@ QStringList Session::expandCategory(const QString &category)
return result;
}
const QStringMap &Session::categories() const
QStringMap Session::categories() const
{
return m_categories;
}

View file

@ -201,7 +201,7 @@ namespace BitTorrent
// returns category itself and all top level categories
static QStringList expandCategory(const QString &category);
const QStringMap &categories() const;
QStringMap categories() const;
QString categorySavePath(const QString &categoryName) const;
bool addCategory(const QString &name, const QString &savePath = "");
bool editCategory(const QString &name, const QString &savePath);

View file

@ -446,7 +446,7 @@ void SyncController::maindataAction()
data["torrents"] = torrents;
QVariantHash categories;
const auto &categoriesList = session->categories();
const QStringMap categoriesList = session->categories();
for (auto it = categoriesList.cbegin(); it != categoriesList.cend(); ++it) {
const QString &key = it.key();
categories[key] = QVariantMap {

View file

@ -1077,8 +1077,8 @@ void TorrentsController::removeCategoriesAction()
void TorrentsController::categoriesAction()
{
QJsonObject categories;
const auto categoriesList = BitTorrent::Session::instance()->categories();
for (auto it = categoriesList.cbegin(); it != categoriesList.cend(); ++it) {
const QStringMap categoriesMap = BitTorrent::Session::instance()->categories();
for (auto it = categoriesMap.cbegin(); it != categoriesMap.cend(); ++it) {
const auto &key = it.key();
categories[key] = QJsonObject {
{"name", key},