mirror of
https://github.com/qbittorrent/qBittorrent.git
synced 2024-10-22 10:46:04 +03:00
Rely on Qt ownership to free resources
The m_reply has already changed parent in DownloadHandlerImpl::assignNetworkReply() and thus we can rely on Qt ownership to delete the object.
This commit is contained in:
parent
1c1cac2cba
commit
aff4065e42
2 changed files with 1 additions and 6 deletions
|
@ -64,11 +64,6 @@ DownloadHandlerImpl::DownloadHandlerImpl(Net::DownloadManager *manager, const Ne
|
|||
m_result.status = Net::DownloadStatus::Success;
|
||||
}
|
||||
|
||||
DownloadHandlerImpl::~DownloadHandlerImpl()
|
||||
{
|
||||
delete m_reply;
|
||||
}
|
||||
|
||||
void DownloadHandlerImpl::cancel()
|
||||
{
|
||||
if (m_reply) {
|
||||
|
@ -83,6 +78,7 @@ void DownloadHandlerImpl::cancel()
|
|||
void DownloadHandlerImpl::assignNetworkReply(QNetworkReply *reply)
|
||||
{
|
||||
Q_ASSERT(reply);
|
||||
Q_ASSERT(!m_reply);
|
||||
|
||||
m_reply = reply;
|
||||
m_reply->setParent(this);
|
||||
|
|
|
@ -43,7 +43,6 @@ class DownloadHandlerImpl : public Net::DownloadHandler
|
|||
|
||||
public:
|
||||
DownloadHandlerImpl(Net::DownloadManager *manager, const Net::DownloadRequest &downloadRequest);
|
||||
~DownloadHandlerImpl() override;
|
||||
|
||||
void cancel() override;
|
||||
|
||||
|
|
Loading…
Reference in a new issue