diff --git a/src/base/bittorrent/session.cpp b/src/base/bittorrent/session.cpp index 0885819a0..5db8a0940 100644 --- a/src/base/bittorrent/session.cpp +++ b/src/base/bittorrent/session.cpp @@ -55,7 +55,6 @@ #include #include #include -#include #include #include #include @@ -213,7 +212,6 @@ Session::Session(QObject *parent) , m_isDHTEnabled(BITTORRENT_SESSION_KEY("DHTEnabled"), true) , m_isLSDEnabled(BITTORRENT_SESSION_KEY("LSDEnabled"), true) , m_isPeXEnabled(BITTORRENT_SESSION_KEY("PeXEnabled"), true) - , m_isTrackerExchangeEnabled(BITTORRENT_SESSION_KEY("TrackerExchangeEnabled"), false) , m_isIPFilteringEnabled(BITTORRENT_SESSION_KEY("IPFilteringEnabled"), false) , m_isTrackerFilteringEnabled(BITTORRENT_SESSION_KEY("TrackerFilteringEnabled"), false) , m_IPFilterFile(BITTORRENT_SESSION_KEY("IPFilter")) @@ -278,7 +276,6 @@ Session::Session(QObject *parent) , m_isTrackerEnabled(BITTORRENT_KEY("TrackerEnabled"), false) , m_bannedIPs("State/BannedIPs") , m_wasPexEnabled(m_isPeXEnabled) - , m_wasTrackerExchangeEnabled(m_isTrackerExchangeEnabled) , m_numResumeData(0) , m_extraLimit(0) , m_useProxy(false) @@ -365,8 +362,6 @@ Session::Session(QObject *parent) // Enabling plugins //m_nativeSession->add_extension(&libt::create_metadata_plugin); m_nativeSession->add_extension(&libt::create_ut_metadata_plugin); - if (isTrackerExchangeEnabled()) - m_nativeSession->add_extension(&libt::create_lt_trackers_plugin); if (isPeXEnabled()) m_nativeSession->add_extension(&libt::create_ut_pex_plugin); m_nativeSession->add_extension(&libt::create_smart_ban_plugin); @@ -475,18 +470,6 @@ void Session::setPeXEnabled(bool enabled) Logger::instance()->addMessage(tr("Restart is required to toggle PeX support"), Log::WARNING); } -bool Session::isTrackerExchangeEnabled() const -{ - return m_isTrackerExchangeEnabled; -} - -void Session::setTrackerExchangeEnabled(bool enabled) -{ - m_isTrackerExchangeEnabled = enabled; - if (m_wasTrackerExchangeEnabled != enabled) - Logger::instance()->addMessage(tr("Restart is required to toggle Tracker Exchange support"), Log::WARNING); -} - bool Session::isTempPathEnabled() const { return m_isTempPathEnabled; diff --git a/src/base/bittorrent/session.h b/src/base/bittorrent/session.h index 32ccbec11..e91d20c77 100644 --- a/src/base/bittorrent/session.h +++ b/src/base/bittorrent/session.h @@ -218,8 +218,6 @@ namespace BitTorrent void setLSDEnabled(bool enabled); bool isPeXEnabled() const; void setPeXEnabled(bool enabled); - bool isTrackerExchangeEnabled() const; - void setTrackerExchangeEnabled(bool enabled); bool isAddTorrentPaused() const; void setAddTorrentPaused(bool value); bool isTrackerEnabled() const; @@ -507,7 +505,6 @@ namespace BitTorrent CachedSettingValue m_isDHTEnabled; CachedSettingValue m_isLSDEnabled; CachedSettingValue m_isPeXEnabled; - CachedSettingValue m_isTrackerExchangeEnabled; CachedSettingValue m_isIPFilteringEnabled; CachedSettingValue m_isTrackerFilteringEnabled; CachedSettingValue m_IPFilterFile; @@ -572,11 +569,10 @@ namespace BitTorrent CachedSettingValue m_isTrackerEnabled; CachedSettingValue m_bannedIPs; - // Order is important. These need to be declared after their CachedSettingsValue - // counterparts, because they use them for initialization in the constructor + // Order is important. This needs to be declared after its CachedSettingsValue + // counterpart, because it uses it for initialization in the constructor // initialization list. const bool m_wasPexEnabled; - const bool m_wasTrackerExchangeEnabled; int m_numResumeData; int m_extraLimit; diff --git a/src/base/settingsstorage.cpp b/src/base/settingsstorage.cpp index d2c6eeb52..101e61dcb 100644 --- a/src/base/settingsstorage.cpp +++ b/src/base/settingsstorage.cpp @@ -127,7 +127,6 @@ namespace {"BitTorrent/Session/DHTEnabled", "Preferences/Bittorrent/DHT"}, {"BitTorrent/Session/LSDEnabled", "Preferences/Bittorrent/LSD"}, {"BitTorrent/Session/PeXEnabled", "Preferences/Bittorrent/PeX"}, - {"BitTorrent/Session/TrackerExchangeEnabled", "Preferences/Advanced/LtTrackerExchange"}, {"BitTorrent/Session/AddTrackersEnabled", "Preferences/Bittorrent/AddTrackers"}, {"BitTorrent/Session/AdditionalTrackers", "Preferences/Bittorrent/TrackersList"}, {"BitTorrent/Session/IPFilteringEnabled", "Preferences/IPFilter/Enabled"}, diff --git a/src/gui/advancedsettings.cpp b/src/gui/advancedsettings.cpp index 20a9ee0a8..811745c88 100644 --- a/src/gui/advancedsettings.cpp +++ b/src/gui/advancedsettings.cpp @@ -87,7 +87,6 @@ enum AdvSettingsRows // seeding SUPER_SEEDING, // tracker - TRACKER_EXCHANGE, ANNOUNCE_ALL_TRACKERS, ANNOUNCE_IP, @@ -186,8 +185,6 @@ void AdvancedSettings::saveAdvancedSettings() pref->useSystemIconTheme(cb_use_icon_theme.isChecked()); #endif pref->setConfirmTorrentRecheck(cb_confirm_torrent_recheck.isChecked()); - // Tracker exchange - session->setTrackerExchangeEnabled(cb_enable_tracker_ext.isChecked()); session->setAnnounceToAllTrackers(cb_announce_all_trackers.isChecked()); } @@ -380,9 +377,6 @@ void AdvancedSettings::loadAdvancedSettings() // Torrent recheck confirmation cb_confirm_torrent_recheck.setChecked(pref->confirmTorrentRecheck()); addRow(CONFIRM_RECHECK_TORRENT, tr("Confirm torrent recheck"), &cb_confirm_torrent_recheck); - // Tracker exchange - cb_enable_tracker_ext.setChecked(session->isTrackerExchangeEnabled()); - addRow(TRACKER_EXCHANGE, tr("Exchange trackers with other peers"), &cb_enable_tracker_ext); // Announce to all trackers cb_announce_all_trackers.setChecked(session->announceToAllTrackers()); addRow(ANNOUNCE_ALL_TRACKERS, tr("Always announce to all trackers"), &cb_announce_all_trackers); diff --git a/src/gui/advancedsettings.h b/src/gui/advancedsettings.h index 7f4ba70cb..188592f16 100644 --- a/src/gui/advancedsettings.h +++ b/src/gui/advancedsettings.h @@ -79,7 +79,7 @@ private: QSpinBox spin_cache, spin_save_resume_data_interval, outgoing_ports_min, outgoing_ports_max, spin_list_refresh, spin_maxhalfopen, spin_tracker_port, spin_cache_ttl; QCheckBox cb_os_cache, cb_recheck_completed, cb_resolve_countries, cb_resolve_hosts, cb_super_seeding, cb_program_notifications, cb_torrent_added_notifications, cb_tracker_favicon, cb_tracker_status, - cb_confirm_torrent_recheck, cb_enable_tracker_ext, cb_listen_ipv6, cb_announce_all_trackers; + cb_confirm_torrent_recheck, cb_listen_ipv6, cb_announce_all_trackers; QComboBox combo_iface, combo_iface_address; QLineEdit txtAnnounceIP;