mirrors/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2024-11-28 05:27:15 +03:00
Code Issues Projects Releases Packages Wiki Activity

Improve handling when writing to temporary files

Browse source 
Let QTemporaryFile remove incomplete written file when error occurs.
"XXXXXX" template is not strictly required according to Qt doc.
This commit is contained in:
Chocobo1 2021-09-15 23:17:24 +08:00
parent fa8786e230
commit 9673be17cb
No known key found for this signature in database
GPG key ID: 210D9C873253A68C
1 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/base/net/downloadhandlerimpl.cpp
View file

@ -46,14 +46,13 @@ namespace
if (!filePath.isEmpty()) if (!filePath.isEmpty())
return Utils::IO::saveToFile(filePath, replyData).has_value(); return Utils::IO::saveToFile(filePath, replyData).has_value();
QTemporaryFile tmpfile {Utils::Fs::tempPath() + "XXXXXX"}; QTemporaryFile file {Utils::Fs::tempPath()};
tmpfile.setAutoRemove(false); if (!file.open() || (file.write(replyData) != replyData.length()) || !file.flush())
if (!tmpfile.open())
return false; return false;
filePath = tmpfile.fileName(); file.setAutoRemove(false);
return (tmpfile.write(replyData) == replyData.length()); filePath = file.fileName();
return true;
} }
} }