mirrors/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2025-01-05 14:47:25 +03:00
Code Issues Projects Releases Packages Wiki Activity

WebUI: clean up fetch API usage

Browse source 
The `Content-type` header isn't required since `URLSearchParams` is present.
The `method` property is preferred to be always specified for clarity.
The `cache: "no-store"` is preferred for most GET requests to avoid caching.

PR #21891.
This commit is contained in:
Chocobo1 2024-11-25 13:49:35 +08:00 committed by GitHub
parent f022ce8f84
commit 8d847eeb18
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/webui/www/private/scripts/misc.js
View file

@ -278,7 +278,7 @@ window.qBittorrent.Misc ??= (() => {
const downloadFile = async (url, defaultFileName, errorMessage = "QBT_TR(Unable to download file)QBT_TR[CONTEXT=HttpServer]") => {
try {
const response = await fetch(url);
const response = await fetch(url, { method: "GET" });
if (!response.ok) {
alert(errorMessage);
return;

5
src/webui/www/private/scripts/pathAutofill.js
View file

@ -64,7 +64,10 @@ window.qBittorrent.pathAutofill ??= (() => {
if (partialPath === "")
return;
fetch(`api/v2/app/getDirectoryContent?dirPath=${partialPath}&mode=${mode}`)
fetch(`api/v2/app/getDirectoryContent?dirPath=${partialPath}&mode=${mode}`, {
method: "GET",
cache: "no-store"
})
.then(response => response.json())
.then(filesList => { showInputSuggestions(element, filesList); })
.catch(error => {});

15
src/webui/www/public/scripts/login.js
View file

@ -37,17 +37,12 @@ const submitLoginForm = (event) => {
const usernameElement = document.getElementById("username");
const passwordElement = document.getElementById("password");
const query = new URLSearchParams();
query.set("username", usernameElement.value);
query.set("password", passwordElement.value);
passwordElement.value = ""; // clear previous value
fetch("api/v2/auth/login", {
method: "POST",
headers: {
"Content-type": "application/x-www-form-urlencoded; charset=UTF-8"
},
body: query.toString()
body: new URLSearchParams({
"username": usernameElement.value,
"password": passwordElement.value
})
})
.then(async (response) => {
const responseText = await response.text();
@ -62,6 +57,8 @@ const submitLoginForm = (event) => {
(error) => {
errorMsgElement.textContent = `QBT_TR(Unable to log in, server is probably unreachable.)QBT_TR[CONTEXT=Login]\n${error}`;
});
passwordElement.value = ""; // clear previous value
};
document.addEventListener("DOMContentLoaded", () => {