Merge pull request #11977 from Chocobo1/init

Fix singleton class ownership
This commit is contained in:
Mike Tzou 2020-02-08 12:10:27 +08:00 committed by GitHub
commit 8b330e3ac0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 9 deletions

View file

@ -550,7 +550,7 @@ int Application::exec(const QStringList &params)
#ifndef DISABLE_COUNTRIES_RESOLUTION
Net::GeoIPManager::initInstance();
#endif
ScanFoldersModel::initInstance(this);
ScanFoldersModel::initInstance();
#ifndef DISABLE_WEBUI
m_webui = new WebUI;

View file

@ -57,14 +57,10 @@ struct ScanFoldersModel::PathData
ScanFoldersModel *ScanFoldersModel::m_instance = nullptr;
bool ScanFoldersModel::initInstance(QObject *parent)
void ScanFoldersModel::initInstance()
{
if (!m_instance) {
m_instance = new ScanFoldersModel(parent);
return true;
}
return false;
if (!m_instance)
m_instance = new ScanFoldersModel;
}
void ScanFoldersModel::freeInstance()

View file

@ -65,7 +65,7 @@ public:
CUSTOM_LOCATION
};
static bool initInstance(QObject *parent = nullptr);
static void initInstance();
static void freeInstance();
static ScanFoldersModel *instance();