From 8679b70b4cb2c1fb1d9810e51583a6ac6d234651 Mon Sep 17 00:00:00 2001 From: sledgehammer999 Date: Wed, 26 Aug 2015 20:38:01 +0300 Subject: [PATCH] Backport fix for crash when invalid favicon is downloaded. Closes #3632. --- src/gui/transferlistfilterswidget.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gui/transferlistfilterswidget.cpp b/src/gui/transferlistfilterswidget.cpp index f254d107f..bd7f5b44c 100644 --- a/src/gui/transferlistfilterswidget.cpp +++ b/src/gui/transferlistfilterswidget.cpp @@ -619,7 +619,8 @@ void TrackerFiltersList::handleFavicoDownload(const QString& url, const QString& QListWidgetItem *trackerItem = item(rowFromTracker(host)); QIcon icon(filePath); //Detect a non-decodable icon - bool invalid = icon.pixmap(icon.availableSizes().first()).isNull(); + QList sizes = icon.availableSizes(); + bool invalid = (sizes.size() > 0 ? icon.pixmap(sizes.first()).isNull() : true); if (invalid) { if (url.endsWith(".ico", Qt::CaseInsensitive)) { Logger::instance()->addMessage(tr("Couldn't decode favicon for URL `%1`. Trying to download favicon in PNG format.").arg(url),