Use default constructor, destructor

src/base/bittorrent/torrentimpl.cpp

@@ -338,7 +338,7 @@ TorrentImpl::TorrentImpl(SessionImpl *session, lt::session *nativeSession
     // == END UPGRADE CODE ==
 }
 
-TorrentImpl::~TorrentImpl() {}
+TorrentImpl::~TorrentImpl() = default;
 
 bool TorrentImpl::isValid() const
 {

src/base/bittorrent/torrentinfo.cpp

@@ -66,12 +66,6 @@ TorrentInfo::TorrentInfo(const lt::torrent_info &nativeInfo)
     }
 }
 
-TorrentInfo::TorrentInfo(const TorrentInfo &other)
-    : m_nativeInfo {other.m_nativeInfo}
-    , m_nativeIndexes {other.m_nativeIndexes}
-{
-}
-
 TorrentInfo &TorrentInfo::operator=(const TorrentInfo &other)
 {
     if (this != &other)

src/base/bittorrent/torrentinfo.h

@@ -54,7 +54,7 @@ namespace BitTorrent
 
     public:
         TorrentInfo() = default;
-        TorrentInfo(const TorrentInfo &other);
+        TorrentInfo(const TorrentInfo &other) = default;
 
         explicit TorrentInfo(const lt::torrent_info &nativeInfo);
 

src/base/http/irequesthandler.h

@@ -37,7 +37,7 @@ namespace Http
     class IRequestHandler
     {
     public:
-        virtual ~IRequestHandler() {}
+        virtual ~IRequestHandler() = default;
         virtual Response processRequest(const Request &request, const Environment &env) = 0;
     };
 }

src/base/http/requestparser.cpp

@@ -75,10 +75,6 @@ namespace
     }
 }
 
-RequestParser::RequestParser()
-{
-}
-
 RequestParser::ParseResult RequestParser::parse(const QByteArray &data)
 {
     // Warning! Header names are converted to lowercase

src/base/http/requestparser.h

@@ -57,7 +57,7 @@ namespace Http
         static const long MAX_CONTENT_SIZE = 64 * 1024 * 1024;  // 64 MB
 
     private:
-        RequestParser();
+        RequestParser() = default;
 
         ParseResult doParse(const QByteArray &data);
         bool parseStartLines(QStringView data);

src/base/iconprovider.cpp

@@ -36,8 +36,6 @@ IconProvider::IconProvider(QObject *parent)
 {
 }
 
-IconProvider::~IconProvider() {}
-
 void IconProvider::initInstance()
 {
     if (!m_instance)

src/base/iconprovider.h

@@ -48,7 +48,7 @@ public:
 
 protected:
     explicit IconProvider(QObject *parent = nullptr);
-    ~IconProvider();
+    ~IconProvider() = default;
 
     static IconProvider *m_instance;
 };

src/base/rss/rss_autodownloadrule.cpp

@@ -208,12 +208,9 @@ AutoDownloadRule::AutoDownloadRule(const QString &name)
     setName(name);
 }
 
-AutoDownloadRule::AutoDownloadRule(const AutoDownloadRule &other)
+AutoDownloadRule::AutoDownloadRule(const AutoDownloadRule &other) = default;
-    : m_dataPtr(other.m_dataPtr)
-{
-}
 
-AutoDownloadRule::~AutoDownloadRule() {}
+AutoDownloadRule::~AutoDownloadRule() = default;
 
 QRegularExpression AutoDownloadRule::cachedRegex(const QString &expression, const bool isRegex) const
 {

src/base/rss/rss_autodownloadrule.h

@@ -49,7 +49,7 @@ namespace RSS
     class AutoDownloadRule
     {
     public:
-        explicit AutoDownloadRule(const QString &name = u""_qs);
+        explicit AutoDownloadRule(const QString &name = {});
         AutoDownloadRule(const AutoDownloadRule &other);
         ~AutoDownloadRule();
 
@@ -96,7 +96,7 @@ namespace RSS
         friend bool operator==(const AutoDownloadRule &left, const AutoDownloadRule &right);
 
         QJsonObject toJsonObject() const;
-        static AutoDownloadRule fromJsonObject(const QJsonObject &jsonObj, const QString &name = u""_qs);
+        static AutoDownloadRule fromJsonObject(const QJsonObject &jsonObj, const QString &name = {});
 
         QVariantHash toLegacyDict() const;
         static AutoDownloadRule fromLegacyDict(const QVariantHash &dict);

src/base/rss/rss_folder.h

@@ -46,7 +46,7 @@ namespace RSS
 
         friend class Session;
 
-        explicit Folder(const QString &path = u""_qs);
+        explicit Folder(const QString &path = {});
         ~Folder() override;
 
     public:

src/base/rss/rss_item.cpp

@@ -45,8 +45,6 @@ Item::Item(const QString &path)
 {
 }
 
-Item::~Item() {}
-
 void Item::setPath(const QString &path)
 {
     if (path != m_path)

src/base/rss/rss_item.h

@@ -76,7 +76,7 @@ namespace RSS
 
     protected:
         explicit Item(const QString &path);
-        ~Item() override;
+        ~Item() override = default;
 
         virtual void cleanup() = 0;
 

src/gui/powermanagement/powermanagement.cpp

@@ -50,10 +50,6 @@ PowerManagement::PowerManagement(QObject *parent)
 #endif
 }
 
-PowerManagement::~PowerManagement()
-{
-}
-
 void PowerManagement::setActivityState(const bool busy)
 {
     if (busy)

src/gui/powermanagement/powermanagement.h

@@ -47,7 +47,7 @@ class PowerManagement : public QObject
 
 public:
   PowerManagement(QObject *parent = nullptr);
-  virtual ~PowerManagement();
+  virtual ~PowerManagement() = default;
 
   void setActivityState(bool busy);
 

src/gui/powermanagement/powermanagement_x11.cpp

@@ -51,10 +51,6 @@ PowerManagementInhibitor::PowerManagementInhibitor(QObject *parent)
     m_useGSM = false;
 }
 
-PowerManagementInhibitor::~PowerManagementInhibitor()
-{
-}
-
 void PowerManagementInhibitor::requestIdle()
 {
     m_intendedState = Idle;

src/gui/powermanagement/powermanagement_x11.h

@@ -39,7 +39,7 @@ class PowerManagementInhibitor : public QObject
 
 public:
     PowerManagementInhibitor(QObject *parent = nullptr);
-    virtual ~PowerManagementInhibitor();
+    virtual ~PowerManagementInhibitor() = default;
 
     void requestIdle();
     void requestBusy();

src/gui/rss/htmlbrowser.cpp

@@ -54,10 +54,6 @@ HtmlBrowser::HtmlBrowser(QWidget *parent)
     connect(m_netManager, &QNetworkAccessManager::finished, this, &HtmlBrowser::resourceLoaded);
 }
 
-HtmlBrowser::~HtmlBrowser()
-{
-}
-
 QVariant HtmlBrowser::loadResource(int type, const QUrl &name)
 {
     if (type == QTextDocument::ImageResource)

src/gui/rss/htmlbrowser.h

@@ -42,7 +42,7 @@ class HtmlBrowser final : public QTextBrowser
 
 public:
     explicit HtmlBrowser(QWidget* parent = nullptr);
-    ~HtmlBrowser();
+    ~HtmlBrowser() = default;
 
     QVariant loadResource(int type, const QUrl &name) override;
 

src/gui/transferlistfilters/categoryfiltermodel.cpp

@@ -38,9 +38,7 @@
 class CategoryModelItem
 {
 public:
-    CategoryModelItem()
+    CategoryModelItem() = default;
-    {
-    }
 
     CategoryModelItem(CategoryModelItem *parent, QString categoryName, int torrentsCount = 0)
         : m_parent(nullptr)