From 716aca17f8b7b79e93b0bc020b2d31352a74c2c7 Mon Sep 17 00:00:00 2001 From: Xu Chao Date: Mon, 28 Aug 2023 18:50:36 +0800 Subject: [PATCH] Don't set parent of "Add new torrent dialog" on macOS PR #19494. Closes #12849. Closes #12852. Closes #19072. --------- Co-authored-by: Vladimir Golovnev --- src/gui/addnewtorrentdialog.cpp | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/gui/addnewtorrentdialog.cpp b/src/gui/addnewtorrentdialog.cpp index 1c7945806..0e7604045 100644 --- a/src/gui/addnewtorrentdialog.cpp +++ b/src/gui/addnewtorrentdialog.cpp @@ -489,7 +489,15 @@ void AddNewTorrentDialog::saveState() void AddNewTorrentDialog::show(const QString &source, const BitTorrent::AddTorrentParams &inParams, QWidget *parent) { +#ifndef Q_OS_MACOS auto *dlg = new AddNewTorrentDialog(inParams, parent); +#else + // By not setting a parent to the "AddNewTorrentDialog", all those dialogs + // will be displayed on top and will not overlap with the main window. + auto *dlg = new AddNewTorrentDialog(inParams, nullptr); + // Qt::Window is required to avoid showing only two dialog on top (see #12852). + dlg->setWindowFlags(Qt::Window); +#endif dlg->setAttribute(Qt::WA_DeleteOnClose); if (Net::DownloadManager::hasSupportedScheme(source))