Merge pull request #12891 from jagannatharjun/cache-icons

Cache flag icons
This commit is contained in:
Mike Tzou 2020-05-30 13:36:52 +08:00 committed by GitHub
commit 6b6d2cab5b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 1 deletions

View file

@ -140,7 +140,15 @@ QIcon UIThemeManager::getIcon(const QString &iconId, const QString &fallback) co
QIcon UIThemeManager::getFlagIcon(const QString &countryIsoCode) const
{
if (countryIsoCode.isEmpty()) return {};
return QIcon(":/icons/flags/" + countryIsoCode.toLower() + ".svg");
const QString key = countryIsoCode.toLower();
const auto iter = m_flagCache.find(key);
if (iter != m_flagCache.end())
return *iter;
const QIcon icon {QLatin1String(":/icons/flags/") + key + QLatin1String(".svg")};
m_flagCache[key] = icon;
return icon;
}
QColor UIThemeManager::getColor(const QString &id, const QColor &defaultColor) const

View file

@ -62,6 +62,7 @@ private:
static UIThemeManager *m_instance;
QHash<QString, QColor> m_colors;
mutable QHash<QString, QIcon> m_iconCache;
mutable QHash<QString, QIcon> m_flagCache;
const bool m_useCustomTheme;
#if (defined(Q_OS_UNIX) && !defined(Q_OS_MACOS))
const bool m_useSystemTheme;