mirrors/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2024-11-28 21:38:51 +03:00
Code Issues Projects Releases Packages Wiki Activity

Avoid stuffing the log via junk requests

Browse source
This commit is contained in:
Chocobo1 2023-07-09 16:29:25 +08:00
parent cb0c09769f
commit 543745b3f2
No known key found for this signature in database
GPG key ID: 210D9C873253A68C
1 changed files with 6 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/base/http/connection.cpp
View file

@ -32,7 +32,6 @@
#include <QTcpSocket> #include <QTcpSocket>
#include "base/logger.h"
#include "irequesthandler.h" #include "irequesthandler.h"
#include "requestparser.h" #include "requestparser.h"
#include "responsegenerator.h" #include "responsegenerator.h"
@ -94,8 +93,8 @@ void Connection::read()
const long bufferLimit = RequestParser::MAX_CONTENT_SIZE * 1.1; // some margin for headers const long bufferLimit = RequestParser::MAX_CONTENT_SIZE * 1.1; // some margin for headers
if (m_receivedData.size() > bufferLimit) if (m_receivedData.size() > bufferLimit)
{ {
LogMsg(tr("Http request size exceeds limitation, closing socket. Limit: %1, IP: %2") qWarning("%s", qUtf8Printable(tr("Http request size exceeds limitation, closing socket. Limit: %1, IP: %2")
.arg(bufferLimit).arg(m_socket->peerAddress().toString()), Log::WARNING); .arg(QString::number(bufferLimit), m_socket->peerAddress().toString())));
Response resp(413, u"Payload Too Large"_s); Response resp(413, u"Payload Too Large"_s);
resp.headers[HEADER_CONNECTION] = u"close"_s; resp.headers[HEADER_CONNECTION] = u"close"_s;
@ -108,8 +107,8 @@ void Connection::read()
case RequestParser::ParseStatus::BadMethod: case RequestParser::ParseStatus::BadMethod:
{ {
LogMsg(tr("Bad Http request method, closing socket. IP: %1. Method: \"%2\"") qWarning("%s", qUtf8Printable(tr("Bad Http request method, closing socket. IP: %1. Method: \"%2\"")
.arg(m_socket->peerAddress().toString(), result.request.method), Log::WARNING); .arg(m_socket->peerAddress().toString(), result.request.method)));
Response resp(501, u"Not Implemented"_s); Response resp(501, u"Not Implemented"_s);
resp.headers[HEADER_CONNECTION] = u"close"_s; resp.headers[HEADER_CONNECTION] = u"close"_s;
@ -121,8 +120,8 @@ void Connection::read()
case RequestParser::ParseStatus::BadRequest: case RequestParser::ParseStatus::BadRequest:
{ {
LogMsg(tr("Bad Http request, closing socket. IP: %1") qWarning("%s", qUtf8Printable(tr("Bad Http request, closing socket. IP: %1")
.arg(m_socket->peerAddress().toString()), Log::WARNING); .arg(m_socket->peerAddress().toString())));
Response resp(400, u"Bad Request"_s); Response resp(400, u"Bad Request"_s);
resp.headers[HEADER_CONNECTION] = u"close"_s; resp.headers[HEADER_CONNECTION] = u"close"_s;