From 4beee2770181a474f522dec498fdb8a2d7d13d73 Mon Sep 17 00:00:00 2001 From: Vladimir Golovnev Date: Tue, 3 Oct 2023 08:40:25 +0300 Subject: [PATCH] Improve GUI behavior when adding multiple torrents Allows you to bring the main window to the front when one or more "Add new torrent" dialogs are open. Also allows you to minimize/maximize the "Add new torrent" dialog. PR #19670. Closes #17919. --- src/gui/addnewtorrentdialog.cpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/gui/addnewtorrentdialog.cpp b/src/gui/addnewtorrentdialog.cpp index 0e7604045..58bbfb216 100644 --- a/src/gui/addnewtorrentdialog.cpp +++ b/src/gui/addnewtorrentdialog.cpp @@ -489,15 +489,14 @@ void AddNewTorrentDialog::saveState() void AddNewTorrentDialog::show(const QString &source, const BitTorrent::AddTorrentParams &inParams, QWidget *parent) { -#ifndef Q_OS_MACOS - auto *dlg = new AddNewTorrentDialog(inParams, parent); -#else + Q_UNUSED(parent); + // By not setting a parent to the "AddNewTorrentDialog", all those dialogs // will be displayed on top and will not overlap with the main window. auto *dlg = new AddNewTorrentDialog(inParams, nullptr); // Qt::Window is required to avoid showing only two dialog on top (see #12852). + // Also improves the general convenience of adding multiple torrents. dlg->setWindowFlags(Qt::Window); -#endif dlg->setAttribute(Qt::WA_DeleteOnClose); if (Net::DownloadManager::hasSupportedScheme(source))