From 43300d97e2f522a49d46796252cb7d76e95db895 Mon Sep 17 00:00:00 2001
From: sledgehammer999 <hammered999@gmail.com>
Date: Mon, 20 Mar 2023 17:27:32 +0200
Subject: [PATCH] WebUI: Minor optimizations to the login page

---
 src/webui/www/public/index.html       | 6 +++---
 src/webui/www/public/scripts/login.js | 7 ++-----
 2 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/src/webui/www/public/index.html b/src/webui/www/public/index.html
index f835e8acc..18c559af7 100644
--- a/src/webui/www/public/index.html
+++ b/src/webui/www/public/index.html
@@ -23,14 +23,14 @@
             <img src="images/qbittorrent-tray.svg" alt="qBittorrent logo" />
         </div>
         <div id="formplace" class="col">
-            <form id="loginform" method="post" onsubmit="submitLoginForm();">
+            <form id="loginform" method="post" onsubmit="submitLoginForm(event);">
                 <div class="row">
                     <label for="username">QBT_TR(Username)QBT_TR[CONTEXT=HttpServer]</label><br />
-                    <input type="text" id="username" name="username" autocomplete="username" />
+                    <input type="text" id="username" name="username" autocomplete="username" required />
                 </div>
                 <div class="row">
                     <label for="password">QBT_TR(Password)QBT_TR[CONTEXT=HttpServer]</label><br />
-                    <input type="password" id="password" name="password" autocomplete="current-password" />
+                    <input type="password" id="password" name="password" autocomplete="current-password" required />
                 </div>
                 <div class="row">
                     <input type="submit" id="login" value="QBT_TR(Login)QBT_TR[CONTEXT=HttpServer]" />
diff --git a/src/webui/www/public/scripts/login.js b/src/webui/www/public/scripts/login.js
index 21ccc6ffa..44f40000f 100644
--- a/src/webui/www/public/scripts/login.js
+++ b/src/webui/www/public/scripts/login.js
@@ -31,13 +31,10 @@
 document.addEventListener('DOMContentLoaded', function() {
     document.getElementById('username').focus();
     document.getElementById('username').select();
-
-    document.getElementById('loginform').addEventListener('submit', function(e) {
-        e.preventDefault();
-    });
 });
 
-function submitLoginForm() {
+function submitLoginForm(event) {
+    event.preventDefault();
     const errorMsgElement = document.getElementById('error_msg');
 
     const xhr = new XMLHttpRequest();