From d75564b885b3380505a1417faba46692d268f62d Mon Sep 17 00:00:00 2001 From: Dan Seminara Date: Sun, 21 Feb 2016 17:41:44 -0500 Subject: [PATCH] Do not try to parse request message when content-length is 0 --- src/base/http/requestparser.cpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/base/http/requestparser.cpp b/src/base/http/requestparser.cpp index 220272590..70b69bd2a 100644 --- a/src/base/http/requestparser.cpp +++ b/src/base/http/requestparser.cpp @@ -81,6 +81,11 @@ RequestParser::ErrorCode RequestParser::parseHttpRequest(const QByteArray& data, // Parse HTTP request message if (m_request.headers.contains("content-length")) { int content_length = m_request.headers["content-length"].toInt(); + if (content_length < 0) { + qWarning() << Q_FUNC_INFO << "bad request: content-length negative"; + return BadRequest; + } + if (content_length > static_cast(m_maxContentLength)) { qWarning() << Q_FUNC_INFO << "bad request: message too long"; return BadRequest; @@ -92,7 +97,7 @@ RequestParser::ErrorCode RequestParser::parseHttpRequest(const QByteArray& data, return IncompleteRequest; } - if (!parseContent(content)) { + if ((content_length > 0) && !parseContent(content)) { qWarning() << Q_FUNC_INFO << "message parsing error"; return BadRequest; }