From 30bf6e958fbd61afc7a1049568ec53efc2a93f6d Mon Sep 17 00:00:00 2001
From: Eugene Shalygin <eugene.shalygin@gmail.com>
Date: Fri, 30 Dec 2016 01:14:13 +0100
Subject: [PATCH] Use system file type specific icons in contents tab

The icon is determined via QFileIconProvider using filename extension only.
---
 src/CMakeLists.txt              |  3 ++
 src/gui/CMakeLists.txt          |  3 ++
 src/gui/torrentcontentmodel.cpp | 50 +++++++++++++++++++++++++++++----
 src/gui/torrentcontentmodel.h   |  2 ++
 src/src.pro                     |  3 ++
 5 files changed, 56 insertions(+), 5 deletions(-)

diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index 606a8de68..b8e9cd6d7 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -14,6 +14,9 @@ find_package(LibtorrentRasterbar REQUIRED)
 list(APPEND QBT_QT_COMPONENTS Core Network Xml)
 if (GUI)
     list (APPEND QBT_QT_COMPONENTS Concurrent Gui Widgets)
+    if (WIN32)
+        list (APPEND QBT_QT_COMPONENTS WinExtras)
+    endif(WIN32)
 endif (GUI)
 if (DBUS)
     list (APPEND QBT_QT_COMPONENTS DBus)
diff --git a/src/gui/CMakeLists.txt b/src/gui/CMakeLists.txt
index 66b84381f..4d3bb152d 100644
--- a/src/gui/CMakeLists.txt
+++ b/src/gui/CMakeLists.txt
@@ -150,3 +150,6 @@ target_link_libraries(qbt_gui qbt_lineedit qbt_powermanagement qbt_rss qbt_prope
     ${QBT_GUI_OPTIONAL_LINK_LIBRARIES} qbt_base
     QtSingleApplication::QtSingleApplication
 )
+if(WIN32)
+    target_link_libraries(qbt_gui Qt5::WinExtras)
+endif(WIN32)
diff --git a/src/gui/torrentcontentmodel.cpp b/src/gui/torrentcontentmodel.cpp
index bae6d58be..c69d7dbda 100644
--- a/src/gui/torrentcontentmodel.cpp
+++ b/src/gui/torrentcontentmodel.cpp
@@ -29,8 +29,16 @@
  */
 
 #include <QDir>
+#include <QFileIconProvider>
+#include <QFileInfo>
 #include <QIcon>
 
+#ifdef Q_OS_WIN
+#include <Windows.h>
+#include <Shellapi.h>
+#include <QtWin>
+#endif
+
 #include "guiiconprovider.h"
 #include "base/utils/misc.h"
 #include "base/utils/fs.h"
@@ -47,21 +55,53 @@ namespace
         return cached;
     }
 
-    QIcon getFileIcon()
+    class UnifiedFileIconProvider: public QFileIconProvider
     {
-        static QIcon cached = GuiIconProvider::instance()->getIcon("text-plain");
-        return cached;
-    }
+    public:
+        using QFileIconProvider::icon;
+        QIcon icon(const QFileInfo &info) const override
+        {
+            Q_UNUSED(info);
+            static QIcon cached = GuiIconProvider::instance()->getIcon("text-plain");
+            return cached;
+        }
+    };
+#ifdef Q_OS_WIN
+    // See QTBUG-25319 for explanation why this is required
+    class WinShellFileIconProvider: public UnifiedFileIconProvider
+    {
+    public:
+        using QFileIconProvider::icon;
+        QIcon icon(const QFileInfo &info) const override
+        {
+            SHFILEINFO sfi = { 0 };
+            HRESULT hr = ::SHGetFileInfoW(info.absoluteFilePath().toStdWString().c_str(),
+                FILE_ATTRIBUTE_NORMAL, &sfi, sizeof(sfi), SHGFI_ICON | SHGFI_USEFILEATTRIBUTES);
+            if (FAILED(hr))
+                return UnifiedFileIconProvider::icon(info);
+
+            QPixmap iconPixmap = QtWin::fromHICON(sfi.hIcon);
+            ::DestroyIcon(sfi.hIcon);
+            return QIcon(iconPixmap);
+        }
+    };
+#endif
 }
 
 TorrentContentModel::TorrentContentModel(QObject *parent)
     : QAbstractItemModel(parent)
     , m_rootItem(new TorrentContentModelFolder(QList<QVariant>({ tr("Name"), tr("Size"), tr("Progress"), tr("Download Priority"), tr("Remaining"), tr("Availability") })))
 {
+#ifdef Q_OS_WIN
+    m_fileIconProvider = new WinShellFileIconProvider();
+#else
+    m_fileIconProvider = new QFileIconProvider();
+#endif
 }
 
 TorrentContentModel::~TorrentContentModel()
 {
+    delete m_fileIconProvider;
     delete m_rootItem;
 }
 
@@ -202,7 +242,7 @@ QVariant TorrentContentModel::data(const QModelIndex& index, int role) const
         if (item->itemType() == TorrentContentModelItem::FolderType)
             return getDirectoryIcon();
         else
-            return getFileIcon();
+            return m_fileIconProvider->icon(QFileInfo(item->name()));
     }
 
     if ((index.column() == TorrentContentModelItem::COL_NAME) && (role == Qt::CheckStateRole)) {
diff --git a/src/gui/torrentcontentmodel.h b/src/gui/torrentcontentmodel.h
index 31baa9f50..cd6ef3966 100644
--- a/src/gui/torrentcontentmodel.h
+++ b/src/gui/torrentcontentmodel.h
@@ -39,6 +39,7 @@
 #include "base/bittorrent/torrentinfo.h"
 #include "torrentcontentmodelitem.h"
 
+class QFileIconProvider;
 class TorrentContentModelFile;
 
 class TorrentContentModel: public QAbstractItemModel
@@ -77,6 +78,7 @@ public slots:
 private:
     TorrentContentModelFolder *m_rootItem;
     QVector<TorrentContentModelFile *> m_filesIndex;
+    QFileIconProvider *m_fileIconProvider;
 };
 
 #endif // TORRENTCONTENTMODEL_H
diff --git a/src/src.pro b/src/src.pro
index 9a296d258..71914081a 100644
--- a/src/src.pro
+++ b/src/src.pro
@@ -28,6 +28,9 @@ nogui {
         DEFINES += QBT_STATIC_QT
         QTPLUGIN += qico
     }
+    win32 {
+        QT += winextras
+    }
     TARGET = qbittorrent
 }
 nowebui: DEFINES += DISABLE_WEBUI