Keep legacy defaults for existing users

This commit is contained in:
Vladimir Golovnev (Glassez) 2020-01-09 14:35:25 +03:00
parent 86c95db91d
commit 0c6c65f6f8
No known key found for this signature in database
GPG key ID: 52A2C7DEE2DFA6F7
3 changed files with 33 additions and 0 deletions

View file

@ -237,6 +237,8 @@ int main(int argc, char *argv[])
#endif
if (!firstTimeUser) {
handleChangedDefaults(DefaultPreferencesMode::Legacy);
#ifndef DISABLE_GUI
if (!upgrade()) return EXIT_FAILURE;
#elif defined(Q_OS_WIN)
@ -248,6 +250,10 @@ int main(int argc, char *argv[])
&& isatty(fileno(stdout)))) return EXIT_FAILURE;
#endif
}
else {
handleChangedDefaults(DefaultPreferencesMode::Current);
}
#if defined(DISABLE_GUI) && !defined(Q_OS_WIN)
if (params.shouldDaemonize) {
app.reset(); // Destroy current application

View file

@ -82,3 +82,23 @@ bool upgrade(const bool /*ask*/)
exportWebUIHttpsFiles();
return true;
}
void handleChangedDefaults(const DefaultPreferencesMode mode)
{
struct DefaultValue
{
QString name;
QVariant legacy;
QVariant current;
};
const QVector<DefaultValue> changedDefaults {
{QLatin1String {"BitTorrent/Session/QueueingSystemEnabled"}, true, false}
};
SettingsStorage *settingsStorage {SettingsStorage::instance()};
for (auto it = changedDefaults.cbegin(); it != changedDefaults.cend(); ++it) {
if (settingsStorage->loadValue(it->name).isNull())
settingsStorage->storeValue(it->name, (mode == DefaultPreferencesMode::Legacy ? it->legacy : it->current));
}
}

View file

@ -28,4 +28,11 @@
#pragma once
enum class DefaultPreferencesMode
{
Legacy,
Current
};
void handleChangedDefaults(DefaultPreferencesMode mode);
bool upgrade(bool ask = true);