diff --git a/src/base/bittorrent/customstorage.cpp b/src/base/bittorrent/customstorage.cpp index 2d25e45a3..7d746da78 100644 --- a/src/base/bittorrent/customstorage.cpp +++ b/src/base/bittorrent/customstorage.cpp @@ -92,7 +92,7 @@ bool CustomDiskIOThread::async_write(lt::storage_index_t storage, const lt::peer , const char *buf, std::shared_ptr diskObserver , std::function handler, lt::disk_job_flags_t flags) { - return m_nativeDiskIO->async_write(storage, peerRequest, buf, diskObserver, std::move(handler), flags); + return m_nativeDiskIO->async_write(storage, peerRequest, buf, std::move(diskObserver), std::move(handler), flags); } void CustomDiskIOThread::async_hash(lt::storage_index_t storage, lt::piece_index_t piece @@ -141,7 +141,7 @@ void CustomDiskIOThread::async_check_files(lt::storage_index_t storage, const lt , std::function handler) { handleCompleteFiles(storage, m_storageData[storage].savePath); - m_nativeDiskIO->async_check_files(storage, resume_data, links, std::move(handler)); + m_nativeDiskIO->async_check_files(storage, resume_data, std::move(links), std::move(handler)); } void CustomDiskIOThread::async_stop_torrent(lt::storage_index_t storage, std::function handler) @@ -170,7 +170,7 @@ void CustomDiskIOThread::async_delete_files(lt::storage_index_t storage, lt::rem void CustomDiskIOThread::async_set_file_priority(lt::storage_index_t storage, lt::aux::vector priorities , std::function)> handler) { - m_nativeDiskIO->async_set_file_priority(storage, priorities + m_nativeDiskIO->async_set_file_priority(storage, std::move(priorities) , [=, handler = std::move(handler)](const lt::storage_error &error, const lt::aux::vector &priorities) { m_storageData[storage].filePriorities = priorities; diff --git a/src/base/bittorrent/portforwarderimpl.cpp b/src/base/bittorrent/portforwarderimpl.cpp index 7dcb11201..803682f27 100644 --- a/src/base/bittorrent/portforwarderimpl.cpp +++ b/src/base/bittorrent/portforwarderimpl.cpp @@ -67,7 +67,7 @@ void PortForwarderImpl::setPorts(const QString &profile, QSet ports) { const QSet oldForwardedPorts = std::accumulate(m_portProfiles.cbegin(), m_portProfiles.cend(), QSet()); - m_portProfiles[profile] = ports; + m_portProfiles[profile] = std::move(ports); const QSet newForwardedPorts = std::accumulate(m_portProfiles.cbegin(), m_portProfiles.cend(), QSet()); m_provider->removeMappedPorts(oldForwardedPorts - newForwardedPorts); diff --git a/src/base/bittorrent/sessionimpl.cpp b/src/base/bittorrent/sessionimpl.cpp index 043ae3c4a..75756181b 100644 --- a/src/base/bittorrent/sessionimpl.cpp +++ b/src/base/bittorrent/sessionimpl.cpp @@ -1318,7 +1318,7 @@ void SessionImpl::processNextResumeData(ResumeSessionContext *context) std::shared_ptr ti = resumeData.ltAddTorrentParams.ti; resumeData = *loadPreferredResumeDataResult; if (!resumeData.ltAddTorrentParams.ti) - resumeData.ltAddTorrentParams.ti = ti; + resumeData.ltAddTorrentParams.ti = std::move(ti); } } } @@ -6091,7 +6091,8 @@ void SessionImpl::processTrackerStatuses() #if (QT_VERSION < QT_VERSION_CHECK(6, 0, 0)) updatedTrackerEntries[trackerEntry.url] = std::move(trackerEntry); #else - updatedTrackerEntries.emplace(trackerEntry.url, std::move(trackerEntry)); + const QString url = trackerEntry.url; + updatedTrackerEntries.emplace(url, std::move(trackerEntry)); #endif } diff --git a/src/base/digest32.h b/src/base/digest32.h index 1be904a2f..b1c903c62 100644 --- a/src/base/digest32.h +++ b/src/base/digest32.h @@ -84,7 +84,7 @@ private: class Data; explicit Digest32(QSharedDataPointer dataPtr) - : m_dataPtr {dataPtr} + : m_dataPtr {std::move(dataPtr)} { }