Debounce checks, less noisy

This commit is contained in:
Lim Chee Aun 2023-10-22 19:26:41 +08:00
parent 2149c4c35a
commit 9c4252315a
2 changed files with 59 additions and 45 deletions

View file

@ -1,5 +1,6 @@
import { memo } from 'preact/compat'; import { memo } from 'preact/compat';
import { useEffect, useRef, useState } from 'preact/hooks'; import { useEffect, useRef, useState } from 'preact/hooks';
import { useDebouncedCallback } from 'use-debounce';
import { api } from '../utils/api'; import { api } from '../utils/api';
import states, { saveStatus } from '../utils/states'; import states, { saveStatus } from '../utils/states';
@ -11,9 +12,8 @@ export default memo(function BackgroundService({ isLoggedIn }) {
// - WebSocket to receive notifications when page is visible // - WebSocket to receive notifications when page is visible
const [visible, setVisible] = useState(true); const [visible, setVisible] = useState(true);
usePageVisibility(setVisible); usePageVisibility(setVisible);
useEffect(() => { const subRef = useRef();
let sub; const debouncedStartNotifications = useDebouncedCallback(() => {
if (isLoggedIn && visible) {
const { masto, streaming, instance } = api(); const { masto, streaming, instance } = api();
(async () => { (async () => {
// 1. Get the latest notification // 1. Get the latest notification
@ -41,7 +41,7 @@ export default memo(function BackgroundService({ isLoggedIn }) {
// 2. Start streaming // 2. Start streaming
if (streaming) { if (streaming) {
sub = streaming.user.notification.subscribe(); let sub = (subRef.current = streaming.user.notification.subscribe());
console.log('🎏 Streaming notification', sub); console.log('🎏 Streaming notification', sub);
for await (const entry of sub) { for await (const entry of sub) {
if (!sub) break; if (!sub) break;
@ -56,10 +56,18 @@ export default memo(function BackgroundService({ isLoggedIn }) {
} }
} }
})(); })();
}, 3000);
useEffect(() => {
// let sub;
if (isLoggedIn && visible) {
debouncedStartNotifications();
} }
return () => { return () => {
sub?.unsubscribe?.(); // sub?.unsubscribe?.();
sub = null; // sub = null;
debouncedStartNotifications?.cancel?.();
subRef.current?.unsubscribe?.();
subRef.current = null;
}; };
}, [visible, isLoggedIn]); }, [visible, isLoggedIn]);

View file

@ -238,6 +238,10 @@ function Timeline({
}, },
[id, loadItems, checkForUpdates, snapStates.settings.autoRefresh], [id, loadItems, checkForUpdates, snapStates.settings.autoRefresh],
); );
const debouncedLoadOrCheckUpdates = useDebouncedCallback(
loadOrCheckUpdates,
3000,
);
const lastHiddenTime = useRef(); const lastHiddenTime = useRef();
usePageVisibility( usePageVisibility(
@ -245,12 +249,14 @@ function Timeline({
if (visible) { if (visible) {
const timeDiff = Date.now() - lastHiddenTime.current; const timeDiff = Date.now() - lastHiddenTime.current;
if (!lastHiddenTime.current || timeDiff > 1000 * 60) { if (!lastHiddenTime.current || timeDiff > 1000 * 60) {
loadOrCheckUpdates({ // 1 minute
debouncedLoadOrCheckUpdates({
disableIdleCheck: true, disableIdleCheck: true,
}); });
} }
} else { } else {
lastHiddenTime.current = Date.now(); lastHiddenTime.current = Date.now();
debouncedLoadOrCheckUpdates.cancel();
} }
setVisible(visible); setVisible(visible);
}, },