From 6d5b2ef9a6ef074b33b08801cd1e78d38e2f29c6 Mon Sep 17 00:00:00 2001 From: Lim Chee Aun Date: Tue, 7 Nov 2023 07:58:32 +0800 Subject: [PATCH] Test fix for uncloseable 'New notifications' bug --- src/pages/notifications.jsx | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/pages/notifications.jsx b/src/pages/notifications.jsx index f46c98a4..ead83365 100644 --- a/src/pages/notifications.jsx +++ b/src/pages/notifications.jsx @@ -130,6 +130,7 @@ function Notifications({ columnMode }) { } const loadNotifications = (firstLoad) => { + setShowNew(false); setUIState('loading'); (async () => { try { @@ -192,19 +193,14 @@ function Notifications({ columnMode }) { scrollTop: scrollableRef.current?.scrollTop, inBackground: inBackground(), disableIdleCheck, - notificationsShowNew: snapStates.notificationsShowNew, }); if ( snapStates.settings.autoRefresh && scrollableRef.current?.scrollTop < 16 && (disableIdleCheck || window.__IDLE__) && - !inBackground() && - snapStates.notificationsShowNew + !inBackground() ) { - setShowNew(false); loadNotifications(true); - } else { - setShowNew(snapStates.notificationsShowNew); } }, [snapStates.notificationsShowNew, snapStates.settings.autoRefresh, uiState], @@ -228,6 +224,7 @@ function Notifications({ columnMode }) { if (v) { loadUpdates(); } + setShowNew(v); }); } return () => {