Fix URL Modal scrolling and size (#2410)

* Change iframe style to block
- this removes the double scrollbar issue that was occurring

* Change and Add default modal sizes
This commit is contained in:
Americo Barros 2022-12-05 22:42:08 -05:00 committed by GitHub
parent 818dde0512
commit a8fea0df80
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -27,10 +27,17 @@ export const Modal: FC<ModalProps> = ({
}) => { }) => {
const [loading, setLoading] = useState(!!url); const [loading, setLoading] = useState(!!url);
let defaultHeight = '100%';
let defaultWidth = '520px';
if (url) {
defaultHeight = '70vh';
defaultWidth = '900px';
}
const modalStyle = { const modalStyle = {
padding: '0px', padding: '0px',
minHeight: height, minHeight: height,
height: height ?? '100%', height: height ?? defaultHeight,
}; };
const iframe = url && ( const iframe = url && (
@ -42,6 +49,7 @@ export const Modal: FC<ModalProps> = ({
sandbox="allow-same-origin allow-scripts allow-popups allow-forms" sandbox="allow-same-origin allow-scripts allow-popups allow-forms"
frameBorder="0" frameBorder="0"
allowFullScreen allowFullScreen
style={{ display: 'block' }}
// eslint-disable-next-line react/no-unknown-property // eslint-disable-next-line react/no-unknown-property
onLoad={() => setLoading(false)} onLoad={() => setLoading(false)}
/> />
@ -57,7 +65,7 @@ export const Modal: FC<ModalProps> = ({
onCancel={handleCancel} onCancel={handleCancel}
afterClose={afterClose} afterClose={afterClose}
bodyStyle={modalStyle} bodyStyle={modalStyle}
width={width} width={width ?? defaultWidth}
zIndex={999} zIndex={999}
footer={null} footer={null}
centered centered