mirrors/owncast
1
0
Fork 0
mirror of https://github.com/owncast/owncast.git synced 2024-10-24 21:45:59 +03:00
Code Issues Projects Releases Packages Wiki Activity

Track buffering events as errors differently in playback metrics

Browse source
This commit is contained in:
Gabe Kangas 2022-03-27 14:45:21 -07:00
parent 78b0f7addc
commit 9f6151359f
No known key found for this signature in database
GPG key ID: 9A56337728BC81EA
2 changed files with 18 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
webroot/js/components/player.js
View file

@ -238,7 +238,7 @@ class OwncastPlayer {
const latency = now - segmentTime;
this.playbackMetrics.trackLatency(latency);
} catch (err) {
console.warn(err);
// console.warn(err);
}
}
@ -261,12 +261,12 @@ class OwncastPlayer {
}
handleWaiting(e) {
// this.playbackMetrics.incrementErrorCount(1);
this.playbackMetrics.isBuffering = true;
this.playbackMetrics.incrementErrorCount(1);
this.playbackMetrics.setIsBuffering(true);
}
handleNoLongerBuffering() {
this.playbackMetrics.isBuffering = false;
this.playbackMetrics.setIsBuffering(false);
}
log(message) {

14
webroot/js/metrics/playback.js
View file

@ -11,6 +11,7 @@ class PlaybackMetrics {
this.errors = 0;
this.qualityVariantChanges = 0;
this.isBuffering = false;
this.bufferingDurationTimer = 0;
setInterval(() => {
this.send();
@ -31,6 +32,19 @@ class PlaybackMetrics {
this.qualityVariantChanges++;
}
setIsBuffering(isBuffering) {
this.isBuffering = isBuffering;
if (!isBuffering) {
clearTimeout(this.bufferingDurationTimer);
return;
}
this.bufferingDurationTimer = setTimeout(() => {
this.incrementErrorCount(1);
}, 500);
}
trackSegmentDownloadTime(seconds) {
this.segmentDownloadTime.push(seconds);
}