From 2de23a34586b3c81e4db4b6461c0bb4f8aed5b33 Mon Sep 17 00:00:00 2001
From: Gabe Kangas <gabek@real-ity.com>
Date: Sat, 8 Oct 2022 15:33:23 -0700
Subject: [PATCH] Only client-render server-rendered templates in production
 builds. Closes #2176

---
 .../ServerRenderedHydration.tsx               | 10 +++++
 .../ServerRendered/ServerRenderedMetadata.tsx | 34 +++++++++++++++
 web/components/layouts/Main.tsx               | 41 +++++--------------
 3 files changed, 54 insertions(+), 31 deletions(-)
 create mode 100644 web/components/ServerRendered/ServerRenderedHydration.tsx
 create mode 100644 web/components/ServerRendered/ServerRenderedMetadata.tsx

diff --git a/web/components/ServerRendered/ServerRenderedHydration.tsx b/web/components/ServerRendered/ServerRenderedHydration.tsx
new file mode 100644
index 000000000..5eb3d8ce9
--- /dev/null
+++ b/web/components/ServerRendered/ServerRenderedHydration.tsx
@@ -0,0 +1,10 @@
+import { FC } from 'react';
+
+export type ServerRenderedHydrationProps = {
+  hydrationScript: string;
+};
+
+export const ServerRenderedHydration: FC<ServerRenderedHydrationProps> = ({ hydrationScript }) => (
+  // eslint-disable-next-line react/no-danger
+  <script dangerouslySetInnerHTML={{ __html: hydrationScript }} />
+);
diff --git a/web/components/ServerRendered/ServerRenderedMetadata.tsx b/web/components/ServerRendered/ServerRenderedMetadata.tsx
new file mode 100644
index 000000000..014dc119a
--- /dev/null
+++ b/web/components/ServerRendered/ServerRenderedMetadata.tsx
@@ -0,0 +1,34 @@
+import { FC } from 'react';
+
+export const ServerRenderedMetadata: FC = () => (
+  <>
+    <meta name="description" content="{{.Summary}}" />
+
+    <meta property="og:title" content="{{.Name}}" />
+    <meta property="og:site_name" content="{{.Name}}" />
+    <meta property="og:url" content="{{.RequestedURL}}" />
+    <meta property="og:description" content="{{.Summary}}" />
+    <meta property="og:type" content="video.other" />
+    <meta property="video:tag" content="{{.TagsString}}" />
+
+    <meta property="og:image" content="{{.Thumbnail}}" />
+    <meta property="og:image:url" content="{{.Thumbnail}}" />
+    <meta property="og:image:alt" content="{{.Image}}" />
+
+    <meta property="og:video" content="{{.RequestedURL}}embed/video" />
+    <meta property="og:video:secure_url" content="{{.RequestedURL}}embed/video" />
+    <meta property="og:video:height" content="315" />
+    <meta property="og:video:width" content="560" />
+    <meta property="og:video:type" content="text/html" />
+    <meta property="og:video:actor" content="{{.Name}}" />
+
+    <meta property="twitter:title" content="{{.Name}}" />
+    <meta property="twitter:url" content="{{.RequestedURL}}" />
+    <meta property="twitter:description" content="{{.Summary}}" />
+    <meta property="twitter:image" content="{{.Image}}" />
+    <meta property="twitter:card" content="player" />
+    <meta property="twitter:player" content="{{.RequestedURL}}embed/video" />
+    <meta property="twitter:player:width" content="560" />
+    <meta property="twitter:player:height" content="315" />
+  </>
+);
diff --git a/web/components/layouts/Main.tsx b/web/components/layouts/Main.tsx
index 97716076b..d60634a1a 100644
--- a/web/components/layouts/Main.tsx
+++ b/web/components/layouts/Main.tsx
@@ -16,6 +16,8 @@ import { ClientConfig } from '../../interfaces/client-config.model';
 import { DisplayableError } from '../../types/displayable-error';
 import { FatalErrorStateModal } from '../modals/FatalErrorStateModal/FatalErrorStateModal';
 import setupNoLinkReferrer from '../../utils/no-link-referrer';
+import { ServerRenderedMetadata } from '../ServerRendered/ServerRenderedMetadata';
+import { ServerRenderedHydration } from '../ServerRendered/ServerRenderedHydration';
 
 export const Main: FC = () => {
   const clientConfig = useRecoilValue<ClientConfig>(clientConfigStateAtom);
@@ -30,42 +32,19 @@ export const Main: FC = () => {
     setupNoLinkReferrer(layoutRef.current);
   }, []);
 
-  const hydrationScript = `
+  const isProduction = process.env.NODE_ENV === 'production';
+
+  const hydrationScript = isProduction
+    ? `
 	window.statusHydration = {{.StatusJSON}};
 	window.configHydration = {{.ServerConfigJSON}};
-	`;
+	`
+    : null;
 
   return (
     <>
       <Head>
-        <meta name="description" content="{{.Summary}}" />
-
-        <meta property="og:title" content="{{.Name}}" />
-        <meta property="og:site_name" content="{{.Name}}" />
-        <meta property="og:url" content="{{.RequestedURL}}" />
-        <meta property="og:description" content="{{.Summary}}" />
-        <meta property="og:type" content="video.other" />
-        <meta property="video:tag" content="{{.TagsString}}" />
-
-        <meta property="og:image" content="{{.Thumbnail}}" />
-        <meta property="og:image:url" content="{{.Thumbnail}}" />
-        <meta property="og:image:alt" content="{{.Image}}" />
-
-        <meta property="og:video" content="{{.RequestedURL}}embed/video" />
-        <meta property="og:video:secure_url" content="{{.RequestedURL}}embed/video" />
-        <meta property="og:video:height" content="315" />
-        <meta property="og:video:width" content="560" />
-        <meta property="og:video:type" content="text/html" />
-        <meta property="og:video:actor" content="{{.Name}}" />
-
-        <meta property="twitter:title" content="{{.Name}}" />
-        <meta property="twitter:url" content="{{.RequestedURL}}" />
-        <meta property="twitter:description" content="{{.Summary}}" />
-        <meta property="twitter:image" content="{{.Image}}" />
-        <meta property="twitter:card" content="player" />
-        <meta property="twitter:player" content="{{.RequestedURL}}embed/video" />
-        <meta property="twitter:player:width" content="560" />
-        <meta property="twitter:player:height" content="315" />
+        {isProduction && <ServerRenderedMetadata />}
 
         <link rel="apple-touch-icon" sizes="57x57" href="/img/favicon/apple-icon-57x57.png" />
         <link rel="apple-touch-icon" sizes="60x60" href="/img/favicon/apple-icon-60x60.png" />
@@ -94,7 +73,7 @@ export const Main: FC = () => {
         <meta name="theme-color" content="#ffffff" />
 
         <style>{customStyles}</style>
-        <script dangerouslySetInnerHTML={{ __html: hydrationScript }} />
+        {isProduction && <ServerRenderedHydration hydrationScript={hydrationScript} />}
       </Head>
 
       <ClientConfigStore />