Andy Scherzinger
e7555cf169
Merge pull request #1944 from nextcloud/dependabot/github_actions/github/codeql-action-2.1.8
...
Bump github/codeql-action from 1.0.26 to 2.1.8
2022-04-24 22:12:13 +02:00
dependabot[bot]
f6af743db5
Bump github/codeql-action from 1.0.26 to 2.1.8
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 1.0.26 to 2.1.8.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](5f53256358...1ed1437484
2022-04-24 20:06:28 +00:00
Andy Scherzinger
b9726b25b7
Merge pull request #1943 from nextcloud/bugfix/noid/fixReactionsNPE
...
Fix npe if message has no self reactions initially
2022-04-24 21:54:07 +02:00
Andy Scherzinger
6316c709ad
fix npe if message has no self reactions initially
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-04-24 21:51:56 +02:00
Nextcloud bot
7eedbb2a6c
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-04-24 04:16:35 +00:00
Andy Scherzinger
942a2c0bd9
Merge pull request #1942 from nextcloud/bugfix/1914/fixEmojiPickerHeight
...
add workaround to avoid emoji picker to take the full screen height
2022-04-23 17:04:56 +02:00
Andy Scherzinger
e43c838fe7
convert into constant
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-04-23 13:22:25 +02:00
Marcel Hibbe
2495c25f22
add workaround to avoid emoji picker to take the full screen height
...
The toggleEmojiPopup method is a hacky workaround to avoid bug #1914
As the bug happens only for the very first time when the popup is opened,
it is closed after some milliseconds and opened again.
200 milliseconds seems to be a good value to initialize the popup correctly with the desired size
downside: there is even some flickering when opening the "more emojis" window
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-04-22 19:09:37 +02:00
Tim Krueger
f7dcf58d3c
Merge pull request #1940 from nextcloud/fix-trying-to-establish-a-connection-before-a-participant-joins-the-call
...
Fix trying to establish a connection before a participant joins the call
2022-04-22 17:16:08 +02:00
Daniel Calviño Sánchez
5bd920142c
Create a connection only for offers instead of for any message
...
The Android app creates a connection with a participant when that
participant joins the call and ends it when the participant leaves the
call. However, it also created a connection when any signaling message
was received from a participant that had no connection yet. Due to this
if a signaling message was received from a participant before that
participant was in the call the Android app tried to establish a
connection too soon, which would be rejected by the HPB.
Similarly, if a signaling message was received from a participant after
that participant left the call a connection will try to be established.
That would fail, but the connection object was not removed, and if that
participant joined the call again no connection would be established, as
a connection for that participant was already found, even if it was not
usable.
To solve that now a connection is created when a signaling message is
received only if that message is an offer (which is necessary without
HPB if the other participant sends the offer before this participant
"noticed" that she is in the call); otherwise the message is ignored.
Besides that a connection will no longer be created either when setting
up the video stream. However, this would be just for correctness and it
should not make any difference, as the MediaStreamEvents that cause that
are only emitted by changes in peer connections, so they should be
already created.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2022-04-22 14:38:26 +02:00
Marcel Hibbe
dc26a20278
Merge pull request #1934 from nextcloud/feature/1915/showOwnReactions
...
Show own reactions
2022-04-22 12:14:03 +02:00
Andy Scherzinger
a823cefb5f
add license header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-04-22 11:28:09 +02:00
Andy Scherzinger
9314be1e3d
fix lint score
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-04-22 11:28:09 +02:00
Andy Scherzinger
4c64686abc
align remaining bottom sheets with clickable background animation
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-04-22 11:28:09 +02:00
Andy Scherzinger
fc0df0a9b3
remove reaction in case of already reacted
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-04-22 11:28:08 +02:00
Andy Scherzinger
7450fa6b10
fix emoji picker alignments in bottom sheet
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-04-22 11:28:08 +02:00
Andy Scherzinger
6f246a1001
add visual to reactions bottom sheet if self is true
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-04-22 11:28:08 +02:00
Andy Scherzinger
2df414cb63
format kotlin
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-04-22 11:28:08 +02:00
Andy Scherzinger
a55a5536dc
remove unused color resource
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-04-22 11:28:08 +02:00
Andy Scherzinger
e2015f2810
further improve padding/margin of reactions
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-04-22 11:28:08 +02:00
Andy Scherzinger
9ec7feaaee
prevent NPE when adding the very first own reaction to a message
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-04-22 11:28:07 +02:00
Marcel Hibbe
55a48585a7
don't dismiss dialog when clicked on reaction of someone else
...
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-04-22 11:28:07 +02:00
Marcel Hibbe
b136465415
fix more emojis ("...") color
...
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-04-22 11:28:07 +02:00
Marcel Hibbe
31bb614bac
highlight own emoji immediately when reacted via app
...
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-04-22 11:28:07 +02:00
Andy Scherzinger
dd59d2dd20
improve reactions alignment
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-04-22 11:28:07 +02:00
Andy Scherzinger
0975968ff9
use lighter color for dark theme reaction chip background
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-04-22 11:28:06 +02:00
Andy Scherzinger
a5aecbcaa1
replace further contexts for proper day/night theming
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-04-22 11:28:06 +02:00
Andy Scherzinger
583b52588c
use proper context to be day/night aware
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-04-22 11:28:06 +02:00
Marcel Hibbe
fd98ccc816
add chip styled background to self reaction (wip)
...
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-04-22 11:28:05 +02:00
Marcel Hibbe
454200d797
add error message to log
...
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-04-22 11:28:05 +02:00
Marcel Hibbe
f945694a14
fix textcolor for reaction amount
...
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-04-22 11:28:04 +02:00
Nextcloud bot
20bebbecc0
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-04-22 04:06:42 +00:00
Daniel Calviño Sánchez
a8045880f9
Rename method to a more consistent name with its sibling method
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2022-04-22 02:31:21 +02:00
Daniel Calviño Sánchez
c769ff0fd0
Rename method to a more accurate name
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2022-04-22 02:30:46 +02:00
Marcel Hibbe
30d57fda4f
Merge pull request #1936 from nextcloud/bugfix/1935/fixReactionNotificationSubject
...
fix text for reaction notification + hide content title for one2one rooms and reactions
2022-04-21 20:59:48 +02:00
Andy Scherzinger
0aaa33e1a7
Create scorecards-analysis.yml
2022-04-21 17:53:44 +02:00
Marcel Hibbe
1cf55c6e8e
fix text for reaction notification
...
hide content title for one2one rooms and reactions
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-04-21 17:12:50 +02:00
Nextcloud bot
75b0f7af5d
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-04-21 04:04:59 +00:00
Andy Scherzinger
eeba4877b7
Merge pull request #1933 from nextcloud/bugfix/1893/fixCrashWhenClickOnSearchHeader
...
avoid crash when clicking on header in conversation search mode
2022-04-20 21:45:25 +02:00
Marcel Hibbe
93e9b362b6
avoid crash when clicking on header in conversation search mode
...
fix #1893
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-04-20 20:58:11 +02:00
Andy Scherzinger
9d1233aad2
Merge pull request #1932 from nextcloud/bugfix/noid/changelog
...
13.0.0 Changelog
2022-04-20 13:21:10 +02:00
Andy Scherzinger
a6b3b50d45
13.0.0
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-04-20 13:20:05 +02:00
Andy Scherzinger
f26aac21c3
Merge pull request #1930 from nextcloud/dependabot/gradle/org.jetbrains.kotlin-kotlin-gradle-plugin-1.6.21
...
Bump kotlin-gradle-plugin from 1.6.20 to 1.6.21
2022-04-20 11:36:00 +02:00
Andy Scherzinger
0123cbbdbf
Merge pull request #1926 from nextcloud/bugfix/1908/nullHardening
...
Move to a more hardened null-handling profile data handling
2022-04-20 10:20:49 +02:00
Nextcloud bot
938d709217
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-04-20 04:06:13 +00:00
dependabot[bot]
06b5d73941
Bump kotlin-gradle-plugin from 1.6.20 to 1.6.21
...
Bumps [kotlin-gradle-plugin](https://github.com/JetBrains/kotlin ) from 1.6.20 to 1.6.21.
- [Release notes](https://github.com/JetBrains/kotlin/releases )
- [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md )
- [Commits](https://github.com/JetBrains/kotlin/commits )
---
updated-dependencies:
- dependency-name: org.jetbrains.kotlin:kotlin-gradle-plugin
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-04-20 01:07:40 +00:00
Andy Scherzinger
300e7da172
extract method to reduce complexity
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-04-19 18:14:18 +02:00
Andy Scherzinger
c93041d402
move to a more hardened null-handling profile data handling
...
Fixes #1908
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-04-19 17:40:14 +02:00
Andy Scherzinger
5166cc5a84
Merge pull request #1925 from nextcloud/bugfix/noid/preventNPEafterUiTearDown
...
Catch NPE when UI is already teared down
2022-04-19 17:39:58 +02:00
Andy Scherzinger
746c3a8a4e
catch NPE when UI is already teared down
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-04-19 17:09:16 +02:00
