on some devices (reproduced with Pixel2 on api level30) the own video became visible when the pip view was tapped. This fix should hide the own video.
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
this is a quick and dirty solution until "speaker view" is introduced in the future which should be used for the pip view.
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Whenever i click the button to accept the call, CallActivity is started by intent.
CallActivity itself has the same logic to dismiss the keyguard.
The problem is: When switching from CallNotificationActivity to CallActivity the lockscreen is shown indeed!
So i guess Android recognizes "oh, CallNotificationActivity is gone. Let's show the lockscreen" before it recognizes that
the new activity also dismiss the lockscreen ?!
I fear for this scenario it was not the best idea to have 2 different activies.. (before it was only 1 activity and 2 condcutor controllers..)
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
:D :D
setUpAfterConversationIsKnown might not be the best name, but i'm not sure when in onCreate the currentConversation can be null. depending on that it might even not be necessary to have the "things" in a method..
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
- delete MagicCallActivity
- replace butterknife with viewbinding for CallActivity
TODO:
- also switch CallNotificationController to Activity
- check if CallActivity and CallNotificationActivity are called correctly
- testing!
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
methods to update UI are not yet implemented. maybe it's better to make two Activities: one for Call and one for CallNotification...
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
From the FindBugs documentation:
> CNC_COLLECTION_NAMING_CONFUSION: Collection variable is named with a different
> type of collection in the name
>
> This class defines a field or local collection variable with a name that
> contains a different type of collection in its name. An example would be a Set
> called userList. This is confusing to the reader, and likely caused by a
> previous refactor of type, without changing the name. This detector is
> obviously only checking for English names.
Signed-off-by: Tim Krüger <t@timkrueger.me>
For every click on a avatar in a group chat it will be tried to receive a
hover card from the Nextcloud server. The endpoint returns multiple
actions. Those actions will be filtered for the app ids 'spreed',
'email' and 'profile'. Other will be ignored.
The received filtered actions will be shown in a bottom sheet.
Resolves: #1644
Signed-off-by: Tim Krüger <t@timkrueger.me>
