mirrors/nextcloud-talk-android
1
0
Fork 0
mirror of https://github.com/nextcloud/talk-android.git synced 2024-12-17 14:12:00 +03:00
Code Issues Projects Releases Packages Wiki Activity
4204 commits 94 branches 415 tags 79 MiB
Commit graph

2070 commits

Author SHA1 Message Date
Andy Scherzinger
e1725767c3
improve ktlint score 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-05-13 11:07:39 +02:00
Andy Scherzinger
c52d23fabf
improve detekt score 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-05-13 11:07:38 +02:00
Andy Scherzinger
e6a78405ed
Migrate ContactsController to kotlin + viewbinding 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-05-13 11:07:38 +02:00
Dariusz Olszewski
4bb4d6870a
This setAction call seems strange and redundant 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-05-13 10:38:39 +02:00
Dariusz Olszewski
93e0751901
Additional refactoring/clean-up 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-05-13 10:38:39 +02:00
Dariusz Olszewski
d4bdd88588
Refactor - extracted common method to load avatars for notifications 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-05-13 10:38:39 +02:00
Dariusz Olszewski
3b7ca4a31a
Refactor NotificationWorker - extracted sendChatNotification method 
plus some minor modifications, hopefully ;-) without changing behaviour

Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-05-13 10:38:38 +02:00
Dariusz Olszewski
2f73433170
Reduce code duplication in NotificationUtils 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-05-13 10:38:38 +02:00
Dariusz Olszewski
b96bba47b5
Reduce number of issues reported by detekt 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-05-13 10:38:37 +02:00
Dariusz Olszewski
a234c178a8
ktlint 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-05-13 10:38:37 +02:00
Dariusz Olszewski
8b07a2aa72
Reply from notification - initial implementation 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-05-13 10:38:33 +02:00
Andy Scherzinger
ffaa6388fa
Merge pull request #2016 from ASerbinski/master 
TakePhotoActivity: Use full field of view
 2022-05-12 23:15:46 +02:00
Marcel Hibbe
2576a696a7
avoid NPE for swipeRefreshLayout 
fix #2011

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-05-12 15:53:14 +02:00
Marcel Hibbe
729e30d25b
use "return when" in isShowMessageDeletionButton() 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-05-12 14:44:33 +02:00
Marcel Hibbe
681dbfa025
allow to show "forward" option in chats with restricted permission 
this reverts one condition from commit b603031. I can't think about any reason why "forward" should be hidden.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-05-12 14:26:25 +02:00
Marcel Hibbe
a1b7a52b24
set log level of permission checks to "warning" 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-05-12 13:43:44 +02:00
Marcel Hibbe
8b3d32584c
restrict to share content without permissions 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-05-11 17:02:57 +02:00
Marcel Hibbe
d76e833d74
fix to show share-to screen 
fix to show share-to screen another time when sending was not confirmed.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-05-11 16:44:08 +02:00
Marcel Hibbe
7c4e7c22df
update permissions in getRoomInfo 
so they are updated on the fly..

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-05-11 16:44:07 +02:00
Marcel Hibbe
be29459955
fix klint warnings 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-05-11 16:44:07 +02:00
Marcel Hibbe
b603031011
hide "reply" and "forward" when chatPermission is missing 
"forward" is also hidden because this would need bigger changes regarding the state of the hasChatPermission variable inside the ChatController.kt

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-05-11 16:44:07 +02:00
Marcel Hibbe
96721a2df6
delete parsing of unused permissions 
add getter,setter,hashCode,toString for "permissions" in Conversation.java

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-05-11 16:44:06 +02:00
Marcel Hibbe
36383dfcc6
don't allow to post/delete reaction without permission 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-05-11 16:44:06 +02:00
Marcel Hibbe
bae65ebbe9
rename canPostChatShareItemsDoReaction to hasChatPermission 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-05-11 16:44:06 +02:00
Marcel Hibbe
7cf18923b5
add check if delete message is allowed to be executed 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-05-11 16:44:06 +02:00
Marcel Hibbe
cc6f582ee2
check capability and permission to delete message 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-05-11 16:44:06 +02:00
Marcel Hibbe
d9d6af2b99
add util for permissions 
util uses bitwise operations to access every single permission via variable

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-05-11 16:44:05 +02:00
Marcel Hibbe
99e9bcb0e8
add different types of permissions 
add different types of permissions to Conversation.java and Participant.java (though they are not used yet)

For conversation see
https://nextcloud-talk.readthedocs.io/en/latest/conversation/#get-user-s-conversations

For Participant see
https://nextcloud-talk.readthedocs.io/en/latest/participant/#get-list-of-participants-in-a-conversation

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-05-11 16:44:05 +02:00
Marcel Hibbe
436c860011 disable call buttons if calls are disabled by capability 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-05-10 14:03:00 +00:00
Adam Serbinski
5362510d18 TakePhotoActivity: Use full field of view 
Some devices have a digital video stabilization mode that uses a
smaller field of view within the full set of sensor data, and moves
the selected subset around like on rubber bands in order to reduce
shaking in video captures. Most devices default this mode to OFF,
but some, like Pixel 6 Pro, default this mode to ON, which causes
image and video captures to have a reduced field of view.

This change will have no effect on most devices, but will increase
field of view to full on those devices that do not by default.

Reference: https://issuetracker.google.com/issues/230013960

Signed-off-by: Adam Serbinski <adam@serbinski.com>
 2022-05-10 08:29:30 -04:00
Andy Scherzinger
b84589a831
improve detekt score 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-05-09 16:51:05 +02:00
Andy Scherzinger
5a76f3a3d3
extract checks to separate methods 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-05-09 16:46:16 +02:00
Andy Scherzinger
c3dd263b3f
proper kotlin code formatting 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-05-09 16:36:38 +02:00
Andy Scherzinger
cbad775669
extract react-able message type check 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-05-09 16:36:38 +02:00
Andy Scherzinger
44d47bf74c
hide forward action on deleted messages 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-05-09 16:36:38 +02:00
Andy Scherzinger
5afb4b68cf
extract UI build logic blocks 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-05-09 16:36:37 +02:00
Andy Scherzinger
649d8831ac
hide reactions on deleted and command messages 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-05-09 16:36:34 +02:00
Andy Scherzinger
973d13f902
Merge pull request #2005 from nextcloud/bugfix/1978/fixNPEpeerConnectionWrapper 
Bugfix/1978/fix npe in peerConnectionWrapper
 2022-05-09 15:31:59 +02:00
Marcel Hibbe
d88c01367c
fix NPE #1977 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-05-09 13:19:46 +02:00
Marcel Hibbe
a1c5e942cd
reformat code 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-05-09 13:15:11 +02:00
Marcel Hibbe
a43a51b931
try to fix #1978 
i suspect that peerConnectionFactory could have been null because e.g. "hangup()" was already called which sets it to null. Because of some async task getOrCreatePeerConnectionWrapperForSessionIdAndType might still be called afterwards and it failed because peerConnectionFactory was already null.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-05-09 13:00:01 +02:00
Marcel Hibbe
4414002b8a
reformat code 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-05-09 12:44:51 +02:00
Tim Krüger
370c51ec2d Use 'lateinit' for injected properties 
Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-05-07 11:21:29 +00:00
Tim Krüger
f9020dbc2b Reduce number of Detekt issues 
Reduce the number of Detekt issues for the 'OperationsMenuController' by
splitting the function 'processOperation' into smaller pieces. But in
the end it is not enough, because also the now short function
'processOperation' is too complex for Detekt. Because of that the
suppress annotation is set.

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-05-07 11:21:29 +00:00
Andy Scherzinger
aebebe5410 Migrate OperationsMenuController to kotlin 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-05-07 11:21:29 +00:00
Andy Scherzinger
0c5429bd7b
Merge pull request #2001 from nextcloud/bugfux/1975/fixNPEforMimetype 
make attributes of file nullable and handle null values
 2022-05-07 12:54:56 +02:00
Marcel Hibbe
59f1f003ca
avoid NPE 
trying to avoid #1976

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-05-06 23:48:44 +02:00
Marcel Hibbe
a5f7ecc5d8
make attributes of file nullable and handle null values 
nullable attributes of files can be found at https://github.com/nextcloud/server/blob/master/lib/public/RichObjectStrings/Definitions.php#L303-L351

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-05-06 23:21:10 +02:00
Marcel Hibbe
30f65424a5
fix NPE for viewbinding 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-05-06 14:58:30 +02:00
Andy Scherzinger
6cdce6db50
Merge pull request #1928 from nextcloud/bugfix/noid/removeButterknife 
remove unused butterknife binding
 2022-05-06 14:39:55 +02:00