Commit graph

2626 commits

Author SHA1 Message Date
Marcel Hibbe
4167cb63bf
share contact from attachment dialog
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-17 12:12:05 +01:00
Nextcloud bot
2871122696
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-17 04:14:10 +00:00
Marcel Hibbe
477100ccd8
delete unused method leaveRoom
delete redundant if-check

cleanup of commit ca9a622030

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-16 19:53:45 +01:00
Marcel Hibbe
ca0948d1af
Merge pull request #1696 from nextcloud/bugfix/1690/showCallControls
fix to show call controls when connecting
2021-11-16 17:58:03 +01:00
Marcel Hibbe
41ff61be5f
set pipGroupCallOverlay to gone when not needed
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-16 16:19:18 +01:00
Marcel Hibbe
9499b8117b
fix that call controls appear on touch when connecting
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-16 16:19:17 +01:00
Marcel Hibbe
e2668c4000
delete zlevel of call controls (not needed)
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-16 16:19:17 +01:00
Marcel Hibbe
48cda08854
delete if-checks for view bindings
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-16 16:19:17 +01:00
Andy Scherzinger
408094e919
Merge pull request #1680 from nextcloud/bugfix/1631/settingsSublined
Make all infos a subline
2021-11-16 15:39:39 +01:00
Nextcloud bot
8250e3810a
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-16 03:52:08 +00:00
Andy Scherzinger
589858bf3d
make all infos a subline
Resolves #1631

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-15 21:14:37 +01:00
Marcel Hibbe
f2e75a7b71
add workaround to start videocalls when PIP is disabled
this is a dirty workaround for issue #1677

Somehow onUserLeaveHint is executed when the user starts a videocall. If PIP is disabled, the logic inside enterPipMode would finish the activity right after it was started.
This workaround suppresses the execution of enterPipMode right after the activity was started.
However if a user would press the home button in the first three seconds, the call would continue in background without the ability to recover the UI.

To better fix this bug it must be found out why onUserLeaveHint is executed on start (this should not happen!).

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-15 12:19:40 +01:00
Nextcloud bot
e599157626
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-15 03:50:47 +00:00
Nextcloud bot
38a022004a
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-14 03:52:33 +00:00
Nextcloud bot
a111ae694d
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-13 03:54:18 +00:00
Andy Scherzinger
39d0052fb4
Merge pull request #1542 from nextcloud/feature/306/directCamUpload
Adding upload from camera action
2021-11-12 12:19:06 +01:00
Andy Scherzinger
4671b18b91
Add license headers
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-12 09:45:49 +01:00
Nextcloud bot
2a5a2e81fa
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-12 03:49:44 +00:00
Andy Scherzinger
2eee665374
spotbugs: remove unused view variable
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:57 +01:00
Andy Scherzinger
0a3b23ba57
don't box primitives
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:56 +01:00
Andy Scherzinger
5f8c69115b
use standardized values
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:56 +01:00
Andy Scherzinger
fd754f582b
migrate scope dialog to native view binding
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:55 +01:00
Andy Scherzinger
c680888dba
remove unused color value
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:55 +01:00
Andy Scherzinger
d995fc51ef
move attachment dialog to native view bindings
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:54 +01:00
Andy Scherzinger
d0f52c8eba
make sure to torn of torch after taking a picture
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:53 +01:00
Andy Scherzinger
dd9501590b
replace resolution and crop icons and preserve state in lifecycle
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:53 +01:00
Adam Serbinski
c3a37222b3
Crop and 2MP buttons to go away when reviewing
Signed-off-by: Adam Serbinski <adam@serbinski.com>
2021-11-11 22:10:52 +01:00
Adam Serbinski
7edd87fa4e
Add crop and low res (2MP) drawables
Signed-off-by: Adam Serbinski <adam@serbinski.com>
2021-11-11 22:10:52 +01:00
Adam Serbinski
13d376b25b
Add toggles for crop and lowres
Upper left -- crop
Upper right -- lowres (1920x?)

Signed-off-by: Adam Serbinski <adam@serbinski.com>
2021-11-11 22:10:51 +01:00
Adam Serbinski
d2d98314ee
Upload from camera: pinch to zoom, apect ratio
This implements pinch to zoom in the full range supported by the
camera HAL, fixes aspect ration handling on rotation, and sets up
for multiple resolution and aspect ratio support.

Signed-off-by: Adam Serbinski <adam@serbinski.com>
2021-11-11 22:10:51 +01:00
Andy Scherzinger
9635a71b0d
improve menu text and send button design
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:51 +01:00
Andy Scherzinger
45402ea202
taost the right text
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:50 +01:00
Andy Scherzinger
ab4bba0f27
add cam permission check
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:50 +01:00
Andy Scherzinger
03cb3a66c6
move flash/flip-cam toggles
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:49 +01:00
Andy Scherzinger
c78967b6b1
optimize preview alignment
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:49 +01:00
Andy Scherzinger
552f0555f1
replace retake icon for cam view
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:48 +01:00
Andy Scherzinger
bdc157d772
spotbugs: remove needlessly boxing a boolean constant
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:48 +01:00
Andy Scherzinger
439c5555c4
removing unused files
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:47 +01:00
Andy Scherzinger
14a3e488cc
limit image size for cam uploads to FHD
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:47 +01:00
Andy Scherzinger
7e688c43af
update cam libs to sdk=30 versions, improve previews and removal of temp images in case of cancellations
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:47 +01:00
Andy Scherzinger
67c421a067
add retake, send actions and preview
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:46 +01:00
Andy Scherzinger
547e9ebf8b
improve camera layout
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:46 +01:00
Andy Scherzinger
56d57c0b37
improve code check score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:45 +01:00
Andy Scherzinger
4041d3f09b
use context compat to load resources
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:45 +01:00
Andy Scherzinger
0b8add1f69
Adding upload from camera action
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Co-Authored-by: Stefan Niedermann <info@niedermann.it>
2021-11-11 22:10:41 +01:00
Marcel Hibbe
14abe52b6a
rename CallActivityBase to CallBaseActivity
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:52:18 +01:00
Marcel Hibbe
bc12ee35b4
modify strings
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:52:18 +01:00
Marcel Hibbe
36c5f0814b
remove avatar blurring for background (=fix blocking of call controls)
no blurring or other background color calculation is done any more. BlurPostProcessor took too long for the used image size. If this is a requirement in the future, use ScalingBlurPostprocessor instead of  BlurPostprocessor (so fresco lib fork from nextcloud has to be updated!), see https://frescolib.org/docs/modifying-image.html

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:52:18 +01:00
Marcel Hibbe
9070153d5c
create abstract class for CallActivity and CallNotificationActivity
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:52:18 +01:00
Marcel Hibbe
be9971ad7a
disable back button when pip is not available
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:52:18 +01:00
Marcel Hibbe
e6da2fcc19
replace hardcoded applicationId for pip permission check
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:52:18 +01:00
Marcel Hibbe
89d0bcfc78
hide navigation bar if pip is not available
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:52:18 +01:00
Marcel Hibbe
f5106e6050
check if pip mode is granted on device, otherwise hide button
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:52:18 +01:00
Marcel Hibbe
39a3c9edb5
fix to fully view call controls
(were cut at left and right on some devices)

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:52:18 +01:00
Marcel Hibbe
f9a28cb0aa
fix to hide selfVideo when pip-view is tapped
on some devices (reproduced with Pixel2 on api level30) the own video became visible when the pip view was tapped. This fix should hide the own video.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:52:18 +01:00
Marcel Hibbe
289bd2fa00
fix klint error
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
63593df03e
hide peer name when in pip mode
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
052dc588aa
remove comment
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
b822eb8417
reformat code in CallNotificationActivity
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
b3f8a36c62
load avatar again in CallNotificationActivity
was only disabled for debugging. still needs to be fixed with https://github.com/nextcloud/talk-android/issues/1234

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
7a7888f5d1
reformat code in CallActivity
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
71ae7eddc2
move code from onStart to onCreate
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
0bfeb1b320
add action button to mute/unmute in pip mode
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
4a1c637efc
add checks if pip is supported by device
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
a0c95113bf
display overlay instead of grid in pip view for group calls
this is a quick and dirty solution until "speaker view" is introduced in the future which should be used for the pip view.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
57804c8d62
dismiss keyguard for CallNotificationActivity (WIP, see TODO)
Whenever i click the button to accept the call, CallActivity is started by intent.
CallActivity itself has the same logic to dismiss the keyguard.

The problem is: When switching from CallNotificationActivity to CallActivity the lockscreen is shown indeed!
So i guess Android recognizes "oh, CallNotificationActivity is gone. Let's show the lockscreen" before it recognizes that
the new activity also dismiss the lockscreen ?!

I fear for this scenario it was not the best idea to have 2 different activies.. (before it was only 1 activity and 2 condcutor controllers..)

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
e05334cb9a
enable pip support for CallNotificationActivity
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
7e68ecbde9
rename "runAllThings"
:D :D
setUpAfterConversationIsKnown might not be the best name, but i'm not sure when in onCreate the currentConversation can be null. depending on that it might even not be necessary to have the "things" in a method..

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
3326b6a7f3
rename design for CallActivity
move methods

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
c7e38e4859
replace CallNotificationController with Activity (WIP)
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
251d41f7fb
replace CallController with CallActivity etc. (WIP)
- delete MagicCallActivity
- replace butterknife with viewbinding for CallActivity

TODO:
- also switch CallNotificationController to Activity
- check if CallActivity and CallNotificationActivity are called correctly
- testing!

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
b49a1b9274
remove unused import
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
06fab75c30
remove unused view
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
3afcceae50
delete creation of intent that is not used
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
03913b40a2
fix to enable pip for CallNotification Controller
methods to update UI are not yet implemented. maybe it's better to make two Activities: one for Call and one for CallNotification...

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
0d1e0af9d1
fix NPE when call is joined by notification
add ability to have PIP mode for calls joined by notification

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
51b86b5a88
fix currentRoomToken for ApplicationWideCurrentRoomHolder
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
e0e3bf4c32
add logging and comments
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
2c1b45491d
start pip mode when back button is pressed
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
78653e7d8d
show call controls in videocall when entering call or when come back from pip mode
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
12d96634e5
fix to show call controls in voiceOnly call after coming back from pip mode
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
1ae5f51a81
hide pip button for android < 8
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
6839b9eb2c
fix animation of callControls
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
3ba599be98
rename old "pip*"-stuff to "selfVideo*"
improve design-logic for pip-mode and normal mode when switched back from pip

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
914b10bf20
make pip fullscreen (wip)
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
d482d8603e
modify call screen design for pip mode
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
ea8e45e934
enable keyguard when users presses home button
= security check if call was entered via notification in locked mode

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
0aee8eb7ef
remove comment
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
d4322bf2d9
finish call activity if closed via "X" in pip mode
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
7f19816961
remove call activity from tasks
add launch screen for call

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
d4d23c1855
set calling/dialing state by ApplicationWideCurrentRoomHolder
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
78384e7b55
add initial approach for pip mode (wip)
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
40506eaeaf
allow app to query for apps that can resolve VIEW or SEND intents
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 11:22:37 +01:00
Tim Krüger
85785c287e
Resolve FindBugs Collection Naming Confusion
From the FindBugs documentation:

> CNC_COLLECTION_NAMING_CONFUSION: Collection variable is named with a different
> type of collection in the name
>
> This class defines a field or local collection variable with a name that
> contains a different type of collection in its name. An example would be a Set
> called userList. This is confusing to the reader, and likely caused by a
> previous refactor of type, without changing the name. This detector is
> obviously only checking for English names.

Signed-off-by: Tim Krüger <t@timkrueger.me>
2021-11-10 13:55:20 +01:00
Tim Krüger
9accac3325
Show profile action on avatar click
For every click on a avatar in a group chat it will be tried to receive a
hover card from the Nextcloud server. The endpoint returns multiple
actions. Those actions will be filtered for the app ids 'spreed',
'email' and 'profile'. Other will be ignored.
The received filtered actions will be shown in a bottom sheet.

Resolves: #1644

Signed-off-by: Tim Krüger <t@timkrueger.me>
2021-11-10 09:08:43 +01:00
Tim Krüger
036cf7c590
Some refactoring
- Removed spelling issues
- Removed unneded boolean comparisons
- Improve code readability by reformatting

Signed-off-by: Tim Krüger <t@timkrueger.me>
2021-11-10 09:08:42 +01:00
Andy Scherzinger
55137aeb6d
Merge pull request #1665 from nextcloud/dependabot/gradle/com.pinterest-ktlint-0.43.0
Bump ktlint from 0.42.1 to 0.43.0
2021-11-06 14:54:41 +01:00
Andy Scherzinger
a8c8fbe191
reformat code
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-06 12:23:37 +01:00
Andy Scherzinger
61e0c88188
improve code scores
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-06 12:15:23 +01:00
Andy Scherzinger
ed7a762b4c
correct formatting for ktlint
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-05 18:18:21 +01:00