Commit graph

5510 commits

Author SHA1 Message Date
Andy Scherzinger
f92cef0415
remove unused var
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-10-11 14:25:41 +02:00
Andy Scherzinger
3377021d2c
remove unused lib check
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-10-11 13:17:21 +02:00
Andy Scherzinger
8fb11bf713
remove any use of org.jetbrains.annotations.NotNull
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-10-11 12:47:45 +02:00
Andy Scherzinger
980dffff56
unify with files script
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-10-11 12:35:19 +02:00
Tim Krüger
57fe34c14a
Merge pull request #2477 from nextcloud/fix-crash-when-setting-layout-for-call-participants
Fix crash when setting layout for call participants
2022-10-11 08:44:38 +02:00
Daniel Calviño Sánchez
7f86593bca
Fix avatar when setting participant layout before receiving the data
When a new participant is found and the layout for that participant is
set up the participant data might have not been fetched yet. If that
happens the user ID can not be got from the data and therefore a guest
avatar would be shown for that participant, even if that participant is
a normal user.

However, the signaling message that is used to find new participants
already includes the user ID, so it is now explicitly given and, if not,
then it is got from the participant data (which is needed when handling
the establishment of a connection, as in that case the event does not
contain the user ID).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2022-10-10 18:55:24 +02:00
Daniel Calviño Sánchez
4f01cb855a
Fix crash when setting participant layout before receiving the data
When setting the participant layout, if the HPB is not used, the user ID
is got from the participant list data fetched when a new participant is
found. However, as the participant layout is setup as soon as a new
participant is found the data may have not been received yet, which
ended in a crash (NullPointerException). Now the access to the
participant object is guarded to prevent that.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2022-10-10 18:29:40 +02:00
Andy Scherzinger
b7fa83544c
add gplay check
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-10-10 17:21:51 +02:00
Andy Scherzinger
d7807f64d3
update spotbugs config
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-10-10 17:06:43 +02:00
Andy Scherzinger
9fdc1c2a6e
Add new analysis action
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-10-10 17:03:47 +02:00
Nextcloud Android Bot
2051588805 Weekly 15.1.0 Alpha 05 2022-10-10 03:12:14 +00:00
Tim Krüger
89607b8776
Merge pull request #2473 from nextcloud/chore/noid/housekeepingOne
Code scanner warnings housekeeping - part one
2022-10-07 09:25:54 +02:00
Andy Scherzinger
47da6226f6
reduce detekt max issues count
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-10-06 19:49:52 +02:00
Andy Scherzinger
89ec37d24d
simplify condition complexity
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-10-06 18:00:52 +02:00
Andy Scherzinger
9bd51ce21b
PMD: An empty statement (semicolon) not part of a loop
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-10-06 16:55:38 +02:00
Andy Scherzinger
0a70567452
PMD: Use opposite operator instead of the logic complement operator.
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-10-06 16:54:27 +02:00
Andy Scherzinger
da9daed3a9
Merge pull request #2471 from nextcloud/fixCopyrightHeaders
fix copyright headers
2022-10-06 16:21:56 +02:00
Marcel Hibbe
2d8799feed
fix copyright headers
headers contained a wrong sentence that was duplicated via c&p

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-10-06 13:48:28 +02:00
Marcel Hibbe
b7d4ba7f9c
Merge pull request #2467 from nextcloud/chore/noid/kotlin17020
bump kotlin to 17.0.20 and mark declaration usage as opt-in
2022-10-06 13:26:02 +02:00
Tim Krüger
009cd5a425
Merge pull request #2460 from nextcloud/feature/2419/linkPreviews
add openGraph link previews
2022-10-06 13:19:14 +02:00
Andy Scherzinger
b4cf0b722a
Merge pull request #2468 from nextcloud/dependabot/gradle/androidx.exifinterface-exifinterface-1.3.4
Bump exifinterface from 1.3.3 to 1.3.4
2022-10-06 13:14:22 +02:00
Marcel Hibbe
66eea709b4
open MessageActionsDialog on long click on link previews.
rename ReactionsInterface.kt to CommonMessageInterface.kt

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-10-06 12:45:53 +02:00
dependabot[bot]
647acf7d31
Bump exifinterface from 1.3.3 to 1.3.4
Bumps exifinterface from 1.3.3 to 1.3.4.

---
updated-dependencies:
- dependency-name: androidx.exifinterface:exifinterface
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-10-06 01:10:22 +00:00
Andy Scherzinger
3632b58eb1
bump kotlin to 17.0.20 and mark declaration usage as opt-in
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-10-05 22:10:48 +02:00
Marcel Hibbe
9bc42334d4
add openGraph link previews
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-10-05 14:17:07 +02:00
Andy Scherzinger
fd1f2c77ad
Merge pull request #2450 from nextcloud/bugfix/2447/fixToStartDirectVideoCapture
toast when Direct Video Upload fails to start
2022-10-04 17:31:15 +02:00
Marcel Hibbe
387cb63ce7 add toast if video file creation failed
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-10-04 12:56:01 +00:00
Andy Scherzinger
fe1f02eb2f
Merge pull request #2456 from nextcloud/dependabot/gradle/coilKtVersion-2.2.2
Bump coilKtVersion from 2.2.1 to 2.2.2
2022-10-04 12:48:31 +02:00
Andy Scherzinger
957d5f91d4
Merge pull request #2459 from nextcloud/dependabot/github_actions/actions/setup-java-3
Bump actions/setup-java from 2 to 3
2022-10-04 10:27:43 +02:00
Andy Scherzinger
f3a7312dae
Merge pull request #2458 from nextcloud/dependabot/github_actions/ossf/scorecard-action-2.0.4
Bump ossf/scorecard-action from 2.0.3 to 2.0.4
2022-10-04 10:26:35 +02:00
Andy Scherzinger
9984b0d7d9
add version number update in comment
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-10-04 10:26:19 +02:00
dependabot[bot]
078261a947
Bump actions/setup-java from 2 to 3
Bumps [actions/setup-java](https://github.com/actions/setup-java) from 2 to 3.
- [Release notes](https://github.com/actions/setup-java/releases)
- [Commits](https://github.com/actions/setup-java/compare/v2...v3)

---
updated-dependencies:
- dependency-name: actions/setup-java
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-10-03 23:31:02 +00:00
dependabot[bot]
8d26e98155
Bump ossf/scorecard-action from 2.0.3 to 2.0.4
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.0.3 to 2.0.4.
- [Release notes](https://github.com/ossf/scorecard-action/releases)
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md)
- [Commits](865b409285...e363bfca00)

---
updated-dependencies:
- dependency-name: ossf/scorecard-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-10-03 23:30:58 +00:00
Marcel Hibbe
a507bdd03a
Merge pull request #2455 from nextcloud/changeCameraPermission
Like Android Files we should rely on generic camera feature, but not required.
2022-10-03 11:10:13 +02:00
tobiasKaminsky
ff0421575a Like Android Files we should rely on generic camera feature, but not required.
This then should allow us to install Talk on Chromebooks

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-10-03 08:36:45 +00:00
Nextcloud Android Bot
d13f79f7f7 Weekly 15.1.0 Alpha 04 2022-10-03 03:10:16 +00:00
dependabot[bot]
489641cc3b
Bump coilKtVersion from 2.2.1 to 2.2.2
Bumps `coilKtVersion` from 2.2.1 to 2.2.2.

Updates `coil` from 2.2.1 to 2.2.2
- [Release notes](https://github.com/coil-kt/coil/releases)
- [Changelog](https://github.com/coil-kt/coil/blob/main/CHANGELOG.md)
- [Commits](https://github.com/coil-kt/coil/compare/2.2.1...2.2.2)

Updates `coil-gif` from 2.2.1 to 2.2.2
- [Release notes](https://github.com/coil-kt/coil/releases)
- [Changelog](https://github.com/coil-kt/coil/blob/main/CHANGELOG.md)
- [Commits](https://github.com/coil-kt/coil/compare/2.2.1...2.2.2)

Updates `coil-svg` from 2.2.1 to 2.2.2
- [Release notes](https://github.com/coil-kt/coil/releases)
- [Changelog](https://github.com/coil-kt/coil/blob/main/CHANGELOG.md)
- [Commits](https://github.com/coil-kt/coil/compare/2.2.1...2.2.2)

---
updated-dependencies:
- dependency-name: io.coil-kt:coil
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: io.coil-kt:coil-gif
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: io.coil-kt:coil-svg
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-10-03 01:35:58 +00:00
jld3103
e15866c913
Merge pull request #2453 from jld3103/feature/show-loading-chats-error
Show error when loading chats fails
2022-10-01 09:49:01 +02:00
jld3103
d8d4fde391
Show error when loading chats fails
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2022-09-30 17:48:52 +02:00
Tim Krüger
847a361f1b
Merge pull request #2448 from nextcloud/revert-2370-chore/set-min-sdk-version-to-23
Revert "Set minSdkVersion to 23 (Android 6)"
2022-09-30 11:47:58 +02:00
Tim Krüger
2d8492ae1e
Revert "Set minSdkVersion to 23 (Android 6)"
Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-09-30 11:21:32 +02:00
Nextcloud bot
127ed0944a
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-09-30 05:50:11 +00:00
Tim Krüger
9eab3a7103
Merge pull request #2444 from nextcloud/bugfix/noid/get-branch-name-from-head-instead-of-base
Get branch name from head instead of base
2022-09-29 18:26:02 +02:00
Tim Krüger
193d6a2e25
Get branch name from head instead of base
Not the name of the branch were the changes should pulled into is
needed. The name of the current branch must be determined.

Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-09-29 17:49:59 +02:00
drone
489dabe81e Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-09-29 13:26:27 +00:00
drone
3a90d17649 Merge commit '863052b53e3051bb7e0fd4904d348fa294835821' 2022-09-29 13:16:56 +00:00
Tim Krüger
863052b53e
[WIP] Replace Fresco with Coil
Fresco is replaced with Coil verywhere. But Coil is not used directly to
avoid splintering the dependency everywhere in the code. Coil is wrapped
by extension functions for 'ImageView'.

Some shared functionality is moved from 'DisplayUtils' into the
'ImageViewExtensions'.

Resolves: #2227, #2376

Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-09-29 14:07:05 +02:00
Andy Scherzinger
1382a23b39
Merge pull request #2436 from nextcloud/feature/noid/improvePollsButtons
Feature/noid/improve polls buttons
2022-09-29 11:40:32 +02:00
Marcel Hibbe
47a93d2c85
align poll buttons to right
make end poll button outlined

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-09-29 11:20:10 +02:00
Tim Krüger
b2d6211b3c
Convert 'ConverstationItem' from Java to Kotlin
This is mandetory to replace Fresco with Coil.

See: #2376, #2227

Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-09-29 10:28:30 +02:00