mirrors/nextcloud-talk-android
1
0
Fork 0
mirror of https://github.com/nextcloud/talk-android.git synced 2024-12-17 14:12:00 +03:00
Code Issues Projects Releases Packages Wiki Activity
3845 commits 94 branches 415 tags 79 MiB
Commit graph

1867 commits

Author SHA1 Message Date
Andy Scherzinger
cfe4847732
migrate RingtoneSelectionController to kotlin 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-15 17:44:52 +01:00
Tim Krüger
60e4ec9086
Use 'val' for never modified variables 
Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-03-15 14:35:08 +01:00
Dariusz Olszewski
1e76b45fb4
Switch to chat w/o animation when app opened from notification 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-03-15 14:35:08 +01:00
Dariusz Olszewski
ddcf1c48aa
Workaround for crash when loading avatar 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-03-15 13:33:30 +01:00
Andy Scherzinger
f36b7750de
format kotlin code 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-14 10:23:08 +01:00
Andy Scherzinger
ba3e24bbc7
replace too long paramter lists with data classes 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-14 10:23:07 +01:00
Andy Scherzinger
6e02c5de41
reformat kotlin 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-14 10:23:07 +01:00
Andy Scherzinger
6206e4910d
simplify complex conditions for readability 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-14 10:23:06 +01:00
Andy Scherzinger
454dbc5db2
unify http(s) protocoll prefix check on urls 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-14 10:23:06 +01:00
Andy Scherzinger
a10b67456c
ignore generic exception handling 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-14 10:23:05 +01:00
Andy Scherzinger
2102f0fbc8
document empty blocks 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-14 10:23:01 +01:00
Tim Krueger
08dc22c30f
Merge pull request #1841 from nextcloud/bugfix/1839/fail-to-set-empty-status-message 
Bugfix/1839/fail to set empty status message
 2022-03-11 15:33:58 +01:00
Tim Krüger
cb1dd8e5b5
Avoid empty status message 
Enable the 'Set status message' button only if a message is set.
Currently the API don't allow us to set an empty message [1].

See:
  [1] nextcloud/server#31452
  #1839

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-03-10 17:08:02 +01:00
Tim Krüger
f8e8a95b34
Use '==' instead of 'equals' in Kotlin 
In Kotlin for a check of the structural equality '==' should be used.
Referential equality is checked with '==='.

See:
 - https://kotlinlang.org/docs/equality.html

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-03-10 17:05:14 +01:00
Tim Krueger
70a30f146a
Merge pull request #1851 from nextcloud/bugfix/1848/showSystemMessageAddedGroup 
add groups and circles to system messages ("add"+"remove")
 2022-03-09 10:37:19 +01:00
Andy Scherzinger
0fe562d415
remove unused method parameters 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-07 13:40:42 +01:00
Tim Krüger
5ad6da86f1
Use Boolean constant values directly 
From the SpotBugs report:

> NAB_NEEDLESS_BOOLEAN_CONSTANT_CONVERSION: Method needlessly boxes a boolean
> constant
>
> This method assigns a Boxed boolean constant to a primitive boolean variable,
> or assigns a primitive boolean constant to a Boxed boolean variable. Use the
> correct constant for the variable desired. Use
>
>
> boolean b = true;
> boolean b = false;
>
> or
>
>
> Boolean b = Boolean.TRUE;
> Boolean b = Boolean.FALSE;
>
> Be aware that this boxing happens automatically when you might not expect it.
> For example,
>
>
> Map statusMap = ...
>
> public Boolean someMethod() {
>     statusMap.put("foo", true);  //the "true" here is boxed
>     return false;  //the "false" here is boxed
> }
>
> has two cases of this needless autoboxing. This can be made more efficient by
> simply substituting in the constant values:
>
>
> Map statusMap = ...
>
> public Boolean someMethod() {
>     statusMap.put("foo", Boolean.TRUE);
>     return Boolean.FALSE;
> }

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-03-07 13:11:23 +01:00
Andy Scherzinger
8e11f21233
adapt to java->kotlin changes regarding null-ability 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-07 09:55:30 +01:00
Andy Scherzinger
15e875f974
Migrate push models to kotlin data classes 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-07 09:50:19 +01:00
Marcel Hibbe
a1e694104c
add groups and circles to system messages ("add"+"remove") 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-03-04 14:58:46 +01:00
Marcel Hibbe
0079107461
revert commit d76203a0 
fix to support older conversationApi versions for canLeave and canDelete

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-03-04 09:23:42 +01:00
Marcel Hibbe
86caa48636
add logging for onError 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-03-04 09:23:41 +01:00
Andy Scherzinger
aa2a08692f
migrate statuses overall to kotlin data classes 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-03 18:00:53 +01:00
Andy Scherzinger
2008fb0c2a
migrate remaining status models to kotlin 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-03 12:50:58 +01:00
Marcel Hibbe
508f519468
set fixed avatar sizes for requests 
necessary because of https://github.com/nextcloud/server/pull/31010

known issue: avatars in chat messages are too big atm

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-03-02 15:15:22 +01:00
Andy Scherzinger
00c4b13f17
don't resize avatar views dynamically 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-02 14:33:53 +01:00
Tim Krüger
3411728597
Pass 'null' for unset icon in custom status message 
The OCS Status API  expect an valid emoji or 'null' for the status icon
in a custom message:

> field: statusIcon
> type: string/null
> Description: The icon picked by the user (must be an emoji, at most one)

See [1] for more details.

Resolves: #1839
See:
 [1] https://docs.nextcloud.com/server/latest/developer_manual/client_apis/OCS/ocs-status-api.html#set-a-custom-message-user-defined

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-03-02 09:50:08 +01:00
Dariusz Olszewski
93556da33a
Re-use existing ChatController from notification 
NotificationWorker provides the user information under KEY_USER_ENTITY parameter of the notification intent, but does not set the KEY_INTERNAL_USER_ID parameter.
With this change existing ChatController instance that has been opened manually from the conversation list is properly reused when a notification is opened.
Otherwise two instances of the ChatController were running in parallel for the same room, causing unintended side effects.

Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-03-01 13:19:18 +01:00
Dariusz Olszewski
c95d286de4
ktlint 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-03-01 13:19:18 +01:00
Dariusz Olszewski
a7bd6393df
Prevent overlapping pullChatMessages calls 
Sometimes pullChatMessages may be called before response to a previous call is received.
In such cases just ignore the second call. Message processing will continue when response to the earlier call is received.

Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-03-01 13:19:18 +01:00
Dariusz Olszewski
b2aef87b24
Re-organize sessionId handling 
- clean session Id when leaving the room rather than in onAttach
- invoke leaveRoom in onDetach only when we have a valid sessionId
This avoid calling joinRoom twice in some scenarios, or calling leaveRoom before joinRoom completes successfully.

Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-03-01 13:19:17 +01:00
Dariusz Olszewski
d31e6de5c4
Second attempt to fix the issue 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-03-01 13:19:17 +01:00
Dariusz Olszewski
d064ad3f65
Simplified code to avoid NullPointerException when server response arrives after the view was unbound. 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-03-01 13:19:17 +01:00
Dariusz Olszewski
606c6b0b9e
Avoid NullPointerException when server response arrives after the view was unbound. 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-03-01 13:19:17 +01:00
Dariusz Olszewski
505bcdfe20
Yet more diagnostic logging 
Also in ConversationsListController

Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-03-01 13:19:16 +01:00
Dariusz Olszewski
cfcfcf5bc4
Even more diagnostic logging 
Info to correlate calls and responses
Log errors

Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-03-01 13:19:16 +01:00
Dariusz Olszewski
b88530da6f
More diagnostic logging 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-03-01 13:19:16 +01:00
Dariusz Olszewski
b10d0cb98a
Revert "Notifications from lock screen - initial attempt to fix the issue" 
This reverts commit ce8bec73

Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-03-01 13:19:16 +01:00
Dariusz Olszewski
dfa14e7c52
Notifications from lock screen - initial attempt to fix the issue 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-03-01 13:19:15 +01:00
Dariusz Olszewski
be6e5d78cb
Additional logging to diagnose opening chat view from notification 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-03-01 13:19:14 +01:00
Andy Scherzinger
b750f41efd
kotlin code foermatting 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-01 10:21:09 +01:00
Andy Scherzinger
243e6161a6
Migrate AccountVerificationController to kotlin 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-02-28 18:25:53 +01:00
Andy Scherzinger
f76d25974e
migrate EntryMenuController to Kotlin 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-02-28 17:21:06 +01:00
Tim Krüger
45085b7e0b
Remove Parceler from model notifications 
Resolves: #1548

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-02-28 16:54:24 +01:00
Tim Krüger
d9587e9d18
Remove Parceler from model mention 
Resolves: #1548

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-02-28 16:54:24 +01:00
Tim Krüger
003d4c6af2
Remove unneeded not-null assertion operator (!!) 
Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-02-28 16:54:23 +01:00
Tim Krüger
94f2339baa
Remove unneeded package definition 
Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-02-28 16:54:23 +01:00
Tim Krüger
9f62df3a53
Suppress lint for unused result 
Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-02-28 16:54:22 +01:00
Tim Krüger
dad4f56e6a
Remove Parceler from model hovercard 
Resolves: #1548

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-02-28 16:54:22 +01:00
Andy Scherzinger
18f180bfe7
rename UserItem to ContactsItem to reflect its use case 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-02-28 13:26:40 +01:00