Commit graph

226 commits

Author SHA1 Message Date
Andy Scherzinger
6cdce6db50
Merge pull request #1928 from nextcloud/bugfix/noid/removeButterknife
remove unused butterknife binding
2022-05-06 14:39:55 +02:00
drone
3213bfaea9
Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-05-05 15:31:37 +02:00
drone
406ecc15ed Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-05-02 16:30:14 +00:00
Tim Krüger
d96a690329
Allow one more lint warning
Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-04-29 15:05:00 +02:00
drone
925d839ccd Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-04-29 08:27:47 +00:00
drone
941d35e03f Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-04-28 17:23:36 +00:00
drone
f99a33956a
Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-04-08 09:21:10 +02:00
drone
ee38afbf00
Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-04-08 09:21:10 +02:00
drone
28af2aa373
Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-03-29 17:38:00 +02:00
drone
09f926fd5f
Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-03-29 17:37:54 +02:00
Andy Scherzinger
af0065b664
Merge pull request #1873 from nextcloud/bugfix/noid/kotlinConversion3
Migrate ProfileController to Kotlin
2022-03-17 20:44:41 +01:00
drone
7a0ab36bc3
Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-03-17 17:35:52 +01:00
drone
a90c6bb20f
Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-03-17 17:35:49 +01:00
Andy Scherzinger
70edda976f
add hooks for commit/push
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-03-17 13:47:27 +01:00
drone
3a46e5e1d6
Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-03-16 11:13:15 +01:00
drone
b7b135bd53
Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-03-16 11:13:00 +01:00
Andy Scherzinger
306e522b00
bump lint
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-03-14 10:23:09 +01:00
drone
1903f6cd40 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-03-07 13:23:42 +00:00
drone
921553d684 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-02-28 17:30:58 +00:00
drone
045ed8d84f Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-02-28 17:29:48 +00:00
drone
2bbe818f28 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-02-28 16:27:19 +00:00
drone
114ed36da2 Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-02-28 16:25:42 +00:00
drone
f567967246 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-02-28 16:07:59 +00:00
drone
33ab3b7e06 Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-02-28 13:46:39 +00:00
drone
28682c44d0 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-02-28 12:33:02 +00:00
drone
a52c41468a Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-02-28 12:31:55 +00:00
drone
dacaf5b76b Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-02-25 11:49:33 +00:00
drone
d3c46e72f7
Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-02-25 12:11:46 +01:00
Tim Krüger
bad5b5f9bc
Update WebRTC library
The  updated libwebrtc will be load from the talk-clients-webrtc repository [1]
and not from a dependency repository. The 'lint' task must now depend on the
'perBuild' task to make sure that the WebRTC library is downloaded from the
configured URL.

To get the new version to work a change is needed because of this announcement:

> Google is planning to transition Chrome’s WebRTC implementation from the
> current SDP format (called “Plan B”) to a standards conformant format
> (“Unified Plan”, draft-ietf-rtcweb-jsep) over the next couple of quarters.
>
> - [2]

Currently we are in phase 4 of the transition [3]. So actually 'Plan B'
must be used to avoid bigger changes to our code base at this time. But
'Plan B' is depracted and will be removed in phase 5 of the transition
[4].

Resolves: #1773
See:
  - [1] https://github.com/nextcloud-releases/talk-clients-webrtc
  - [2] https://webrtc.org/getting-started/unified-plan-transition-guide
  - [3] https://webrtc.org/getting-started/unified-plan-transition-guide#phase_4_make_%E2%80%9Cplan_b%E2%80%9D_throw
  - [4] https://webrtc.org/getting-started/unified-plan-transition-guide#phase_5_remove_%E2%80%9Cplan_b%E2%80%9D

Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-02-23 11:34:30 +01:00
drone
c4977abddc
Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-02-18 14:13:22 +01:00
drone
1e9bba84e8 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-02-17 18:32:11 +00:00
drone
808ed6fcb4 Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-02-17 18:30:31 +00:00
drone
9b8ea52024
Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-02-16 11:34:11 +01:00
drone
dcdd0b7b0a
Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-02-16 11:34:09 +01:00
drone
01ce8ea20f
Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-02-16 11:34:07 +01:00
drone
7d062d7d4a Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-02-10 19:33:58 +00:00
drone
f6193276db Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-02-10 16:14:38 +00:00
Andy Scherzinger
4ca9ef7559
bump lint score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-02-07 21:29:46 +01:00
Marcel Hibbe
7f0980e6d2
format code + fix klint/findbugs warnings
remove hardcodings

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>

remove hardcodings

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-07 14:27:38 +01:00
drone
ca7861358d
fix klint + findbugs warnings
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-01-27 11:57:23 +01:00
drone
772fde2334
Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-01-26 15:00:32 +01:00
Marcel Hibbe
9b55467af3
moved execution of setUpPushTokenRegistration
so token is registered everytime the conversation list is opened.

In NextcloudTalkApplication it was not  executed when app was still in background when opening

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-01-26 15:00:32 +01:00
drone
051c608e08 Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2021-12-21 11:12:04 +00:00
Tim Krüger
d7b3ba17de
Add pipeline tests
Signed-off-by: Tim Krüger <t@timkrueger.me>
2021-12-08 14:51:58 +01:00
Tim Krüger
1db35c9030
Increment allowed warnings by one
The number of warnings increased because of a new version of
'com.google.android.exoplayer:exoplayer' is available. But the new version
enforces SDK 31.

Signed-off-by: Tim Krüger <t@timkrueger.me>
2021-12-03 14:29:59 +01:00
Andy Scherzinger
fbce40f935
increased due to new lib update dependency hit
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-18 14:55:47 +01:00
Tim Krüger
2370ad3c00
Gradle should log plain
With the parameter '--console=plain' Gradle produces a plain text log without
charachter garbage which is created by animations.

Signed-off-by: Tim Krüger <t@timkrueger.me>
2021-11-17 11:16:41 +01:00
drone
e41b74a960 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2021-11-11 21:20:03 +00:00
drone
e8852fe268 Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2021-11-11 21:18:53 +00:00
drone
5e4219c586
Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2021-11-11 13:52:18 +01:00
drone
bb0cf964d2
Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2021-11-11 13:52:18 +01:00
drone
43b54e015f
Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2021-11-11 13:52:12 +01:00
Marcel Hibbe
bda45d874c Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: Marcel Hibbe <drone@nextcloud.com>
2021-11-11 12:11:03 +00:00
Tim Krüger
0820964e53
Ignore generated JsonObjectMapper
Signed-off-by: Tim Krüger <t@timkrueger.me>
2021-11-10 15:56:49 +01:00
tobiasKaminsky
69485a1f3f
Use curl -k
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-11-10 08:34:14 +01:00
drone
749252a195 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2021-10-25 12:44:23 +00:00
Andy Scherzinger
792ea45bab
scripts: Have Drone properly signoff commits so that it doesn't break DCO
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Co-Authered-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-22 17:35:38 +02:00
Tim Krüger
90dd63d1f3
Use build flavor for implementation declaration
Instead of loading dependencies with an own snippet of code now the
provided functionality of configure flavor based implementation
declaration is used.

This change results in some more warning which will no be fixied in this
commit.

See: https://developer.android.com/studio/build/build-variants#dependencies

Signed-off-by: Tim Krüger <t@timkrueger.me>
2021-10-20 13:29:36 +02:00
Tim Krüger
7101fbc4c9
Merge branch 'master' into feature/noid/remove-overdraw-error
Signed-off-by: Tim Krüger <t@timkrueger.me>
2021-10-19 17:30:37 +02:00
drone
8f351bc8f0
Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <noreply@drone>
2021-10-19 17:29:01 +02:00
drone
721abd124c
Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <noreply@drone>
2021-10-19 14:05:42 +02:00
Marcel Hibbe
12e9985cd9
add unread mentions popup-bubble in conversations list
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-09-20 11:35:58 +02:00
drone
a488b9738e
fix lint and findbug warnings
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-09-03 13:07:21 +02:00
Andy Scherzinger
85b2cea618
Add order capabilities to file browser
Resolves #919

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-09-03 12:58:46 +02:00
Tim Krüger
fe989371de
Fix scrolling and selection issue in RTL
The following views had scrolling and selection issues if RTL is
activated:

- Conversation list
- File browser
- Contact selection

To fix this issues the fast scroller functionality were removed for
those views.

Signed-off-by: Tim Krüger <t@timkrueger.me>
2021-09-02 14:01:17 +02:00
Andy Scherzinger
febaaf8ea7
Revert "improve code check score"
This reverts commit 6415f163bd.

Revert "use context compat to load resources"

This reverts commit 3742c4ed99.

Revert "Adding upload from camera action"

This reverts commit 01a6675795.
2021-08-23 08:54:33 +02:00
Andy Scherzinger
6415f163bd
improve code check score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-08-21 18:28:55 +02:00
Andy Scherzinger
a5838dc44e
Improve RTL text flow for untranslated strings in rtl languages/views
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-07-17 14:00:50 +02:00
drone
dc22e7970c
Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <noreply@drone>
2021-07-15 10:07:43 +02:00
drone
cbc4c62003
Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <noreply@drone>
2021-07-15 10:07:42 +02:00
Andy Scherzinger
079286246a
bump score due to new category
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-07-12 09:51:22 +02:00
Andy Scherzinger
9aed3292e4 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-07-09 15:09:49 +00:00
Andy Scherzinger
5e88dc6f57
Use launcher icon as bot-avatar/system-conversation-icon on pre-Android O
Fixes #1417

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-07-08 14:31:12 +02:00
drone
61fd18a0ca Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <noreply@drone>
2021-07-02 12:12:55 +00:00
Andy Scherzinger
996770e470
check if view is (still) available
...since grid initialization is called in various places throughout the lifecycle

Fixes #1233

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 16:54:57 +02:00
drone
1b71fd39c3 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <noreply@drone>
2021-06-30 13:07:09 +00:00
Andy Scherzinger
60d14f3b35
SuppressLint("SetTextI18n")
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 13:44:00 +02:00
Andy Scherzinger
78cc0df7bd
spotbugs: use literal as comparison base
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 13:03:14 +02:00
Marcel Hibbe
741748137a
fix lint/spotbugs warnings
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-29 22:49:33 +02:00
Andy Scherzinger
00a778eeec
bump code analysis scores
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-22 11:18:08 +02:00
drone
f09bf938a7 Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <noreply@drone>
2021-06-21 15:44:44 +00:00
Andy Scherzinger
7803263c1d
bump spotbugs score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:23:02 +02:00
Andy Scherzinger
e984766631
Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:59 +02:00
Andy Scherzinger
99fb4b8b0d
Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:49 +02:00
Andy Scherzinger
f7e926244a
Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-09 13:50:30 +02:00
Andy Scherzinger
15d2c94d19
update code check scores
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:56 +02:00
Andy Scherzinger
ac936114ef
Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-31 17:21:36 +02:00
Andy Scherzinger
5bd27df382
lower lint score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-28 16:06:51 +02:00
Andy Scherzinger
799acc4f81
Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-26 13:44:05 +02:00
Marcel Hibbe
c1f55aa02e
add toast messages when exceptions were thrown
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-05-25 11:17:14 +02:00
Andy Scherzinger
72bb754e02
update lint score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-20 13:06:19 +02:00
Andy Scherzinger
1490ff3b50
Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-20 11:54:17 +02:00
Andy Scherzinger
629293e65e
add missing content description
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-18 18:36:51 +02:00
Andy Scherzinger
ffdffe1c9e
Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-18 18:15:57 +02:00
Andy Scherzinger
62983d647f
Drone: update results to reflect reduced error/warning count [skip ci]
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-14 13:28:28 +02:00
Joas Schilling
bc2fadb4c5
Add (read-only for now) description to the conversation info
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-12 14:35:50 +02:00
Andy Scherzinger
69a8898012
Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-12 09:15:31 +02:00
drone
a34ae3f49e Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <noreply@drone>
2021-05-11 08:12:44 +00:00
Andy Scherzinger
c91631a642
lint: Set locale
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-09 21:56:35 +02:00
drone
eba6fe0829
Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <noreply@drone>
2021-05-09 17:32:20 +02:00