mirrors/nextcloud-talk-android
1
0
Fork 0
mirror of https://github.com/nextcloud/talk-android.git synced 2024-11-24 14:05:40 +03:00
Code Issues Projects Releases Packages Wiki Activity
9558 commits 93 branches 407 tags 64 MiB
Commit graph

9558 commits

This branch
This branch
All branches
Author SHA1 Message Date
Sowjanya Kota
c3270079b4
Merge pull request #4261 from nextcloud/bugfix/4190/avoidNpeCurrentConversation 
try to avoid NPE for currentConversation
 2024-09-24 16:19:01 +02:00
Marcel Hibbe
b78267d96f
try to avoid NPE for currentConversation 
On gplay console the following NPE was reported for the line

participantPermissions = ParticipantPermissions(spreedCapabilities, currentConversation!!)

 E  FATAL EXCEPTION: main
          Process: com.nextcloud.talk2, PID: 6626
          java.lang.NullPointerException
          at com.nextcloud.talk.chat.ChatActivity.initObservers$lambda$13(ChatActivity.kt:583)
          at com.nextcloud.talk.chat.ChatActivity.$r8$lambda$QKH5JCFLmCzRMlSJ-EV-m4IW5ig(Unknown Source:0)

which seems that currentConversation was null. If it would have been spreedCapabilities, then the error would have been thrown in the line before..

A reason MAY BE that the observer is triggered before setData on the ViewModel is executed.
While this fix is just not executing code when currentConversation is null, it's unsure if it will follow up problems (like an empty chat) or if the observer is triggered another time when currentConversation is available.

So it's just a hotfix.
To improve the situation in the long term, we should move more logic to viewModel and only use Flow instead to mix it with LiveData.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2024-09-24 15:52:49 +02:00
Sowjanya Kota
68627ad752
Merge pull request #4263 from nextcloud/bugfix/4262/UninitializedPropertyAccessExceptionSpreedCapabilities 
avoid UninitializedPropertyAccessException for spreedCapabilities
 2024-09-24 15:47:37 +02:00
Marcel Hibbe
aeacfa09b6
avoid UninitializedPropertyAccessException for spreedCapabilities 
reported issue on gplay console was:

Exception kotlin.UninitializedPropertyAccessException: lateinit property spreedCapabilities has not been initialized
  at com.nextcloud.talk.chat.ChatActivity.getSpreedCapabilities (ChatActivity.kt:284)
  at com.nextcloud.talk.chat.ChatActivity.processExpiredMessages (ChatActivity.kt:2536)
  at com.nextcloud.talk.chat.ChatActivity.access$processExpiredMessages (ChatActivity.kt:204)
  at com.nextcloud.talk.chat.ChatActivity$initObservers$10$1.invokeSuspend (ChatActivity.kt:820)

This is just a hotfix while hoping processExpiredMessages is executed again while spreedCapabilities are available.

To improve the situation in the long term, we should move more logic to viewModel and have better control over sequence of actions.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2024-09-24 15:25:42 +02:00
Marcel Hibbe
3d9d6942e4
Merge pull request #4256 from nextcloud/solve_static_code_warnings 
Fix Codacy Warnings -  Ensure Composable Function Names Start with a Capital Letter
 2024-09-24 14:26:03 +02:00
sowjanyakch
78a55c016f
change functionPattern to support composable functions and ktlintFormat 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
 2024-09-24 13:43:30 +02:00
github-actions[bot]
715017d65f
Merge pull request #4260 from nextcloud/renovate/gradle-8.x 
Update dependency gradle to v8.10.2
 2024-09-24 01:00:38 +02:00
renovate[bot]
4f9122b685
Update dependency gradle to v8.10.2 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2024-09-23 22:55:13 +00:00
Marcel Hibbe
3b09da75a7
Merge pull request #4250 from nextcloud/conversation_creation_modification 
Conversation creation modification
 2024-09-23 16:44:59 +02:00
sowjanyakch
8bf9e3552e
rename variable selectedImageUri 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
 2024-09-23 16:40:06 +02:00
sowjanyakch
384ba6945f
ktlint format 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
 2024-09-23 16:40:06 +02:00
sowjanyakch
4dd22d6223
Get selectedImageUri from ViewModel 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
 2024-09-23 16:40:06 +02:00
sowjanyakch
bc02236801
Make Conversation name text limit to single line 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
 2024-09-23 16:40:06 +02:00
sowjanyakch
317f745806
Only display delete icon when user avatar is selected 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
 2024-09-23 16:40:05 +02:00
Nextcloud Android Bot
44e87dbd42 Weekly 20.1.0 Alpha 05 2024-09-23 03:12:39 +00:00
Marcel Hibbe
22c3f62382
Merge pull request #4239 from nextcloud/bugfix/noid/fixFederatedCallButtons 
fix to not remove call buttons for federated conversations after 30 seconds
 2024-09-20 13:46:45 +02:00
Marcel Hibbe
b080e891bb
fix to not remove call buttons for federated conversations after 30 seconds 
After 30 seconds (when the capabilities were updated) the call buttons of federated conversations were removed (this was done back then when fed calls were not implemented).

However this happened not always because of the check
"if (this::spreedCapabilities.isInitialized) {...."
It seems this check sometimes is false when it's supposed to be true. This has be to further investigated and has to be be simplified/improved by a cleaner architecture.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2024-09-20 13:46:21 +02:00
github-actions[bot]
1c94338a7b
Merge pull request #4253 from nextcloud/renovate/org.jetbrains.kotlinx-kotlinx-serialization-json-1.x 
Update dependency org.jetbrains.kotlinx:kotlinx-serialization-json to v1.7.3
 2024-09-19 19:25:39 +02:00
renovate[bot]
bddf1361f8
Update dependency org.jetbrains.kotlinx:kotlinx-serialization-json to v1.7.3 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2024-09-19 16:56:56 +00:00
Julius Linus
5351296afd
Merge pull request #4240 from nextcloud/bugfix/4238/fixToHideMessageInputWhenNoRestriction 
fix to hide messageInputFragment when user has no restriction to write
 2024-09-19 18:48:25 +02:00
github-actions[bot]
11fb200f0d
Merge pull request #4247 from nextcloud/renovate/github-codeql-action-3.x 
Update github/codeql-action action to v3.26.8
 2024-09-19 12:47:14 +02:00
renovate[bot]
7a91e3a38f
Update github/codeql-action action to v3.26.8 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2024-09-19 10:37:37 +00:00
Nextcloud bot
663ba0a2ed
Fix(l10n): Update translations from Transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2024-09-19 02:51:16 +00:00
github-actions[bot]
444dabda1e
Merge pull request #4246 from nextcloud/renovate/lifecycleversion 
Update lifecycleVersion to v2.8.6
 2024-09-18 23:33:12 +02:00
github-actions[bot]
d7e725d490
Merge pull request #4245 from nextcloud/renovate/androidx.lifecycle-lifecycle-viewmodel-compose-2.x 
Update dependency androidx.lifecycle:lifecycle-viewmodel-compose to v2.8.6
 2024-09-18 23:30:42 +02:00
renovate[bot]
7c37d1f111
Update lifecycleVersion to v2.8.6 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2024-09-18 21:26:18 +00:00
renovate[bot]
d480fe3008
Update dependency androidx.lifecycle:lifecycle-viewmodel-compose to v2.8.6 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2024-09-18 21:24:09 +00:00
github-actions[bot]
cb114b64f1
Merge pull request #4244 from nextcloud/renovate/androidx.lifecycle-lifecycle-runtime-ktx-2.x 
Update dependency androidx.lifecycle:lifecycle-runtime-ktx to v2.8.6
 2024-09-18 22:34:32 +02:00
github-actions[bot]
5c84125aa4
Merge pull request #4243 from nextcloud/renovate/androidx.compose-compose-bom-2024.x 
Update dependency androidx.compose:compose-bom to v2024.09.02
 2024-09-18 22:28:47 +02:00
renovate[bot]
ef3cd824c0
Update dependency androidx.lifecycle:lifecycle-runtime-ktx to v2.8.6 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2024-09-18 20:20:43 +00:00
github-actions[bot]
09ebaf0dbd
Merge pull request #4242 from nextcloud/renovate/androidx.compose.ui-ui-test-junit4-1.x 
Update dependency androidx.compose.ui:ui-test-junit4 to v1.7.2
 2024-09-18 22:19:04 +02:00
renovate[bot]
c1c68570b3
Update dependency androidx.compose:compose-bom to v2024.09.02 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2024-09-18 20:18:10 +00:00
renovate[bot]
bc57bb20de Update dependency androidx.compose.ui:ui-test-junit4 to v1.7.2 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2024-09-18 22:10:23 +02:00
github-actions[bot]
73b919d5e9
Merge pull request #4241 from nextcloud/renovate/androidx.compose.runtime-runtime-1.x 
Update dependency androidx.compose.runtime:runtime to v1.7.2
 2024-09-18 22:07:53 +02:00
renovate[bot]
6122650202
Update dependency androidx.compose.runtime:runtime to v1.7.2 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2024-09-18 19:56:24 +00:00
Marcel Hibbe
9e91bdeb1d
fix to hide messageInputFragment when user has no restriction to write 
The messageInputFragment was hidden by checkShowMessageInputView(), but it was immediately shown again by checkLobbyState()

This fix will execute checkShowMessageInputView() inside checkLobbyState() in the correct order.

Additionally, the check
checkLobbyState()
has to be already executed in
GetCapabilitiesInitialLoadState
as well as
checkShowCallButtons()

Otherwise the expected behavior would only be set after 30 seconds.

An improvemnt for the future must be to improve the capabilities handling.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2024-09-18 17:34:10 +02:00
Nextcloud bot
3db9bc6247
Fix(l10n): Update translations from Transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2024-09-18 02:53:40 +00:00
github-actions[bot]
6b89fe4aed
Merge pull request #4237 from nextcloud/renovate/com.android.tools.build-gradle-8.x 
Update dependency com.android.tools.build:gradle to v8.6.1
 2024-09-18 03:05:21 +02:00
renovate[bot]
45ecaed26d
Update dependency com.android.tools.build:gradle to v8.6.1 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2024-09-18 00:58:18 +00:00
Marcel Hibbe
529218aac0
Merge pull request #4233 from nextcloud/bugfix/noid/doNotShowErrorWhenPendingInvitationsFailed 
dont show error when fetching pending invitations failed
 2024-09-17 12:05:57 +02:00
Marcel Hibbe
28906dd999
dont show error when fetching pending invitations failed 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2024-09-17 12:05:02 +02:00
Marcel Hibbe
e66dc4d805
Merge pull request #4231 from nextcloud/bugfix/noid/fixToShowAccountsFromOlderServers 
fix to show accounts from older servers in switch account dialog
 2024-09-17 11:43:33 +02:00
Marcel Hibbe
5991b91460
fix to show accounts from older servers in switch account dialog 
if invitations were not supported, the account did not show up

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2024-09-17 11:30:36 +02:00
Marcel Hibbe
951c073db1
Merge pull request #4221 from nextcloud/bugfix/4219/fixToShowUserStatus 
fix to show user status in conversation list
 2024-09-17 11:05:17 +02:00
Marcel Hibbe
722914fb6c
fix to show user status in conversation list 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2024-09-17 11:04:18 +02:00
Marcel Hibbe
3b51fde300
Merge pull request #4223 from nextcloud/bugfix/noid/fixNoChatForOldNcServerVersion 
fix to load chat for old server version
 2024-09-17 11:00:21 +02:00
github-actions[bot]
d9632ab5ad
Merge pull request #4228 from nextcloud/renovate/ubuntu-noble 
Update ubuntu:noble Docker digest to dfc1087
 2024-09-17 07:15:12 +02:00
renovate[bot]
7bbe4f8673
Update ubuntu:noble Docker digest to dfc1087 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2024-09-17 05:08:03 +00:00
Nextcloud bot
2f05ffb3d6
Fix(l10n): Update translations from Transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2024-09-17 02:55:40 +00:00
github-actions[bot]
c98c316272
Merge pull request #4226 from nextcloud/renovate/ubuntu-noble 
Update ubuntu:noble Docker digest to 56a8952
 2024-09-17 02:51:38 +02:00