mirrors/nextcloud-talk-android
1
0
Fork 0
mirror of https://github.com/nextcloud/talk-android.git synced 2024-12-17 22:21:57 +03:00
Code Issues Projects Releases Packages Wiki Activity
4156 commits 95 branches 415 tags 79 MiB
Commit graph

2033 commits

Author SHA1 Message Date
Andy Scherzinger
973d13f902
Merge pull request #2005 from nextcloud/bugfix/1978/fixNPEpeerConnectionWrapper 
Bugfix/1978/fix npe in peerConnectionWrapper
 2022-05-09 15:31:59 +02:00
Marcel Hibbe
d88c01367c
fix NPE #1977 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-05-09 13:19:46 +02:00
Marcel Hibbe
a1c5e942cd
reformat code 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-05-09 13:15:11 +02:00
Marcel Hibbe
a43a51b931
try to fix #1978 
i suspect that peerConnectionFactory could have been null because e.g. "hangup()" was already called which sets it to null. Because of some async task getOrCreatePeerConnectionWrapperForSessionIdAndType might still be called afterwards and it failed because peerConnectionFactory was already null.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-05-09 13:00:01 +02:00
Marcel Hibbe
4414002b8a
reformat code 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-05-09 12:44:51 +02:00
Tim Krüger
370c51ec2d Use 'lateinit' for injected properties 
Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-05-07 11:21:29 +00:00
Tim Krüger
f9020dbc2b Reduce number of Detekt issues 
Reduce the number of Detekt issues for the 'OperationsMenuController' by
splitting the function 'processOperation' into smaller pieces. But in
the end it is not enough, because also the now short function
'processOperation' is too complex for Detekt. Because of that the
suppress annotation is set.

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-05-07 11:21:29 +00:00
Andy Scherzinger
aebebe5410 Migrate OperationsMenuController to kotlin 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-05-07 11:21:29 +00:00
Andy Scherzinger
0c5429bd7b
Merge pull request #2001 from nextcloud/bugfux/1975/fixNPEforMimetype 
make attributes of file nullable and handle null values
 2022-05-07 12:54:56 +02:00
Marcel Hibbe
59f1f003ca
avoid NPE 
trying to avoid #1976

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-05-06 23:48:44 +02:00
Marcel Hibbe
a5f7ecc5d8
make attributes of file nullable and handle null values 
nullable attributes of files can be found at https://github.com/nextcloud/server/blob/master/lib/public/RichObjectStrings/Definitions.php#L303-L351

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-05-06 23:21:10 +02:00
Marcel Hibbe
30f65424a5
fix NPE for viewbinding 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-05-06 14:58:30 +02:00
Andy Scherzinger
6cdce6db50
Merge pull request #1928 from nextcloud/bugfix/noid/removeButterknife 
remove unused butterknife binding
 2022-05-06 14:39:55 +02:00
Andy Scherzinger
fafbcbd1cd
Merge pull request #1957 from nextcloud/bugfix/1956/hideReactionsForReadOnlyConversations 
Hide reactions from menu if conversation is read-only
 2022-05-06 14:38:15 +02:00
Andy Scherzinger
8f654937de
Always show reaction count 
Resolves #1983

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-05-05 22:51:20 +02:00
drone
be1b075234 Merge commit 'e52b2d8b7ffbad4e4343bb6b97d40663ddc58149' 2022-05-05 11:06:39 +00:00
Tim Krüger
e52b2d8b7f
Add null checks and extract constants 
Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-05-05 13:06:15 +02:00
Tim Krüger
4f5a344a20
Add handling for "event.participants.update.all" 
In case a moderator of a restricted room ends the call for all
participants a update participants event with the field 'all=true' will
be thrown by the HPB.

    {
      "type": "event"
      "event": {
        "target": "participants",
        "type": "update",
        "update": [
          "roomid": "the-room-id",
          "incall": new-incall-state,
          "all": true
        ]
      }
    }

In that case the call can be ended directly without handling every
single participant.

Resolves: #1881

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-05-04 13:49:04 +02:00
Tim Krüger
0c1303e0af
Fix Detekt issues in LocationPickerController 
- LongMethod - 94/60 - [initMap]
- ComplexMethod - 15/10 - [initMap]
- ReturnCount - [areAllGranted]

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-05-04 11:30:17 +02:00
Tim Krüger
377e171156
Fix Detekt issues in ChatUtils 
- ComplexMethod - 11/10 - [getParsedMessage]
- NestedBlockDepth - 4/4 - [getParsedMessage]

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-05-04 11:30:06 +02:00
Marcel Hibbe
d6a4e54957
fix klint 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-05-03 12:47:04 +02:00
Tim Krüger
8e981f04b0
Catch NPE on ServerSelection view binding 
Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-05-03 12:47:03 +02:00
Tim Krüger
b60de3858b
Catch NPE on Chat view binding 
Resolves: #1960

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-05-03 12:47:03 +02:00
Tim Krüger
5cb36d0801
Catch NPE on Profile view binding 
Resolves: #1959

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-05-03 12:47:03 +02:00
Tim Krüger
ff5f686d7c
Catch NPE on webLogin view binding 
Resolves: #1958

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-05-03 12:47:03 +02:00
Marcel Hibbe
7f2b337565
fix to load conversations when servers status app is disabled 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-05-03 11:16:54 +02:00
Andy Scherzinger
572a212fc1
hide reactions from menu if conversation is read-only 
Fixes #1956

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-05-02 23:01:58 +02:00
Andy Scherzinger
38146dabf0
remove unused butterknife binding 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-05-02 18:09:58 +02:00
Daniel Calviño Sánchez
3274c1e1fa
Fix typo in name of method to check if video should not be received 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2022-05-02 13:36:13 +02:00
Marcel Hibbe
d539161768
fix NumberFormatException 
fix NumberFormatException for files >2,14 GB (=limit that can be represented by Int)

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-05-02 10:54:49 +02:00
Marcel Hibbe
2e54c456d1
fix klint warning 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-29 15:32:54 +02:00
Marcel Hibbe
e0d1f16106
show progress bar also when user left and re-entered the media tab screen 
how to test:
1. click on file with big file size that was not clicked before (so it's not in the cache)
2. leave media tab view or just select other tab.
3. go back to the clicked file
4. --> see that progress bar is still spinning (otherwise it's already finished and a click should oen the file directly without showing the progress bar)

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-29 15:24:56 +02:00
Marcel Hibbe
734f33caba
add fallback image for mimetype if drawee request fails 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-29 14:24:14 +02:00
Tim Krüger
a64e22c820
Fix ktlin issues 
Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-04-29 14:09:36 +02:00
Tim Krüger
afe61b7aa1
Unify naming of shared item layouts 
Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-04-29 14:03:59 +02:00
Tim Krüger
58acf3edc8
Rename 'SharedItemsAdapter' to 'SharedItemsGridAdapter' 
Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-04-29 13:44:11 +02:00
Tim Krüger
721797c078
Hide tabs without content in shared items view 
Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-04-29 13:41:54 +02:00
Marcel Hibbe
b22ed7399d
fix to close media view when press back button 
when starting media tab from conversation info, the back button opened media tab again. to fix this FLAG_ACTIVITY_CLEAR_TOP was set as flag

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-29 13:21:30 +02:00
Marcel Hibbe
b49a1bbbde
fix klint warnings 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-29 12:26:30 +02:00
Marcel Hibbe
a91ff9e920
make tabbar full width 
improve design

hide "Other" tab

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-29 11:53:59 +02:00
Marcel Hibbe
8c20180545
show mimetype icons from DrawableUtils 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-29 11:53:59 +02:00
Marcel Hibbe
fd08ad965a
add filesize and date to listview for shared items 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-29 10:53:00 +02:00
Tim Krüger
962e43857e
Check for spreed capability "rich-object-list-media" 
If the capability is not available the shared items can't shown.

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-04-29 10:04:56 +02:00
Andy Scherzinger
5c662427f8
improve detekt score 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-04-28 21:29:54 +02:00
Andy Scherzinger
eaab887765
refactor duplicated code 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-04-28 21:18:29 +02:00
Andy Scherzinger
48c7ccb4b0
improve detekt score 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-04-28 21:10:21 +02:00
Andy Scherzinger
f5d70dab0c
mediaItems can be null 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-04-28 18:36:34 +02:00
Tim Krüger
6f277cbe92
Fix new introduced SpotBugs error and warnings 
Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-04-28 17:57:30 +02:00
Tim Krüger
000184a338
Remove lint error for using 'Hashmap#forEach' 
Call requires API level 24 (current min is 21): java.util.HashMap#forEach

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-04-28 17:37:22 +02:00
Tim Krüger
6b671191e9
Fix ktlint warning 
Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-04-28 17:14:10 +02:00