Commit graph

1504 commits

Author SHA1 Message Date
Andy Scherzinger
f52d7f29d9
replace nominatimClient with copied/pacthes version replacing legacy httpClient with okhttp3
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:58 +02:00
Andy Scherzinger
ba64d693ef
further codacy improvements
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:56 +02:00
Andy Scherzinger
03fda89a22
reformat kotlin
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:55 +02:00
Andy Scherzinger
a8368e626e
improve codacy score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:52 +02:00
Andy Scherzinger
01a552b8d3
reformat code for ktlint compliance
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:47 +02:00
Andy Scherzinger
f899ee1d2f
make httpclient compileOnly since it ships with the OS
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:46 +02:00
Andy Scherzinger
6ba541b6b1
Move message holders to native view bindings
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:44 +02:00
Andy Scherzinger
71bffc0ea8
suppress generic exception handling warnings
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:42 +02:00
Andy Scherzinger
3c4714f716
fix after rebase
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:39 +02:00
Andy Scherzinger
ac986c61aa
cleanup to new base controller logic
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:36 +02:00
Andy Scherzinger
73e0b4e719
polish location map and move to native view bindings
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:34 +02:00
Andy Scherzinger
9f8a98ba07
remove unused imports
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:32 +02:00
Andy Scherzinger
adda60c7fb
Use native view bindings for GeocodingController
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:30 +02:00
Andy Scherzinger
43bf2ca7ae
use right context to be day/night theme aware
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:27 +02:00
Marcel Hibbe
94e466598e
add copyright headers
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:26 +02:00
Marcel Hibbe
4cdd13c92e
use CapabilitiesUtil for geo-location-sharing
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:23 +02:00
Marcel Hibbe
0568ea6e72
update location when gps changed
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:21 +02:00
Marcel Hibbe
751cd1268e
replace current-position icon
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:19 +02:00
Marcel Hibbe
22333d2f57
disable text fields for location messages (workaround)
i tried to suppress that zip codes are shown as clickable telephopne numbers. but
  android:autoLink="none"
and
  messageText!!.linksClickable = false
don't seem to work.
as a workaround i disabled the text field completely. so the links are still underlined but nut clickable. and it's also not possible now to mark text and get the context menu.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:18 +02:00
Marcel Hibbe
3cb0fe75b1
remove unnecessary logic from LocationMessageViewHolders
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:16 +02:00
Marcel Hibbe
4190cf1dfe
add FLAG_ACTIVITY_NEW_TASK for incoming location message
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:14 +02:00
Marcel Hibbe
2154b6cf94
improve design of share location button / location description
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:12 +02:00
Marcel Hibbe
9ffd5a7579
hide location sharing when capability is missing
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:09 +02:00
Marcel Hibbe
d4e49a20bb
decrease lint warnings
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:06 +02:00
Marcel Hibbe
fdf6b04fb8
decrease spotbugs warnings
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:02 +02:00
Marcel Hibbe
60827afe5c
decrease lint warnings
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:59 +02:00
Marcel Hibbe
ffdc630b76
avoid UNSAFE_HASH_EQUALS reported by SpotBugs
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:58 +02:00
Marcel Hibbe
ab63a1970b
extract hardcodings
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:56 +02:00
Marcel Hibbe
49b2455a23
reverse-geocode before sharing if address-name is empty
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:54 +02:00
Marcel Hibbe
d7a8935709
show geocoded location on map before sharing
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:53 +02:00
Marcel Hibbe
96e5e544ea
share geocoding-result on click
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:51 +02:00
Marcel Hibbe
26ae4fa548
share geocoded location
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:50 +02:00
Marcel Hibbe
2f0105abd3
add location search with nominatim
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:49 +02:00
Marcel Hibbe
d5face5941
improve design for locationpicker screen
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:47 +02:00
Marcel Hibbe
e8a9fa6303
add "...sent a location" strings for Conversation list
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:46 +02:00
Marcel Hibbe
095c13172c
share location to chat by button click
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:44 +02:00
Marcel Hibbe
ae485d1d80
delete example activity for leaflet
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:43 +02:00
Marcel Hibbe
1aa15ebd95
differ between incoming and outcoming messages for location
logic was copied from:
- MagicIncomingTextMessageViewHolder.kt
- MagicOutcomingTextMessageViewHolder.kt

xml design was copied from:
- item_custom_incoming_text_message.xml
- item_custom_outcoming_text_message.xml

... and extended for location related things.

because of copying there is now quite a lot of redundant code! But ViewHolders should generally be refactored in the future.. (better inheritance(?) and analyze which of Marios changes to the Chatkit lib were really necessary or if this can be done in an other way..)

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:42 +02:00
Marcel Hibbe
7540e57dd8
open geolink on click + minor refactoring
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:40 +02:00
Marcel Hibbe
04fb57df7a
pass java to javascript params with URLEncoder
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:39 +02:00
Marcel Hibbe
5da43d1760
wip. show leaflet inside webview in message
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:37 +02:00
Marcel Hibbe
ba7bfe3150
chnage LocationMessageViewHolder to kotlin
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:36 +02:00
Marcel Hibbe
4d29a4b638
add LocationMessageViewHolder for ChatKit
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:35 +02:00
Marcel Hibbe
1e2960a72a
add example for leaflet in WebView
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:33 +02:00
Marcel Hibbe
73becd432d
add logic for geolocation message
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:32 +02:00
Marcel Hibbe
965692ce7e
set location picker icon over map
show location when clicked on button

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:31 +02:00
Marcel Hibbe
0742afe58c
add map via osmdroid
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:30 +02:00
Marcel Hibbe
c6d3abf421
add entry to share location
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:25 +02:00
Andy Scherzinger
5d41b0fae2
rename HashMap
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-09 13:50:28 +02:00
Andy Scherzinger
047372ad37
flip string com pare for null-safety
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-09 13:50:27 +02:00
Andy Scherzinger
893f015edf
shorten Log Tag
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-09 13:50:25 +02:00
Andy Scherzinger
cf24965f7f
code formatting, make TAG final
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-09 13:50:24 +02:00
Andy Scherzinger
f3dd482476
link swipe-to-reply to messages replyable-flag
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-09 13:50:18 +02:00
Marcel Hibbe
e03f048126
fix displaying of large images
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-09 13:19:49 +02:00
Andy Scherzinger
db231ed12b
update after rebase, lower detekt score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 23:26:09 +02:00
Andy Scherzinger
7372d108a7
housekeeping to improve codacy/detekt score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 23:21:20 +02:00
Andy Scherzinger
bc20e0438f
replace magic numbers with constants
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 23:20:55 +02:00
Andy Scherzinger
292bee8396
Swipe to reply for chat messages (incoming/outgoing/preview)
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 23:20:54 +02:00
Andy Scherzinger
b513d0f154
improve detekt score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:37:06 +02:00
Andy Scherzinger
e4da772882
ignore detekt for"Detekt.TooGenericExceptionCaught" in scenarios where we need to handle NPE explicitly
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:37:05 +02:00
Andy Scherzinger
40a08394bc
hardened view binding interaction
...in case of asynchronous UI interaction with already destroyed UI

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:37:02 +02:00
Andy Scherzinger
7b7eaa455d
binding isn't nullable
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:37:01 +02:00
Andy Scherzinger
ebc3dbdf79
improve readability of toolbar/searchbar handling code
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:58 +02:00
Andy Scherzinger
266a9f73ee
add destruction check before accessing the binding object
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:53 +02:00
Andy Scherzinger
faf9ce2884
combine nested ifs
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:48 +02:00
Andy Scherzinger
46a18ca3a0
organize imports
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:45 +02:00
Andy Scherzinger
f8a8b81ef7
line length 1220 characters
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:43 +02:00
Andy Scherzinger
f4cfc9cef3
improve spotbugs
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:41 +02:00
Andy Scherzinger
cfe00937c5
comment unused, overridden methods and respect 120 character line length
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:39 +02:00
Andy Scherzinger
e7ea57bf85
reformat kotlin
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:37 +02:00
Andy Scherzinger
45a88c0722
replace menu switch statements with if/else
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:34 +02:00
Andy Scherzinger
3c0ef1d1e0
add linebreak
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:32 +02:00
Andy Scherzinger
63fabeda09
convert lock controller to kotlin
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:31 +02:00
Andy Scherzinger
7669108d38
add author infos
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:29 +02:00
Andy Scherzinger
85fe560fc1
reformat code for 120 line length
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:27 +02:00
Andy Scherzinger
14fc3c8146
move back to User java entity definition
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:26 +02:00
Andy Scherzinger
d372335d57
hardening chat controller by null-checking any UI access due to asynchronous UI accesses
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:24 +02:00
Andy Scherzinger
8d6b526576
use capabilities helper
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:22 +02:00
Andy Scherzinger
1134172faa
adapt to rebase
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:21 +02:00
Andy Scherzinger
e2c6fd7c25
migrate chat controller to native view binding
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:19 +02:00
Andy Scherzinger
0e92e5ea2d
code format kotlin code
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:18 +02:00
Andy Scherzinger
4784a22e18
update headers and format code
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:16 +02:00
Andy Scherzinger
ca8d6cb782
Move controller to new view binding utilizing logic
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:10 +02:00
Andy Scherzinger
cd5f083a49
make text preview dark/light aware, overall improvement of preview screens
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-31 15:29:00 +02:00
tobiasKaminsky
46790c9bde
Correct fix for not showing bold on read ConversationItem
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-05-28 10:00:57 +02:00
Marcel Hibbe
1673d15e5e
dont show deletion option for attachments
(deletion for attachments in talk is not supported by server)

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-05-27 09:30:04 +02:00
Andy Scherzinger
98e5ff5771
remove unsed imports
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-26 14:39:18 +02:00
Andy Scherzinger
02a129c3fc
Add error logging when reading user profile from server
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-26 14:26:37 +02:00
Andy Scherzinger
c3e336b716
align avatar placeholders with dark/light theme and add placeholder to settings avatar
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-26 11:04:31 +02:00
Andy Scherzinger
93a1d411e0
set fallback avatar icon
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-25 17:41:30 +02:00
Andy Scherzinger
45ed897c34
reformat kotlin code
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-25 12:38:07 +02:00
Marcel Hibbe
8c99dde497
remove toasts from worker
(were accidentally added in PR #1284)

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-05-25 12:26:23 +02:00
Marcel Hibbe
c1f55aa02e
add toast messages when exceptions were thrown
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-05-25 11:17:14 +02:00
Marcel Hibbe
59ccc19ebe
add ability to share plain text
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-05-25 11:03:25 +02:00
Marcel Hibbe
36fdd6d82b
add ability to "share to" files to nextcloud talk app
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-05-25 11:03:21 +02:00
Andy Scherzinger
0662e9bd39
Merge pull request #1275 from nextcloud/bugfix/1272/instantDarkLightConversationIconAdaption
Instant adoption of dark/light theming for default conversation icons
2021-05-21 15:47:09 +02:00
Joas Schilling
3ca56793ff
Merge pull request #1276 from nextcloud/conversationActions
Make observer type save
2021-05-21 09:49:30 +02:00
Andy Scherzinger
123ef3d0ce
set user icon to have a fallback for account switcher icon in search bar
Fixes #1139

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-21 00:03:12 +02:00
Andy Scherzinger
d0a6c96668
make observer type save
fixes #1270

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-20 22:12:06 +02:00
Andy Scherzinger
ef9021340e
instant adaption of dark/light theming for default conversation icons
Fixes #1272

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-20 15:16:12 +02:00