Commit graph

2278 commits

Author SHA1 Message Date
Andy Scherzinger
4685bced16
reformat kotlin
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-03-17 18:37:15 +01:00
Marcel Hibbe
1b30a6ef62
allow getPeersForCall without QueryMap
- null was not allowed for query map (led to Illegal Argument Exception which caused issue #1853)

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-03-17 15:17:32 +01:00
Marcel Hibbe
5a90f999dc
add error logging
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-03-17 13:53:20 +01:00
Andy Scherzinger
bafa1559db
reformat kotlin
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-03-16 18:13:42 +01:00
Andy Scherzinger
766d07d3fa
prevent null-pointer in case remote file listing UI gets closed before the async loading comes back
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-03-16 16:57:13 +01:00
Andy Scherzinger
7db5c5ed76
migrate ProfileController to kotlin
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-03-16 16:50:37 +01:00
Andy Scherzinger
eed209428e
splitting up complex methods into smaller, easier to understand methods
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-03-15 18:21:29 +01:00
Andy Scherzinger
ac703a6ac7
extract magic numbers
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-03-15 17:46:40 +01:00
Andy Scherzinger
0ac5009242
reformat kotlin
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-03-15 17:45:06 +01:00
Andy Scherzinger
6b7dd29b07
migrate WebViewLoginController to kotlin
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-03-15 17:45:05 +01:00
Andy Scherzinger
ed4d27aff0
fix author mail
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-03-15 17:45:05 +01:00
Andy Scherzinger
cfe4847732
migrate RingtoneSelectionController to kotlin
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-03-15 17:44:52 +01:00
Tim Krüger
60e4ec9086
Use 'val' for never modified variables
Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-03-15 14:35:08 +01:00
Dariusz Olszewski
1e76b45fb4
Switch to chat w/o animation when app opened from notification
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-03-15 14:35:08 +01:00
Dariusz Olszewski
ddcf1c48aa
Workaround for crash when loading avatar
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-03-15 13:33:30 +01:00
Andy Scherzinger
f36b7750de
format kotlin code
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-03-14 10:23:08 +01:00
Andy Scherzinger
ba3e24bbc7
replace too long paramter lists with data classes
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-03-14 10:23:07 +01:00
Andy Scherzinger
6e02c5de41
reformat kotlin
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-03-14 10:23:07 +01:00
Andy Scherzinger
6206e4910d
simplify complex conditions for readability
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-03-14 10:23:06 +01:00
Andy Scherzinger
454dbc5db2
unify http(s) protocoll prefix check on urls
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-03-14 10:23:06 +01:00
Andy Scherzinger
a10b67456c
ignore generic exception handling
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-03-14 10:23:05 +01:00
Andy Scherzinger
2102f0fbc8
document empty blocks
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-03-14 10:23:01 +01:00
Tim Krueger
08dc22c30f
Merge pull request #1841 from nextcloud/bugfix/1839/fail-to-set-empty-status-message
Bugfix/1839/fail to set empty status message
2022-03-11 15:33:58 +01:00
Tim Krüger
cb1dd8e5b5
Avoid empty status message
Enable the 'Set status message' button only if a message is set.
Currently the API don't allow us to set an empty message [1].

See:
  [1] nextcloud/server#31452
  #1839

Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-03-10 17:08:02 +01:00
Tim Krüger
f8e8a95b34
Use '==' instead of 'equals' in Kotlin
In Kotlin for a check of the structural equality '==' should be used.
Referential equality is checked with '==='.

See:
 - https://kotlinlang.org/docs/equality.html

Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-03-10 17:05:14 +01:00
Tim Krueger
70a30f146a
Merge pull request #1851 from nextcloud/bugfix/1848/showSystemMessageAddedGroup
add groups and circles to system messages ("add"+"remove")
2022-03-09 10:37:19 +01:00
Andy Scherzinger
0fe562d415
remove unused method parameters
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-03-07 13:40:42 +01:00
Tim Krüger
5ad6da86f1
Use Boolean constant values directly
From the SpotBugs report:

> NAB_NEEDLESS_BOOLEAN_CONSTANT_CONVERSION: Method needlessly boxes a boolean
> constant
>
> This method assigns a Boxed boolean constant to a primitive boolean variable,
> or assigns a primitive boolean constant to a Boxed boolean variable. Use the
> correct constant for the variable desired. Use
>
>
> boolean b = true;
> boolean b = false;
>
> or
>
>
> Boolean b = Boolean.TRUE;
> Boolean b = Boolean.FALSE;
>
> Be aware that this boxing happens automatically when you might not expect it.
> For example,
>
>
> Map statusMap = ...
>
> public Boolean someMethod() {
>     statusMap.put("foo", true);  //the "true" here is boxed
>     return false;  //the "false" here is boxed
> }
>
> has two cases of this needless autoboxing. This can be made more efficient by
> simply substituting in the constant values:
>
>
> Map statusMap = ...
>
> public Boolean someMethod() {
>     statusMap.put("foo", Boolean.TRUE);
>     return Boolean.FALSE;
> }

Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-03-07 13:11:23 +01:00
Andy Scherzinger
8e11f21233
adapt to java->kotlin changes regarding null-ability
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-03-07 09:55:30 +01:00
Andy Scherzinger
15e875f974
Migrate push models to kotlin data classes
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-03-07 09:50:19 +01:00
Marcel Hibbe
a1e694104c
add groups and circles to system messages ("add"+"remove")
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-03-04 14:58:46 +01:00
Marcel Hibbe
0079107461
revert commit d76203a0
fix to support older conversationApi versions for canLeave and canDelete

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-03-04 09:23:42 +01:00
Marcel Hibbe
86caa48636
add logging for onError
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-03-04 09:23:41 +01:00
Andy Scherzinger
aa2a08692f
migrate statuses overall to kotlin data classes
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-03-03 18:00:53 +01:00
Andy Scherzinger
2008fb0c2a
migrate remaining status models to kotlin
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-03-03 12:50:58 +01:00
Marcel Hibbe
508f519468
set fixed avatar sizes for requests
necessary because of https://github.com/nextcloud/server/pull/31010

known issue: avatars in chat messages are too big atm

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-03-02 15:15:22 +01:00
Andy Scherzinger
00c4b13f17
don't resize avatar views dynamically
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-03-02 14:33:53 +01:00
Tim Krüger
3411728597
Pass 'null' for unset icon in custom status message
The OCS Status API  expect an valid emoji or 'null' for the status icon
in a custom message:

> field: statusIcon
> type: string/null
> Description: The icon picked by the user (must be an emoji, at most one)

See [1] for more details.

Resolves: #1839
See:
 [1] https://docs.nextcloud.com/server/latest/developer_manual/client_apis/OCS/ocs-status-api.html#set-a-custom-message-user-defined

Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-03-02 09:50:08 +01:00
Dariusz Olszewski
93556da33a
Re-use existing ChatController from notification
NotificationWorker provides the user information under KEY_USER_ENTITY parameter of the notification intent, but does not set the KEY_INTERNAL_USER_ID parameter.
With this change existing ChatController instance that has been opened manually from the conversation list is properly reused when a notification is opened.
Otherwise two instances of the ChatController were running in parallel for the same room, causing unintended side effects.

Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-03-01 13:19:18 +01:00
Dariusz Olszewski
c95d286de4
ktlint
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-03-01 13:19:18 +01:00
Dariusz Olszewski
a7bd6393df
Prevent overlapping pullChatMessages calls
Sometimes pullChatMessages may be called before response to a previous call is received.
In such cases just ignore the second call. Message processing will continue when response to the earlier call is received.

Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-03-01 13:19:18 +01:00
Dariusz Olszewski
b2aef87b24
Re-organize sessionId handling
- clean session Id when leaving the room rather than in onAttach
- invoke leaveRoom in onDetach only when we have a valid sessionId
This avoid calling joinRoom twice in some scenarios, or calling leaveRoom before joinRoom completes successfully.

Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-03-01 13:19:17 +01:00
Dariusz Olszewski
d31e6de5c4
Second attempt to fix the issue
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-03-01 13:19:17 +01:00
Dariusz Olszewski
d064ad3f65
Simplified code to avoid NullPointerException when server response arrives after the view was unbound.
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-03-01 13:19:17 +01:00
Dariusz Olszewski
606c6b0b9e
Avoid NullPointerException when server response arrives after the view was unbound.
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-03-01 13:19:17 +01:00
Dariusz Olszewski
505bcdfe20
Yet more diagnostic logging
Also in ConversationsListController

Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-03-01 13:19:16 +01:00
Dariusz Olszewski
cfcfcf5bc4
Even more diagnostic logging
Info to correlate calls and responses
Log errors

Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-03-01 13:19:16 +01:00
Dariusz Olszewski
b88530da6f
More diagnostic logging
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-03-01 13:19:16 +01:00
Dariusz Olszewski
b10d0cb98a
Revert "Notifications from lock screen - initial attempt to fix the issue"
This reverts commit ce8bec73

Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-03-01 13:19:16 +01:00
Dariusz Olszewski
dfa14e7c52
Notifications from lock screen - initial attempt to fix the issue
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-03-01 13:19:15 +01:00
Dariusz Olszewski
be6e5d78cb
Additional logging to diagnose opening chat view from notification
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-03-01 13:19:14 +01:00
Andy Scherzinger
b750f41efd
kotlin code foermatting
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-03-01 10:21:09 +01:00
Andy Scherzinger
243e6161a6
Migrate AccountVerificationController to kotlin
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-02-28 18:25:53 +01:00
Andy Scherzinger
f76d25974e
migrate EntryMenuController to Kotlin
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-02-28 17:21:06 +01:00
Tim Krüger
45085b7e0b
Remove Parceler from model notifications
Resolves: #1548

Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-02-28 16:54:24 +01:00
Tim Krüger
d9587e9d18
Remove Parceler from model mention
Resolves: #1548

Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-02-28 16:54:24 +01:00
Tim Krüger
003d4c6af2
Remove unneeded not-null assertion operator (!!)
Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-02-28 16:54:23 +01:00
Tim Krüger
94f2339baa
Remove unneeded package definition
Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-02-28 16:54:23 +01:00
Tim Krüger
9f62df3a53
Suppress lint for unused result
Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-02-28 16:54:22 +01:00
Tim Krüger
dad4f56e6a
Remove Parceler from model hovercard
Resolves: #1548

Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-02-28 16:54:22 +01:00
Andy Scherzinger
18f180bfe7
rename UserItem to ContactsItem to reflect its use case
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-02-28 13:26:40 +01:00
Andy Scherzinger
da39d12a7f
remove unneeded null checks
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-02-28 13:23:35 +01:00
Andy Scherzinger
92a2c44415
remove unused classes
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-02-28 13:23:10 +01:00
Andy Scherzinger
76270077a1
migrate view items to native view bindings
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-02-28 09:52:49 +01:00
Andy Scherzinger
7374176083
remove unused getter
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-02-28 09:52:48 +01:00
Andy Scherzinger
f47690db22
use seperate xml designs for Items (+use viewbinding)
Resolves #1829

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-02-28 09:52:45 +01:00
Marcel Hibbe
9d29cbf9cd
fix vertical alignments for UserItem
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:28:33 +01:00
Andy Scherzinger
5c86629b53
fix license header mail format
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-02-25 12:25:52 +01:00
Andy Scherzinger
a3e86d841f
correct enum comparisons and add constants for fixed values
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-02-25 12:23:56 +01:00
Marcel Hibbe
0dc42a1b1e
fix NPE if status is null
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:11:46 +01:00
Andy Scherzinger
7ce1b9e916
adapt license header to app
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-02-25 12:11:46 +01:00
Andy Scherzinger
0677607dc4
migrate FlexibleItems to native view bindings
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-02-25 12:11:46 +01:00
Marcel Hibbe
d4f9f996c3
fix vertical alignment for MentionAutocompleteItem's
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:11:46 +01:00
Marcel Hibbe
ec438b0a9d
add rounded colors to online status buttons
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:11:45 +01:00
Marcel Hibbe
4984ba4dde
avoid linebreaks for "clear at" calculation
because:
- can lead to wrong calculations!

- avoid klint complaining about indentation

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:11:45 +01:00
Marcel Hibbe
b7b92eb623
fix textcolor for highlighted online status button
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:11:45 +01:00
Marcel Hibbe
305ceedc75
align username etc vertical if no status message is set
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:11:44 +01:00
Marcel Hibbe
c746b95ac2
add author to license headers
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:11:44 +01:00
Marcel Hibbe
a7792cb66e
fix lint and spotbugs warnings
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:11:44 +01:00
Marcel Hibbe
ce002318a2
fix NPE for contacts view
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:11:44 +01:00
Marcel Hibbe
fc8462e0a5
use StatusDrawable for conversationInfo and mention autocomplete
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:11:44 +01:00
Marcel Hibbe
1da8c3b206
modify StatusDrawable and use it for conversationList
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:11:43 +01:00
Marcel Hibbe
73ce2716de
fix klint warnings
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:11:43 +01:00
Marcel Hibbe
4f1a188a38
fix lint/spotbug warnings
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:11:43 +01:00
Marcel Hibbe
4c07ccec11
fix NPE when opening Contacts view.
because UserItem is used for ContactsController and ConversationInfoController it differs between two different xml designs in method getLayoutRes()
because of this there need to be checks which xml element exists or not. These are added with this commit.

In the long term UserItem should not use two different xml designs. This might also be a problem for view binding?!

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:11:43 +01:00
Marcel Hibbe
7820bc7c51
hide status of "Talk updates" conversation
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:11:43 +01:00
Marcel Hibbe
452baf4550
improve autocomplete mentions UI
add status message and emoji
match parent
improve design
use rv_item_mention_conversation_info_participant instead of rv_item_mention.xml

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:11:42 +01:00
Marcel Hibbe
0078778c99
show status for autocomplete mentions
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:11:42 +01:00
Marcel Hibbe
6a9dea7522
fix autocomplete mentions
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:11:42 +01:00
Marcel Hibbe
e3fd9a7592
fix onlinestatus color for night mode
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:11:41 +01:00
Marcel Hibbe
ffbe39bd01
change UserStatusCapability to kotlin data class
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:11:41 +01:00
Marcel Hibbe
21af8381b0
hide secondary text for normal users
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:11:41 +01:00
Marcel Hibbe
22c770fa8a
set "away" / "dnd" as status message if it's empty
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:11:41 +01:00
Marcel Hibbe
176568b628
show online status AND emoji in conversations info
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:11:40 +01:00
Marcel Hibbe
d453773a1d
show user statuses in conversation info (wip)
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:11:40 +01:00
Marcel Hibbe
6057306ab3
show user statuses in conversation list
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:11:40 +01:00
Marcel Hibbe
e27ede75ff
tidy up
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:11:40 +01:00
Marcel Hibbe
546f3fe1f2
fix to be able to set only "icon" / only "clear at" for status
api seems to set single modification for icon or "clear at" only if status message is not empty (must be at least whitespace)

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:11:40 +01:00
Marcel Hibbe
bce0d276f3
fix to be able to modify status message after predefined status was selected
so api to set a predefined status is not used at all..

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:11:40 +01:00
Marcel Hibbe
ea634ff43c
delete comments
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:11:39 +01:00
Marcel Hibbe
45cfbc7257
add ability to set status type
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:11:39 +01:00
Marcel Hibbe
19060bddbd
delete comments
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:11:39 +01:00
Marcel Hibbe
622eaa1d7f
check capabilities to set status support
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:11:39 +01:00
Marcel Hibbe
dad53a77e6
fix wrong calculation for "in 4h" (=remove linebreak)
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:11:38 +01:00
Marcel Hibbe
967b63b017
draw status in ChooseAccountDialogFragment
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:11:38 +01:00
Marcel Hibbe
7cc8751a1f
disable set status button until status is received
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:11:38 +01:00
Marcel Hibbe
df5ac64712
fix to clear the status
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:11:37 +01:00
Marcel Hibbe
454c6cd8e6
add ability to send predefined and custom status
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:11:37 +01:00
Marcel Hibbe
8117c775a7
notifyDataSetChanged after predefines statuses were loaded
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:11:37 +01:00
Marcel Hibbe
57a408ac97
add predefined statuses
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:11:37 +01:00
Tim Krüger
a94f0f1bf1
Adopt more parts from files app [WIP]
Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-02-25 12:11:36 +01:00
Marcel Hibbe
05586ccf47
add user status option to account dialog (WIP)
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-25 12:11:36 +01:00
Tim Krüger
3d76ba3571
Close localStream after peerConnection
The peerConnection get passed the tracks of the localStream. So to make
sure that the tracks are not released before the connection is closed it
will now done after closing the peerConnection.

Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-02-23 12:34:04 +01:00
Tim Krüger
f08a9ef463
Rename MagicPeerConnectionWrapper to PeerConnectionWrapper
Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-02-23 12:21:41 +01:00
Tim Krüger
0ea29ee0cd
Remove unused fields remoteVideoOn and remoteAudioOn
Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-02-23 12:21:41 +01:00
Tim Krüger
844cf09a2b
Rename remoteMediaStream to remoteStream
Align naming to the names used in WebRTC example code and documentation.

Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-02-23 11:36:42 +01:00
Tim Krüger
5580c15ea6
Rename magicDataChannel to dataChannel
There is no 🧙 in a data channel.

Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-02-23 11:36:42 +01:00
Tim Krüger
272ea7e846
Rename sdpConstraints to mediaConstraints
SDP is a native detail of the native WebRTC library.

Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-02-23 11:36:42 +01:00
Tim Krüger
890dda0c68
Remove unused method 'restartIce'
The method 'restartIce' is dead code since years. So this and related
fields are removed.

Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-02-23 11:36:42 +01:00
Tim Krüger
557602d1bf
Make fields final
Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-02-23 11:36:42 +01:00
Tim Krüger
5e778c94fb
Make use of Objects#requireNonNull to check for null references
Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-02-23 11:36:41 +01:00
Tim Krüger
5b95b5675d
Rename localMediaStream to localStream
Align naming to the names used in WebRTC example code and documentation.

Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-02-23 11:36:41 +01:00
Tim Krüger
86f20dcfd3
Migrate WebRTC from plan b to unified plan
The in 'MagicPeerConnectionWrapper#removePeerConnection' used method
'PeerConnection#removeStream' was not longer available in the unified
plan. So to make sure that the local stream is disposed, it will now be
done in 'CallActivity#hangup'.

Resolves: #1773
See: [1]

[1] https://webrtc.org/getting-started/unified-plan-transition-guide
Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-02-23 11:36:41 +01:00
Tim Krüger
bad5b5f9bc
Update WebRTC library
The  updated libwebrtc will be load from the talk-clients-webrtc repository [1]
and not from a dependency repository. The 'lint' task must now depend on the
'perBuild' task to make sure that the WebRTC library is downloaded from the
configured URL.

To get the new version to work a change is needed because of this announcement:

> Google is planning to transition Chrome’s WebRTC implementation from the
> current SDP format (called “Plan B”) to a standards conformant format
> (“Unified Plan”, draft-ietf-rtcweb-jsep) over the next couple of quarters.
>
> - [2]

Currently we are in phase 4 of the transition [3]. So actually 'Plan B'
must be used to avoid bigger changes to our code base at this time. But
'Plan B' is depracted and will be removed in phase 5 of the transition
[4].

Resolves: #1773
See:
  - [1] https://github.com/nextcloud-releases/talk-clients-webrtc
  - [2] https://webrtc.org/getting-started/unified-plan-transition-guide
  - [3] https://webrtc.org/getting-started/unified-plan-transition-guide#phase_4_make_%E2%80%9Cplan_b%E2%80%9D_throw
  - [4] https://webrtc.org/getting-started/unified-plan-transition-guide#phase_5_remove_%E2%80%9Cplan_b%E2%80%9D

Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-02-23 11:34:30 +01:00
Tim Krüger
964367189f
Fix klint errors
Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-02-21 17:17:47 +01:00
Tim Krüger
e49d014ec9
Remove Parceler from model capabilities
Resolves: #1548

Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-02-17 22:36:27 +01:00
Tim Krüger
dcc0a0fdd0
Remove Parceler from model autocomplete
Resolves: #1548

Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-02-17 22:36:26 +01:00
Andy Scherzinger
b745e0677b
reformat kotlin
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-02-17 17:29:12 +01:00
Andy Scherzinger
7b64fbd7e0
spotbugs: checks the size of a collection against zero rather than using isEmpty()
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-02-17 17:23:46 +01:00
Andy Scherzinger
a18987dc0a
also show server address and placeholder avatar for account import
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-02-17 17:21:48 +01:00
Andy Scherzinger
43f57931fd
add empty lines for formatting
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-02-17 15:25:24 +01:00
Andy Scherzinger
ef4b08d752
convert switch account controller to kotlin
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-02-17 15:25:24 +01:00
Andy Scherzinger
377a983ac8
convert server selection controller to kotlin
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-02-17 15:25:21 +01:00
Marcel Hibbe
e1f8c41b60
fix to mark conversation as read
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-16 11:45:58 +01:00
Marcel Hibbe
0f6efabf38
avoid wildcard imports
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-16 11:34:11 +01:00
Marcel Hibbe
30b34adaf6
make ConversationOperationEnum imports static
rename enums

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-16 11:34:11 +01:00
Marcel Hibbe
a22b93f363
fix to hide dialog automatically after 2,5 seconds
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-16 11:34:11 +01:00
Marcel Hibbe
73894bd4c0
fix to don't partly hide input dialogs behind keyboard
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-16 11:34:11 +01:00
Marcel Hibbe
2348919d97
modify copyright headers authors
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-16 11:34:10 +01:00
Marcel Hibbe
eceb545589
remove (hopefully unused) code regarding GUEST and USER_FOLLOWING_LINK
I can't reproduce or think of scenarios when this code was used. because bottom dialog is replaced it wouldn't work anymore anyway.
If there appear scenarios when the code would have executed, it should be fixed similar like ConversationsListBottomDialog was implemented.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-16 11:34:10 +01:00
Andy Scherzinger
142c362474
solve detekt issues
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-02-16 11:34:09 +01:00
Marcel Hibbe
809e277855
rename enum, add todo
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-16 11:34:09 +01:00
Marcel Hibbe
8ea9663d5e
fix to fetch conversations list after executing bottom sheet operations
BottomSheetLockEvent was only used for old bottom dialog with "kennyc" lib

instead ConversationsListFetchDataEvent.kt is now used to fetch the data in ConversationsListController whenever needed

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-16 11:34:09 +01:00
Marcel Hibbe
4728600021
fix to show searchbar after bottom dialog textinput
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-16 11:34:08 +01:00
Marcel Hibbe
6bc5d324b5
fix to show searchbar after bottom dialog operations
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-16 11:34:08 +01:00
Marcel Hibbe
4335e44701
replace operationCode's (int) by Enums
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-16 11:34:08 +01:00
Andy Scherzinger
66795bb48b
correct code formatting and license header added
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-02-16 11:34:07 +01:00
Andy Scherzinger
4fb61ed046
improve detekt score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-02-16 11:34:07 +01:00
Marcel Hibbe
ea7575b266
remove dependency com.github.Kennyc1012:BottomSheet
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-16 11:34:06 +01:00
Marcel Hibbe
ac0c961557
open Conversation after being created via ContactsController
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-16 11:34:06 +01:00
Marcel Hibbe
dbf6b91260
rename ConversationOperationDialog to ConversationsListBottomDialog
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-16 11:34:06 +01:00
Marcel Hibbe
9423376ca7
tidy up
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-16 11:34:06 +01:00
Marcel Hibbe
bec19428e0
share conversation link
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-16 11:34:05 +01:00
Marcel Hibbe
76451c1649
fix actions that are clicked in Conversation Bottom Dialog
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-16 11:34:05 +01:00
Marcel Hibbe
d76203a093
remove api v1 variants for conversations canLeave and canDelete methods
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-16 11:34:05 +01:00
Marcel Hibbe
aedede9ffd
proof of concept: use conductor with BottomSheetDialog
two approaches are added with this commit (just for testing):

1.for conversationOperationAddFavorite
- replace UI in ConversationOperationDialog
- push another controller via method in ConversationsListController (makes no sense here, but will be useful for other cases)

2. for conversationOperationRemoveFavorite
- hide UI
- introduce another conductor router for dialog
- push new Controller with new router
- fetchData in old controller

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-16 11:34:05 +01:00
Marcel Hibbe
cb9189da19
replace CallMenuController with ConversationOperationDialog.kt
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-16 11:34:04 +01:00
Marcel Hibbe
90a99d4994
fix design when keyboard is shown
- set windowSoftInputMode to adjustResize
- comment out everything related to KeyboardUtils

this fixes the design when keyboard is shown. At least this breaks the BottomSheet which will be hidden by the keyboard.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-16 11:34:04 +01:00
Andy Scherzinger
741b6fefc9
Adjust conversation list bottom sheet item to material 3
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-02-07 21:18:52 +01:00
Marcel Hibbe
7f0980e6d2
format code + fix klint/findbugs warnings
remove hardcodings

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>

remove hardcodings

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-07 14:27:38 +01:00
Marcel Hibbe
51df0e67f4
add UI logic for wired headset
if wired headset is plugged in hide earpiece and speaker icons

if wired headset is plugged out show earpiece and speaker icons

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-07 13:09:41 +01:00
Marcel Hibbe
a34eb89570
modify behaviour of proximity sensor
use proximity sensor only if it is a voiceOnly call and userSelectedAudioDevice was SPEAKER_PHONE

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-07 13:09:41 +01:00
Marcel Hibbe
338f06dda1
update UI if audio output device changed
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-07 13:09:40 +01:00
Marcel Hibbe
3587fe6e12
use speaker if no bluetooth is available
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-07 13:09:40 +01:00
Marcel Hibbe
510ec1598c
hide unavailable audio output channels
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-07 13:09:40 +01:00
Marcel Hibbe
ffb223a66f
highlight active audio output
use layout weight

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-07 13:09:40 +01:00
Marcel Hibbe
78b29082bf
show audio button also for videocalls
use layout weight

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-07 13:09:39 +01:00
Marcel Hibbe
9c0fa9acc2
select audio device (WIP)
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-07 13:09:39 +01:00
Marcel Hibbe
9b889d232f
add UI to switch audio output in call
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-02-07 13:09:39 +01:00
Marcel Hibbe
70b4eed654
delete deprecated CallItem + refactor related code
CallItem was only used before NC 14.
rv_item_conversation.xml was used by CallItem. After CallItem is now deleted, rv_item_conversation.xml was deleted from other xml classes as "tool"-view (this didn't make sense & was only a placeholder)
Furthermore, it was renamed to account_item.xml as now it is only used for account selection.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-01-26 17:25:22 +01:00
Marcel Hibbe
edc4091611
hide keyboard when scrolling in conversation search
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-01-26 17:22:21 +01:00
Marcel Hibbe
1de2261426
add open conversations to search
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-01-26 17:22:21 +01:00
Marcel Hibbe
9b55467af3
moved execution of setUpPushTokenRegistration
so token is registered everytime the conversation list is opened.

In NextcloudTalkApplication it was not  executed when app was still in background when opening

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-01-26 15:00:32 +01:00
Marcel Hibbe
f582525fef
remove logging
so the actions are not triggered when PeriodicWorkRequests are created.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-01-26 15:00:32 +01:00
Marcel Hibbe
c8274fe740
add string for origin to PushRegistrationWorker for debugging
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-01-26 15:00:31 +01:00
Marcel Hibbe
4629d02dc4
add copyright + minor refactoring
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-01-26 15:00:31 +01:00
Marcel Hibbe
06afd7bec6
set up periodic fetch of firebase token in ClosedInterface for gplay
move OneTimeWorkRequest for PushRegistrationWorker from NextcloudTalkApplication to ClosedInterface for gplay

add check in PushRegistrationWorker if google services are available

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-01-26 15:00:31 +01:00
Marcel Hibbe
aacd6d5377
also register push token again on server&proxy no matter if it didn't change on device
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-01-26 15:00:30 +01:00
Marcel Hibbe
b339aa9d33
refactor check if token should be registered
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-01-26 15:00:30 +01:00
Marcel Hibbe
1bd28f5ef4
add logging
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-01-26 15:00:30 +01:00
Marcel Hibbe
31f2f40bcf
refactor PushUtils
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-01-26 15:00:30 +01:00
Marcel Hibbe
412af46ed5
refactoring PushUtils
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-01-26 15:00:29 +01:00
Marcel Hibbe
a7c298b224
add log if push token is empty when registering at nc server
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-01-26 15:00:29 +01:00
Marcel Hibbe
bd4208f709
minor refactoring
- extract method to register device at proxy
- rename method
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-01-26 15:00:29 +01:00
Marcel Hibbe
54552cdd87 restrict to start a call when permission is missing
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-01-12 12:29:06 +00:00
Marcel Hibbe
65e002fe98 render system message "call_ended_everyone"
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-01-12 12:29:06 +00:00
Marcel Hibbe
5272d35f01 fix to stop audio manager in ui thread
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-01-12 12:29:06 +00:00
Marcel Hibbe
d17a8e9dbd ad some logging
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-01-12 12:29:06 +00:00
Marcel Hibbe
175f479d0f replace check for boolean variant of inCallFlag
(boolean variant is deprecated since nc14)

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-01-12 12:29:06 +00:00
Marcel Hibbe
76aaafb024 replace deprecated ParticipantFlags with InCallFlags
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-01-12 12:29:06 +00:00
Marcel Hibbe
f70f94e6be hangup when currentSession has inCall flag = 0
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-01-12 12:29:06 +00:00
Marcel Hibbe
b3b8c867f7 fix typo
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-01-12 12:29:06 +00:00
Andy Scherzinger
16246e9fe2
only show mark as unread in debug mode
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-01-11 14:53:48 +01:00
Dariusz Olszewski
c99da0282d
Null ringtone Uri must be allowed
App would crash on pre-Oreo devices with "No sound" setting

Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-01-05 11:03:59 +01:00
Dariusz Olszewski
d99295118b
SpotBugs
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-01-05 11:03:59 +01:00
Dariusz Olszewski
648b9cbb82
Remove unused notification channels during upgrade
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-01-05 11:03:58 +01:00
Andy Scherzinger
12e1d9b7de
use existing constant
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-01-05 10:28:07 +01:00
Andy Scherzinger
10f2c3be3a
make unread work for chat messages based on adapter data
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-01-05 10:28:07 +01:00
Andy Scherzinger
58c0106ec7
calculate previous message id when possible
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-01-05 10:28:07 +01:00
Andy Scherzinger
de085df3bc
add proper API version detection
don't let switch fall through
make api versions constants

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-01-05 10:28:07 +01:00
Andy Scherzinger
1521e13e21
mark message as unread / conversation as read
Resolves #1464

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-01-05 10:28:06 +01:00
Dariusz Olszewski
996c4c5280
ktlint... :-|
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-01-04 15:38:25 +01:00
Dariusz Olszewski
385edf35a2
Image keyboard support in chat
Receive images (usually GIFs) from keyboard and upload them to the current chat.

Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-01-04 15:38:24 +01:00
Tim Krüger
c26d6afddb
Remove implied default locale in case conversion
Signed-off-by: Tim Krüger <t@timkrueger.me>
2021-12-21 12:03:57 +01:00
Marcel Hibbe
fef9c24232
minor refactoring in NotificationUtils
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-12-15 15:54:20 +01:00
Dariusz Olszewski
09879ff347
Proposed UI changes of notification settings
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2021-12-14 22:05:48 +01:00
Dariusz Olszewski
39f69003b5
Safer to use NotificationManagerCompat rather than NotificationManager
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2021-12-14 22:05:48 +01:00
Dariusz Olszewski
2f4aa35c53
Register notification channels on app start-up (Oreo or later)
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2021-12-14 22:05:48 +01:00
Dariusz Olszewski
2e4130c2c4
Fix (some) ktlint issues
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2021-12-14 22:05:48 +01:00
Dariusz Olszewski
e9ac99c5df
Notification settings UI on Oreo or later
* On devices with Android 8.0 (Oreo) or later, use system UI to change notification settings.
* Refactor sound selection code to cover differences between old (pre Oreo) and new devices.
* Always use the same notification channel for calls (Oreo or later).

Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2021-12-14 22:05:48 +01:00
Dariusz Olszewski
4a5f6cf1fe
Do not play notification sounds on Oreo or later
On devices with Android 8.0 (Oreo) or later, notification sound will be handled by the system, if notifications have not been disabled by the user.

Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2021-12-14 22:05:47 +01:00
Tim Krüger
2bf470e0e6
Fix unread indirect mention bg color
The background color for the indirect unread mention counter was alwasys
white. Also in dark mode.

Now the background color is defined via the 'bg_default' color.

Signed-off-by: Tim Krüger <t@timkrueger.me>
2021-12-14 11:39:34 +01:00
tobiasKaminsky
5ad48b3757
initial idea to login in during tests
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-12-08 16:25:18 +01:00
Tim Krüger
eb1512b890
Show quotes of unnamed guests with "Guests"
Before this change the default "Guests" label only was set if the actor
display name was 'null'.

Resolves: #1730

Signed-off-by: Tim Krüger <t@timkrueger.me>
2021-12-03 11:30:16 +01:00
Tim Krüger
567326da5a
Resolve klint issues
Signed-off-by: Tim Krüger <t@timkrueger.me>
2021-12-02 12:54:26 +01:00
Marcel Hibbe
d377b6f136
fix klint
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-23 12:29:53 +01:00
Marcel Hibbe
5bb8de673e
hangup call notification screen after 1 minute
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-23 11:27:50 +01:00
Marcel Hibbe
8381e0b541
add logging for calls
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-22 22:41:17 +01:00
Andy Scherzinger
47aa8ea5d4 make all cam buttons reflect current state instead of triggered action
Resolves #1694

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-18 12:49:14 +00:00
Andy Scherzinger
514a2f0cc6
Merge pull request #1699 from nextcloud/deleteLeaveRoom
delete unused method leaveRoom
2021-11-17 15:02:38 +01:00
Marcel Hibbe
4167cb63bf
share contact from attachment dialog
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-17 12:12:05 +01:00
Marcel Hibbe
477100ccd8
delete unused method leaveRoom
delete redundant if-check

cleanup of commit ca9a622030

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-16 19:53:45 +01:00
Marcel Hibbe
41ff61be5f
set pipGroupCallOverlay to gone when not needed
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-16 16:19:18 +01:00
Marcel Hibbe
9499b8117b
fix that call controls appear on touch when connecting
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-16 16:19:17 +01:00
Marcel Hibbe
e2668c4000
delete zlevel of call controls (not needed)
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-16 16:19:17 +01:00
Marcel Hibbe
48cda08854
delete if-checks for view bindings
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-16 16:19:17 +01:00
Marcel Hibbe
f2e75a7b71
add workaround to start videocalls when PIP is disabled
this is a dirty workaround for issue #1677

Somehow onUserLeaveHint is executed when the user starts a videocall. If PIP is disabled, the logic inside enterPipMode would finish the activity right after it was started.
This workaround suppresses the execution of enterPipMode right after the activity was started.
However if a user would press the home button in the first three seconds, the call would continue in background without the ability to recover the UI.

To better fix this bug it must be found out why onUserLeaveHint is executed on start (this should not happen!).

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-15 12:19:40 +01:00
Andy Scherzinger
4671b18b91
Add license headers
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-12 09:45:49 +01:00
Andy Scherzinger
2eee665374
spotbugs: remove unused view variable
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:57 +01:00
Andy Scherzinger
0a3b23ba57
don't box primitives
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:56 +01:00
Andy Scherzinger
fd754f582b
migrate scope dialog to native view binding
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:55 +01:00
Andy Scherzinger
d995fc51ef
move attachment dialog to native view bindings
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:54 +01:00
Andy Scherzinger
d0f52c8eba
make sure to torn of torch after taking a picture
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:53 +01:00
Andy Scherzinger
dd9501590b
replace resolution and crop icons and preserve state in lifecycle
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:53 +01:00
Adam Serbinski
c3a37222b3
Crop and 2MP buttons to go away when reviewing
Signed-off-by: Adam Serbinski <adam@serbinski.com>
2021-11-11 22:10:52 +01:00
Adam Serbinski
7edd87fa4e
Add crop and low res (2MP) drawables
Signed-off-by: Adam Serbinski <adam@serbinski.com>
2021-11-11 22:10:52 +01:00
Adam Serbinski
13d376b25b
Add toggles for crop and lowres
Upper left -- crop
Upper right -- lowres (1920x?)

Signed-off-by: Adam Serbinski <adam@serbinski.com>
2021-11-11 22:10:51 +01:00
Adam Serbinski
d2d98314ee
Upload from camera: pinch to zoom, apect ratio
This implements pinch to zoom in the full range supported by the
camera HAL, fixes aspect ration handling on rotation, and sets up
for multiple resolution and aspect ratio support.

Signed-off-by: Adam Serbinski <adam@serbinski.com>
2021-11-11 22:10:51 +01:00
Andy Scherzinger
45402ea202
taost the right text
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:50 +01:00
Andy Scherzinger
ab4bba0f27
add cam permission check
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:50 +01:00
Andy Scherzinger
03cb3a66c6
move flash/flip-cam toggles
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:49 +01:00
Andy Scherzinger
bdc157d772
spotbugs: remove needlessly boxing a boolean constant
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:48 +01:00
Andy Scherzinger
14a3e488cc
limit image size for cam uploads to FHD
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:47 +01:00
Andy Scherzinger
7e688c43af
update cam libs to sdk=30 versions, improve previews and removal of temp images in case of cancellations
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:47 +01:00
Andy Scherzinger
67c421a067
add retake, send actions and preview
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:46 +01:00
Andy Scherzinger
547e9ebf8b
improve camera layout
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:46 +01:00
Andy Scherzinger
56d57c0b37
improve code check score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:45 +01:00
Andy Scherzinger
4041d3f09b
use context compat to load resources
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:45 +01:00
Andy Scherzinger
0b8add1f69
Adding upload from camera action
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Co-Authored-by: Stefan Niedermann <info@niedermann.it>
2021-11-11 22:10:41 +01:00
Marcel Hibbe
14abe52b6a
rename CallActivityBase to CallBaseActivity
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:52:18 +01:00
Marcel Hibbe
36c5f0814b
remove avatar blurring for background (=fix blocking of call controls)
no blurring or other background color calculation is done any more. BlurPostProcessor took too long for the used image size. If this is a requirement in the future, use ScalingBlurPostprocessor instead of  BlurPostprocessor (so fresco lib fork from nextcloud has to be updated!), see https://frescolib.org/docs/modifying-image.html

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:52:18 +01:00
Marcel Hibbe
9070153d5c
create abstract class for CallActivity and CallNotificationActivity
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:52:18 +01:00
Marcel Hibbe
be9971ad7a
disable back button when pip is not available
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:52:18 +01:00
Marcel Hibbe
e6da2fcc19
replace hardcoded applicationId for pip permission check
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:52:18 +01:00
Marcel Hibbe
89d0bcfc78
hide navigation bar if pip is not available
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:52:18 +01:00
Marcel Hibbe
f5106e6050
check if pip mode is granted on device, otherwise hide button
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:52:18 +01:00
Marcel Hibbe
f9a28cb0aa
fix to hide selfVideo when pip-view is tapped
on some devices (reproduced with Pixel2 on api level30) the own video became visible when the pip view was tapped. This fix should hide the own video.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:52:18 +01:00
Marcel Hibbe
289bd2fa00
fix klint error
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
63593df03e
hide peer name when in pip mode
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
052dc588aa
remove comment
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
b822eb8417
reformat code in CallNotificationActivity
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
b3f8a36c62
load avatar again in CallNotificationActivity
was only disabled for debugging. still needs to be fixed with https://github.com/nextcloud/talk-android/issues/1234

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
7a7888f5d1
reformat code in CallActivity
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
71ae7eddc2
move code from onStart to onCreate
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
0bfeb1b320
add action button to mute/unmute in pip mode
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
4a1c637efc
add checks if pip is supported by device
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
a0c95113bf
display overlay instead of grid in pip view for group calls
this is a quick and dirty solution until "speaker view" is introduced in the future which should be used for the pip view.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
57804c8d62
dismiss keyguard for CallNotificationActivity (WIP, see TODO)
Whenever i click the button to accept the call, CallActivity is started by intent.
CallActivity itself has the same logic to dismiss the keyguard.

The problem is: When switching from CallNotificationActivity to CallActivity the lockscreen is shown indeed!
So i guess Android recognizes "oh, CallNotificationActivity is gone. Let's show the lockscreen" before it recognizes that
the new activity also dismiss the lockscreen ?!

I fear for this scenario it was not the best idea to have 2 different activies.. (before it was only 1 activity and 2 condcutor controllers..)

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
e05334cb9a
enable pip support for CallNotificationActivity
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
7e68ecbde9
rename "runAllThings"
:D :D
setUpAfterConversationIsKnown might not be the best name, but i'm not sure when in onCreate the currentConversation can be null. depending on that it might even not be necessary to have the "things" in a method..

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
3326b6a7f3
rename design for CallActivity
move methods

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
c7e38e4859
replace CallNotificationController with Activity (WIP)
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
251d41f7fb
replace CallController with CallActivity etc. (WIP)
- delete MagicCallActivity
- replace butterknife with viewbinding for CallActivity

TODO:
- also switch CallNotificationController to Activity
- check if CallActivity and CallNotificationActivity are called correctly
- testing!

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
b49a1b9274
remove unused import
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
3afcceae50
delete creation of intent that is not used
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
03913b40a2
fix to enable pip for CallNotification Controller
methods to update UI are not yet implemented. maybe it's better to make two Activities: one for Call and one for CallNotification...

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
0d1e0af9d1
fix NPE when call is joined by notification
add ability to have PIP mode for calls joined by notification

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
51b86b5a88
fix currentRoomToken for ApplicationWideCurrentRoomHolder
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
e0e3bf4c32
add logging and comments
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
2c1b45491d
start pip mode when back button is pressed
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
78653e7d8d
show call controls in videocall when entering call or when come back from pip mode
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
12d96634e5
fix to show call controls in voiceOnly call after coming back from pip mode
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
1ae5f51a81
hide pip button for android < 8
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
6839b9eb2c
fix animation of callControls
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
3ba599be98
rename old "pip*"-stuff to "selfVideo*"
improve design-logic for pip-mode and normal mode when switched back from pip

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
914b10bf20
make pip fullscreen (wip)
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
d482d8603e
modify call screen design for pip mode
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
ea8e45e934
enable keyguard when users presses home button
= security check if call was entered via notification in locked mode

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
0aee8eb7ef
remove comment
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
d4322bf2d9
finish call activity if closed via "X" in pip mode
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
d4d23c1855
set calling/dialing state by ApplicationWideCurrentRoomHolder
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
78384e7b55
add initial approach for pip mode (wip)
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
40506eaeaf
allow app to query for apps that can resolve VIEW or SEND intents
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 11:22:37 +01:00
Tim Krüger
85785c287e
Resolve FindBugs Collection Naming Confusion
From the FindBugs documentation:

> CNC_COLLECTION_NAMING_CONFUSION: Collection variable is named with a different
> type of collection in the name
>
> This class defines a field or local collection variable with a name that
> contains a different type of collection in its name. An example would be a Set
> called userList. This is confusing to the reader, and likely caused by a
> previous refactor of type, without changing the name. This detector is
> obviously only checking for English names.

Signed-off-by: Tim Krüger <t@timkrueger.me>
2021-11-10 13:55:20 +01:00
Tim Krüger
9accac3325
Show profile action on avatar click
For every click on a avatar in a group chat it will be tried to receive a
hover card from the Nextcloud server. The endpoint returns multiple
actions. Those actions will be filtered for the app ids 'spreed',
'email' and 'profile'. Other will be ignored.
The received filtered actions will be shown in a bottom sheet.

Resolves: #1644

Signed-off-by: Tim Krüger <t@timkrueger.me>
2021-11-10 09:08:43 +01:00
Tim Krüger
036cf7c590
Some refactoring
- Removed spelling issues
- Removed unneded boolean comparisons
- Improve code readability by reformatting

Signed-off-by: Tim Krüger <t@timkrueger.me>
2021-11-10 09:08:42 +01:00
Andy Scherzinger
a8c8fbe191
reformat code
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-06 12:23:37 +01:00
Andy Scherzinger
61e0c88188
improve code scores
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-06 12:15:23 +01:00
Andy Scherzinger
ed7a762b4c
correct formatting for ktlint
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-05 18:18:21 +01:00
Andy Scherzinger
e8930530de
rename method since vibrator implementation has been removed
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-10-26 12:15:30 +02:00
Andy Scherzinger
67df1fb341
cleanup code after custom vibrate code removal
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-10-26 12:15:30 +02:00
Andy Scherzinger
a5b1c1a34d
improve lint score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-10-25 15:18:44 +02:00
Andy Scherzinger
8c87c5b45d
remove unused vibrate code
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-10-25 14:31:48 +02:00
Andy Scherzinger
eb3c742f65
remove vibrate setting
Resolves #1630

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-10-25 14:31:44 +02:00
Tim Krüger
7f54dcd9f9
Replace 'mute calls' by 'call notifications'
The 'mute calls' setting was only stored locally on the device. The new
'call notifications' setting is stored on the Nextcloud server and
shared over all devices.

See:
  - https://github.com/nextcloud/spreed/pull/6338

Signed-off-by: Tim Krüger <t@timkrueger.me>
2021-10-25 11:43:32 +02:00
Tim Krüger
1e5ba5a94b
Remove restricted API access
The access to function 'MaterialDialog#getItemSelector' is restricted.
Because of that the linting reported some errors.

I could not find any visible benefit in this call. That is why I have
removed it.

Signed-off-by: Tim Krüger <t@timkrueger.me>
2021-10-19 14:05:32 +02:00
Tim Krüger
249e1a2a9a
Remove unnecessary type casts
Signed-off-by: Tim Krüger <t@timkrueger.me>
2021-10-15 11:51:30 +02:00
Marcel Hibbe
74e693d95c
scroll to first unread mention and place it to the top
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-10-04 18:09:29 +02:00
Tim Krüger
cf471e336f
Clear message field after sharing
After the Android sharing functionality was used, the shared text sticks
in the message composing field in the conversation. Also if an text was
forwared to the same conversation the text which was shared before
sticks in the message composing field.

Now the message composing field is empty after sharing or forwarding
something.

Signed-off-by: Tim Krüger <t@timkrueger.me>
2021-09-29 12:23:48 +02:00
Andy Scherzinger
638b7c8288
also account for unread 1on1 messages for unreadMessages bubbleClicked
Fixes #1599

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-09-23 17:17:54 +02:00
Marcel Hibbe
84468be617
catch NPE for popup bubble
catch NPE when popup bubble for unread mentions is not available anymore

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-09-23 10:55:31 +02:00
Marcel Hibbe
4a31a89e4a
set standard typeface for date of message
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-09-22 17:17:57 +02:00
Marcel Hibbe
a6397b0392
differentiate unread counters
differentiate unread counters for group mentions and direct mentions

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-09-22 16:30:14 +02:00
Tim Krueger
f96392d05c
Merge pull request #1589 from nextcloud/feature/1557/show-lobby-timer-and-description-in-lobby-screen
Show lobby timer and description in lobby screen
2021-09-20 17:06:42 +02:00
Tim Krüger
4e8c8eb8d7
Show relative timer on lobby screen
Resolves: #1557

Signed-off-by: Tim Krüger <t@timkrueger.me>
2021-09-20 15:26:54 +02:00
Marcel Hibbe
12e9985cd9
add unread mentions popup-bubble in conversations list
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-09-20 11:35:58 +02:00
Marcel Hibbe
69bcd6ee88
enable keyguard for toggle chat
show the lockscreen when switching to chat in a call that was opened by notification before the phone was unlocked.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-09-17 14:58:44 +02:00
Tim Krüger
08a5088c48
Add conversation description to lobby screen
Resolves: #1557

Signed-off-by: Tim Krüger <t@timkrueger.me>
2021-09-17 12:21:18 +02:00
Andy Scherzinger
2315701b3a
Merge pull request #1546 from nextcloud/sdk30
Bump to SDK 30
2021-09-16 15:20:13 +02:00
Tim Krüger
1a9f5a3f73
Make klint happy :-)
Signed-off-by: Tim Krüger <t@timkrueger.me>
2021-09-15 17:02:57 +02:00
Tim Krüger
e1d9afa1a2
Suppress Lint for wrong constant of AudioManager modes
Signed-off-by: Tim Krüger <t@timkrueger.me>
2021-09-15 16:17:32 +02:00
Tim Krüger
99f5a64c50
Suppress Lint for wrong constant of AudioManager.GET_DEVICES_ALL
Up to now AudioManager.GET_DEVICES_ALL is a valid value. Because of that
the suppress annotation were added.

See: https://developer.android.com/reference/android/media/AudioManager#getDevices(int)

Signed-off-by: Tim Krüger <t@timkrueger.me>
2021-09-15 15:47:46 +02:00
Tim Krüger
5cacf7767d
Ask for READ_EXTERNAL_STORAGE permsssion for API level 30
Since API level 30 the WRITE_EXTERNAL_STORAGE permission will be
ignored. Instead the READ_EXTERNAL_STORAGE permission must be used.

See: https://developer.android.com/training/data-storage

Signed-off-by: Tim Krüger <t@timkrueger.me>
2021-09-14 13:54:20 +02:00
Marcel Hibbe
2f35ae19fc
call adapter methods in UI thread
otherwise sometimes this exception was thrown:

IllegalStateException: Cannot call this method while RecyclerView is computing a layout or scrolling androidx.recyclerview.widget.RecyclerView
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-09-03 13:07:21 +02:00
Andy Scherzinger
7311971fe1
properly theme the loading spinner
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-09-03 12:58:46 +02:00
Andy Scherzinger
fab51901f2
utilize Fragment key
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-09-03 12:58:46 +02:00
Andy Scherzinger
fbc853fa63
typo fixed
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-09-03 12:58:46 +02:00
Andy Scherzinger
04a7f75f78
adapt to rebase by remove the migrated fastscroller code
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-09-03 12:58:46 +02:00
Andy Scherzinger
1b29038dbd
move refresh action to swipe action
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-09-03 12:58:46 +02:00
Andy Scherzinger
d785d3aa21
properly sort by name
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-09-03 12:58:46 +02:00
Andy Scherzinger
85b2cea618
Add order capabilities to file browser
Resolves #919

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-09-03 12:58:46 +02:00
Tim Krüger
fe989371de
Fix scrolling and selection issue in RTL
The following views had scrolling and selection issues if RTL is
activated:

- Conversation list
- File browser
- Contact selection

To fix this issues the fast scroller functionality were removed for
those views.

Signed-off-by: Tim Krüger <t@timkrueger.me>
2021-09-02 14:01:17 +02:00
Tim Krüger
730c85811e
Hide own conversation in "forward to" selection screen
Resolves #1567

Signed-off-by: Tim Krüger <t@timkrueger.me>
2021-09-02 11:57:27 +02:00
tobiasKaminsky
8c7b7154a6
Bump to SDK 30
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-08-26 12:26:46 +02:00
Andy Scherzinger
febaaf8ea7
Revert "improve code check score"
This reverts commit 6415f163bd.

Revert "use context compat to load resources"

This reverts commit 3742c4ed99.

Revert "Adding upload from camera action"

This reverts commit 01a6675795.
2021-08-23 08:54:33 +02:00
Andy Scherzinger
6415f163bd
improve code check score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-08-21 18:28:55 +02:00
Andy Scherzinger
3742c4ed99
use context compat to load resources
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-08-21 13:48:30 +02:00
Andy Scherzinger
01a6675795
Adding upload from camera action
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Co-Authored-by: Stefan Niedermann <info@niedermann.it>
2021-08-21 13:40:18 +02:00
Marcel Hibbe
dd5d347a7b
expand privacy settings bottom sheet in landscape mode
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-08-19 12:00:28 +02:00
Marcel Hibbe
402325ffb5
fix displaying of message delete-button
this will fix to hide the delete-button when the message is not from the current user and the user not a moderator.
see https://nextcloud-talk.readthedocs.io/en/latest/chat/#deleting-a-chat-message

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-08-12 18:03:50 +02:00
Andy Scherzinger
fd430b9084
use proper context
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-07-22 22:58:22 +02:00
Andy Scherzinger
ed19792204
extract bundle keys
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-07-22 22:39:31 +02:00
Tim Krüger
af31d8a703
Make klint happy
Signed-off-by: Tim Krüger <t@timkrueger.me>
2021-07-22 22:14:37 +02:00
Tim Krüger
00915e56ff
Allow only forwarding of regualr text messages
Also go back directly to the conversation list. Go back history is
reseted.

Signed-off-by: Tim Krüger <t@timkrueger.me>
2021-07-22 22:14:36 +02:00
Tim Krüger
d67226e39d
Forwarding message to selected conversation
Signed-off-by: Tim Krüger <t@timkrueger.me>
2021-07-22 22:14:26 +02:00
Tim Krüger
6f2c0c65df
Unify strings for clearing chat over all platforms
See: #1336

Signed-off-by: Tim Krüger <t@timkrueger.me>
2021-07-22 11:41:00 +02:00
Andy Scherzinger
7d35e91a9c
remove unneeded annotation
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-07-19 13:59:01 +02:00
Marcel Hibbe
a41c0f8b69
add confirm dialog before clearing chat history
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-07-19 13:51:38 +02:00
Marcel Hibbe
1558c8ed33
add ability to clear chat history
- moderators can clear the chat in the conversations settings
- chat is cleared by system message CLEARED_CHAT

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-07-19 13:51:37 +02:00
Marcel Hibbe
f813688a12
remove hardcoded api version for location sharing
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-07-15 19:16:50 +02:00
Tim Krueger
0799945016
Merge pull request #1472 from nextcloud/remove-obsolete-setting-link-preview
Remove obsolete setting link preview
2021-07-15 16:14:50 +02:00
Tim Krüger
19337b8e57
Remove preference 'link_previews' from storage
Signed-off-by: Tim Krüger <t@timkrueger.me>
2021-07-15 14:20:16 +02:00
Tim Krüger
eac46d9456
Remove obsolete setting link preview
The setting is obsolete since the functionality for media detection in
text messages was removed.

See: commit 8468535a

Signed-off-by: Tim Krüger <t@timkrueger.me>
2021-07-15 10:07:43 +02:00
Tim Krüger
62f73aee05
Remove unused method and dependency
See: commit 4c4c5839, #1167

Signed-off-by: Tim Krüger <t@timkrueger.me>
2021-07-15 10:07:42 +02:00
Tim Krüger
75d82185c1
Remove media in text message detection
The method 'TextMatchers#getMessageTypeFromString' suggested MIME types
for linked files in text message. Also for links like this not working
example:

  - http://example.local/image.png
  - image.png

In those cases no image can be loaded and that results in empty previews
like shown in the issue #1167.

So for alignment reasons to spreed and Talk iOS app this media detection
is removed and only links will be shown.

Resolves: #1167

Signed-off-by: Tim Krüger <t@timkrueger.me>
2021-07-15 10:07:42 +02:00
Tim Krüger
11805e5c7a
Add new system message types
The new system message types 'call_missed' and 'call_tried' should be
shown as system messages and not regular text messages.

Resolves: #248

Signed-off-by: Tim Krüger <t@timkrueger.me>
2021-07-14 16:50:16 +02:00
Tim Krüger
8468535a1e
Remove unused method and dependency
See: commit 4c4c5839, #1167

Signed-off-by: Tim Krüger <t@timkrueger.me>
2021-07-14 10:17:05 +02:00
Tim Krüger
4c4c583923
Remove media in text message detection
The method 'TextMatchers#getMessageTypeFromString' suggested MIME types
for linked files in text message. Also for links like this not working
example:

  - http://example.local/image.png
  - image.png

In those cases no image can be loaded and that results in empty previews
like shown in the issue #1167.

So for alignment reasons to spreed and Talk iOS app this media detection
is removed and only links will be shown.

Resolves: #1167

Signed-off-by: Tim Krüger <t@timkrueger.me>
2021-07-14 09:26:17 +02:00
Andy Scherzinger
0ec4ecfa95 base url can be null
Fixes #1458

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-07-12 11:20:53 +00:00
Andy Scherzinger
73e96198de Handle async call back to already destroyed UI
Fixes #1426

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-07-12 10:55:03 +00:00
Dariusz Olszewski
d0e5b768bb Share from a browser should share the page URL
Fixes #1415

Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2021-07-10 23:09:51 +02:00
Marcel Hibbe
27bbb399be catch FileNotFoundException in copyFileToCache
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-07-09 18:35:47 +00:00
Joas Schilling
976ca95959
Merge pull request #1442 from nextcloud/bugfix/1429/fix-capability-check-for-14-to-18
Fix capability check for 14-18
2021-07-09 20:24:07 +02:00
Joas Schilling
4f94d7f96c
Fix capability check for 14-18
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-07-09 19:45:05 +02:00
Andy Scherzinger
f8ae4ca8a3
Merge pull request #1420 from nextcloud/bugfix/1417/botSystemConversationIcon
Use launcher icon as bot-avatar/system-conversation-icon
2021-07-09 16:28:33 +02:00
Andy Scherzinger
1333ce768a
Merge pull request #1425 from nextcloud/bugfix/1424/conversationInfoViewBindingNPE
Binding can be null due to async call
2021-07-09 11:30:18 +02:00
Andy Scherzinger
c47a686db1
replace printStackTrace with Log-statement
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-07-09 10:54:39 +02:00
Andy Scherzinger
324cd95f43
binding can be null do to async call
Fixes #1424

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-07-08 23:58:34 +02:00
Andy Scherzinger
e1962883b0
Only parse baseURl if not empty
Fixes #1422

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-07-08 14:49:59 +02:00
Andy Scherzinger
5e88dc6f57
Use launcher icon as bot-avatar/system-conversation-icon on pre-Android O
Fixes #1417

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-07-08 14:31:12 +02:00
Marcel Hibbe
e721aa5df6
fix to expand attachment menu in landscape mode
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-07-05 14:57:11 +02:00
Marcel Hibbe
83001990b0
set locationName to "Shared location" when geocoding failed
e.g. when someone shares a location from the ocean the name is not "null" anymore

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-07-05 13:03:18 +02:00
Daniel Calviño Sánchez
6087167d6e
Simplify condition
Now that "newSessions" only contains remote participants it is no longer
needed to check if the participant is an MCU publisher or not, as it
will never be.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-07-02 14:59:05 +02:00
Daniel Calviño Sánchez
9687a9453d
Fix treating the local session as a remote session when the HPB is used
When processing the participants in a room the signaling sessions of the
participants were compared against the Nextcloud session of the local
participant to find out which were the remote sessions. However, when
the HPB is used the signaling session is not the same as the Nextcloud
session, so the signaling session of the local participant never matched
her Nextcloud session, so it was always seen as a remote participant.

This caused the call state to be changed to "in conversation" (which,
for example, stopped the calling sound), when only the local participant
was in the call.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-07-02 14:59:05 +02:00
Daniel Calviño Sánchez
004c7b296a
Move "hasMCU" update to the top of the method
"hasMCU" was used before being updated, so this caused an unneeded call
to "getPeersForCall" when processing the users in the room for the first
time even if the MCU is actually used.

A better fix might be moving "hasMCU" to a method instead of relying on
the cached value, but just moving the update to the top of the method
should have no side effects (as calling "getPeersForCall" just updates
"participantMap", which is unused when the MCU is used, and sets the
avatars, which has no effect until the peer layout is set, which also
sets the avatar), so this is good enough for now.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-07-02 14:59:05 +02:00
Marcel Hibbe
c07ef4acc8
define call controls height in dimens.xml
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-07-02 13:23:46 +02:00
Marcel Hibbe
99b247850b
set minHeight for call item by dp
reduce number of possible columns to avoid design issues

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-07-02 13:23:46 +02:00
Marcel Hibbe
8e8fd882f9
return false for ridView.setOnTouchListener
NOT TESTED

should allow both click and scrolling?

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-07-02 13:23:46 +02:00
Marcel Hibbe
98f8a29eae
set constants for min item height and call controls height
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-07-02 13:23:46 +02:00
Marcel Hibbe
64d98aefb4
- set bottom margin for grid for voicecall
- temporarily comment out setOnTouchListener for grid (disables toggle of controls for now)
- set android:scrollbars="vertical" for gridview
- add callControlsHeight for item height calculation
- add fake height to item that scrolling is testable

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-07-02 13:23:46 +02:00
Andy Scherzinger
394a640555
shorten app label Nextcloud Talk -> Talk while keeping "Nextcloud Talk" as a label within the app itself
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 18:07:54 +02:00
Andy Scherzinger
996770e470
check if view is (still) available
...since grid initialization is called in various places throughout the lifecycle

Fixes #1233

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 16:54:57 +02:00
Andy Scherzinger
60def3cc0c
optimize message input for size+a11y
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 15:53:30 +02:00
Marcel Hibbe
bebf716da7
temporarily disable logging to file
see issue
https://github.com/nextcloud/talk-android/issues/1376

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-30 14:24:53 +02:00
Andy Scherzinger
b989c62055
Merge pull request #1373 from nextcloud/bugfix/1343/stopVoiceMessage
Bugfix/1343/stop voice message
2021-06-30 13:53:13 +02:00
Andy Scherzinger
60d14f3b35
SuppressLint("SetTextI18n")
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 13:44:00 +02:00
Andy Scherzinger
d37783d7a0
fix ktlint
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 13:38:48 +02:00
Andy Scherzinger
3e57018615
remove unused member variables
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 13:12:15 +02:00
Andy Scherzinger
195bdfb05a
extract visibility toggle for play/pause Vs. loading-animation
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 13:03:17 +02:00
Andy Scherzinger
78cc0df7bd
spotbugs: use literal as comparison base
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 13:03:14 +02:00
Andy Scherzinger
7bca54373f
Improve ktlint
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 13:02:57 +02:00
Andy Scherzinger
a393685a63
else/if rather than if/if
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 13:01:32 +02:00
Andy Scherzinger
5b457a67cb
remove unused member variable
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 13:01:31 +02:00
Andy Scherzinger
f435646b23
Add license header 2021-06-30 13:01:26 +02:00
Marcel Hibbe
6fc83bbca0
fix klint warnings
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-29 23:09:39 +02:00
Marcel Hibbe
741748137a
fix lint/spotbugs warnings
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-29 22:49:33 +02:00
Marcel Hibbe
c7bb6402fe
stop mediaPlayer in onDestroy
a voice message now continues to play if app goes to background, but whenever the user returns he can pause or stop the playback (UI is updated).
Also, the playback survives a screen orientation change.

instead stopping the mediaPlayer in onDetach would stop playback when moving app to background but also stop the playback on a screen orientation change.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-29 22:49:33 +02:00
Marcel Hibbe
d47deb42c8
move mediaPlayer and download-logic for voicemessages to ChatController
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-29 22:49:33 +02:00
Andy Scherzinger
3514d6b3fc
Catch IllegalStateException in case EmojiCompat hasn't been initialized yet
Fixes #1371

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-29 13:00:32 +02:00
Andy Scherzinger
c4057b7ac4
Add dark/light aware high-res conversation icons for share:password and document
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-28 23:09:18 +02:00
Andy Scherzinger
0b49b65094
check if attendeePin exists
resolves #1314

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-24 16:27:51 +02:00
Joas Schilling
9411614175
Show the bridge-bot avatar for bridged messages
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-06-23 10:13:20 +02:00
Joas Schilling
c2125f9a81
Always fallback to the guest avatar instead of none
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-06-23 10:12:58 +02:00
Joas Schilling
7e1cc872bd
Add tracking circles support
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-06-22 11:40:40 +02:00
Andy Scherzinger
2db4cbf4d1
reformat kotlin
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-22 11:18:07 +02:00
Andy Scherzinger
fc0962780c
improve lint score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-22 11:18:07 +02:00
Andy Scherzinger
4ebc64de1c
improve codacy score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-22 11:18:06 +02:00
Andy Scherzinger
2cf5952fae
bump detekt score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-22 11:18:05 +02:00
Andy Scherzinger
2b71d30637
reformat kotlin
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-22 11:18:04 +02:00
Andy Scherzinger
19dcd8267a
replace deprecated method calls
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-22 11:18:02 +02:00
Andy Scherzinger
db68b4e93d
improve voice message UI
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-22 11:18:02 +02:00
Marcel Hibbe
7709967712
fix imports
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-22 11:18:00 +02:00
Joas Schilling
9fbf9ef492
add voice messages
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-22 11:17:59 +02:00
Andy Scherzinger
df6b0980ac
improve contacts preview UI
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-21 17:35:05 +02:00
Joas Schilling
b9893e031c
Show "contact-name" and "contact-photo" when applicable
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-06-21 17:35:04 +02:00
Marcel Hibbe
0e66d75b7d
improve handling for missing location permissions
add fallback to gps if no NETWORK_PROVIDER was found

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-21 13:14:38 +02:00
Andy Scherzinger
dd162e8c61
@Suppress("Detekt.TooGenericExceptionCaught")
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 16:38:52 +02:00
Andy Scherzinger
005dfa9397
prevent crash on async callback
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 15:29:26 +02:00
Andy Scherzinger
57ddb317fd
hide icon on location picker
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 15:16:45 +02:00
Andy Scherzinger
cedc54dbb6
Improve codacy
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 12:53:27 +02:00
Andy Scherzinger
fb04505663
reformat kotlin
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:59:11 +02:00
Andy Scherzinger
f242b5fcec
hide deletion action ob object_share messages popup menu
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:55:32 +02:00
Marcel Hibbe
80e1bc6505
add ACCESS_COARSE_LOCATION for LocationPickerController
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:51:30 +02:00
Andy Scherzinger
686e499875
cleanup client implementation
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:23:01 +02:00
Andy Scherzinger
f52d7f29d9
replace nominatimClient with copied/pacthes version replacing legacy httpClient with okhttp3
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:58 +02:00
Andy Scherzinger
ba64d693ef
further codacy improvements
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:56 +02:00
Andy Scherzinger
03fda89a22
reformat kotlin
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:55 +02:00
Andy Scherzinger
a8368e626e
improve codacy score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:52 +02:00
Andy Scherzinger
01a552b8d3
reformat code for ktlint compliance
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:47 +02:00
Andy Scherzinger
f899ee1d2f
make httpclient compileOnly since it ships with the OS
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:46 +02:00
Andy Scherzinger
6ba541b6b1
Move message holders to native view bindings
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:44 +02:00
Andy Scherzinger
71bffc0ea8
suppress generic exception handling warnings
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:42 +02:00
Andy Scherzinger
3c4714f716
fix after rebase
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:39 +02:00
Andy Scherzinger
ac986c61aa
cleanup to new base controller logic
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:36 +02:00
Andy Scherzinger
73e0b4e719
polish location map and move to native view bindings
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:34 +02:00
Andy Scherzinger
9f8a98ba07
remove unused imports
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:32 +02:00
Andy Scherzinger
adda60c7fb
Use native view bindings for GeocodingController
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:30 +02:00
Andy Scherzinger
43bf2ca7ae
use right context to be day/night theme aware
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:27 +02:00
Marcel Hibbe
94e466598e
add copyright headers
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:26 +02:00
Marcel Hibbe
4cdd13c92e
use CapabilitiesUtil for geo-location-sharing
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:23 +02:00
Marcel Hibbe
0568ea6e72
update location when gps changed
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:21 +02:00
Marcel Hibbe
751cd1268e
replace current-position icon
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:19 +02:00
Marcel Hibbe
22333d2f57
disable text fields for location messages (workaround)
i tried to suppress that zip codes are shown as clickable telephopne numbers. but
  android:autoLink="none"
and
  messageText!!.linksClickable = false
don't seem to work.
as a workaround i disabled the text field completely. so the links are still underlined but nut clickable. and it's also not possible now to mark text and get the context menu.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:18 +02:00
Marcel Hibbe
3cb0fe75b1
remove unnecessary logic from LocationMessageViewHolders
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:16 +02:00
Marcel Hibbe
4190cf1dfe
add FLAG_ACTIVITY_NEW_TASK for incoming location message
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:14 +02:00
Marcel Hibbe
2154b6cf94
improve design of share location button / location description
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:12 +02:00
Marcel Hibbe
9ffd5a7579
hide location sharing when capability is missing
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:09 +02:00
Marcel Hibbe
d4e49a20bb
decrease lint warnings
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:06 +02:00
Marcel Hibbe
fdf6b04fb8
decrease spotbugs warnings
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:02 +02:00
Marcel Hibbe
60827afe5c
decrease lint warnings
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:59 +02:00