Commit graph

2541 commits

Author SHA1 Message Date
Andy Scherzinger
d894454f4f
Merge pull request #1325 from nextcloud/dependabot/gradle/org.mockito-mockito-core-3.11.1
Bump mockito-core from 3.11.0 to 3.11.1
2021-06-15 14:07:13 +02:00
Nextcloud bot
1c2dc0a4f3
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-06-15 04:10:44 +00:00
dependabot[bot]
e643bef1a5
Bump exoplayer from 2.14.0 to 2.14.1
Bumps [exoplayer](https://github.com/google/ExoPlayer) from 2.14.0 to 2.14.1.
- [Release notes](https://github.com/google/ExoPlayer/releases)
- [Changelog](https://github.com/google/ExoPlayer/blob/release-v2/RELEASENOTES.md)
- [Commits](https://github.com/google/ExoPlayer/compare/r2.14.0...r2.14.1)

---
updated-dependencies:
- dependency-name: com.google.android.exoplayer:exoplayer
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-06-15 01:06:17 +00:00
Nextcloud bot
0d3478ff8d
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-06-14 04:00:54 +00:00
Nextcloud Android Bot
279169422e Weekly 12.0.0 Alpha 16 2021-06-14 03:13:00 +00:00
dependabot[bot]
3fab83e929
Bump mockito-core from 3.11.0 to 3.11.1
Bumps [mockito-core](https://github.com/mockito/mockito) from 3.11.0 to 3.11.1.
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](https://github.com/mockito/mockito/compare/v3.11.0...v3.11.1)

---
updated-dependencies:
- dependency-name: org.mockito:mockito-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-06-14 01:07:28 +00:00
Nextcloud bot
fa0c726c74
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-06-13 04:01:23 +00:00
Nextcloud bot
51ee57d550
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-06-12 04:02:37 +00:00
Andy Scherzinger
dd162e8c61
@Suppress("Detekt.TooGenericExceptionCaught")
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 16:38:52 +02:00
Andy Scherzinger
e51271d300
add linebreaks
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 16:30:38 +02:00
Andy Scherzinger
c2c93e5496
remove unused http legacy client
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 15:29:42 +02:00
Andy Scherzinger
005dfa9397
prevent crash on async callback
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 15:29:26 +02:00
Andy Scherzinger
57ddb317fd
hide icon on location picker
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 15:16:45 +02:00
Andy Scherzinger
cedc54dbb6
Improve codacy
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 12:53:27 +02:00
Andy Scherzinger
fb04505663
reformat kotlin
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:59:11 +02:00
Andy Scherzinger
f242b5fcec
hide deletion action ob object_share messages popup menu
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:55:32 +02:00
Marcel Hibbe
80e1bc6505
add ACCESS_COARSE_LOCATION for LocationPickerController
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:51:30 +02:00
Andy Scherzinger
686e499875
cleanup client implementation
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:23:01 +02:00
Andy Scherzinger
f52d7f29d9
replace nominatimClient with copied/pacthes version replacing legacy httpClient with okhttp3
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:58 +02:00
Andy Scherzinger
ba64d693ef
further codacy improvements
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:56 +02:00
Andy Scherzinger
03fda89a22
reformat kotlin
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:55 +02:00
Andy Scherzinger
bd2de486c3
restore original dependency definition
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:54 +02:00
Andy Scherzinger
a8368e626e
improve codacy score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:52 +02:00
Andy Scherzinger
a5923de582
rearrange docs
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:51 +02:00
Andy Scherzinger
01a552b8d3
reformat code for ktlint compliance
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:47 +02:00
Andy Scherzinger
f899ee1d2f
make httpclient compileOnly since it ships with the OS
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:46 +02:00
Andy Scherzinger
6ba541b6b1
Move message holders to native view bindings
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:44 +02:00
Andy Scherzinger
71bffc0ea8
suppress generic exception handling warnings
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:42 +02:00
Andy Scherzinger
3c4714f716
fix after rebase
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:39 +02:00
Andy Scherzinger
ac986c61aa
cleanup to new base controller logic
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:36 +02:00
Andy Scherzinger
73e0b4e719
polish location map and move to native view bindings
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:34 +02:00
Andy Scherzinger
9f8a98ba07
remove unused imports
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:32 +02:00
Andy Scherzinger
adda60c7fb
Use native view bindings for GeocodingController
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:30 +02:00
Andy Scherzinger
31d585e763
polish location search result items
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:29 +02:00
Andy Scherzinger
43bf2ca7ae
use right context to be day/night theme aware
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:27 +02:00
Marcel Hibbe
94e466598e
add copyright headers
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:26 +02:00
Marcel Hibbe
e9ca9f5a93
use tools:text for geocoding_item
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:24 +02:00
Marcel Hibbe
4cdd13c92e
use CapabilitiesUtil for geo-location-sharing
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:23 +02:00
Marcel Hibbe
0568ea6e72
update location when gps changed
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:21 +02:00
Marcel Hibbe
751cd1268e
replace current-position icon
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:19 +02:00
Marcel Hibbe
22333d2f57
disable text fields for location messages (workaround)
i tried to suppress that zip codes are shown as clickable telephopne numbers. but
  android:autoLink="none"
and
  messageText!!.linksClickable = false
don't seem to work.
as a workaround i disabled the text field completely. so the links are still underlined but nut clickable. and it's also not possible now to mark text and get the context menu.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:18 +02:00
Marcel Hibbe
3cb0fe75b1
remove unnecessary logic from LocationMessageViewHolders
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:16 +02:00
Marcel Hibbe
4190cf1dfe
add FLAG_ACTIVITY_NEW_TASK for incoming location message
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:14 +02:00
Marcel Hibbe
2154b6cf94
improve design of share location button / location description
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:12 +02:00
Marcel Hibbe
9ffd5a7579
hide location sharing when capability is missing
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:09 +02:00
Marcel Hibbe
d4e49a20bb
decrease lint warnings
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:06 +02:00
Marcel Hibbe
fdf6b04fb8
decrease spotbugs warnings
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:02 +02:00
Marcel Hibbe
60827afe5c
decrease lint warnings
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:59 +02:00
Marcel Hibbe
ffdc630b76
avoid UNSAFE_HASH_EQUALS reported by SpotBugs
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:58 +02:00
Marcel Hibbe
ab63a1970b
extract hardcodings
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:56 +02:00
Marcel Hibbe
49b2455a23
reverse-geocode before sharing if address-name is empty
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:54 +02:00
Marcel Hibbe
d7a8935709
show geocoded location on map before sharing
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:53 +02:00
Marcel Hibbe
96e5e544ea
share geocoding-result on click
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:51 +02:00
Marcel Hibbe
26ae4fa548
share geocoded location
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:50 +02:00
Marcel Hibbe
2f0105abd3
add location search with nominatim
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:49 +02:00
Marcel Hibbe
d5face5941
improve design for locationpicker screen
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:47 +02:00
Marcel Hibbe
e8a9fa6303
add "...sent a location" strings for Conversation list
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:46 +02:00
Marcel Hibbe
095c13172c
share location to chat by button click
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:44 +02:00
Marcel Hibbe
ae485d1d80
delete example activity for leaflet
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:43 +02:00
Marcel Hibbe
1aa15ebd95
differ between incoming and outcoming messages for location
logic was copied from:
- MagicIncomingTextMessageViewHolder.kt
- MagicOutcomingTextMessageViewHolder.kt

xml design was copied from:
- item_custom_incoming_text_message.xml
- item_custom_outcoming_text_message.xml

... and extended for location related things.

because of copying there is now quite a lot of redundant code! But ViewHolders should generally be refactored in the future.. (better inheritance(?) and analyze which of Marios changes to the Chatkit lib were really necessary or if this can be done in an other way..)

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:42 +02:00
Marcel Hibbe
7540e57dd8
open geolink on click + minor refactoring
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:40 +02:00
Marcel Hibbe
04fb57df7a
pass java to javascript params with URLEncoder
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:39 +02:00
Marcel Hibbe
5da43d1760
wip. show leaflet inside webview in message
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:37 +02:00
Marcel Hibbe
ba7bfe3150
chnage LocationMessageViewHolder to kotlin
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:36 +02:00
Marcel Hibbe
4d29a4b638
add LocationMessageViewHolder for ChatKit
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:35 +02:00
Marcel Hibbe
1e2960a72a
add example for leaflet in WebView
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:33 +02:00
Marcel Hibbe
73becd432d
add logic for geolocation message
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:32 +02:00
Marcel Hibbe
965692ce7e
set location picker icon over map
show location when clicked on button

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:31 +02:00
Marcel Hibbe
0742afe58c
add map via osmdroid
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:30 +02:00
Marcel Hibbe
c6d3abf421
add entry to share location
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:25 +02:00
Andy Scherzinger
14b9d1c95c
Merge pull request #1319 from nextcloud/dependabot/gradle/daggerVersion-2.37
Bump daggerVersion from 2.36 to 2.37
2021-06-11 10:20:20 +02:00
Nextcloud bot
b7037ca7e7
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-06-11 04:07:52 +00:00
dependabot[bot]
95bce514f3
Bump daggerVersion from 2.36 to 2.37
Bumps `daggerVersion` from 2.36 to 2.37.

Updates `dagger` from 2.36 to 2.37
- [Release notes](https://github.com/google/dagger/releases)
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md)
- [Commits](https://github.com/google/dagger/compare/dagger-2.36...dagger-2.37)

Updates `dagger-compiler` from 2.36 to 2.37
- [Release notes](https://github.com/google/dagger/releases)
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md)
- [Commits](https://github.com/google/dagger/compare/dagger-2.36...dagger-2.37)

---
updated-dependencies:
- dependency-name: com.google.dagger:dagger
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: com.google.dagger:dagger-compiler
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-06-11 01:06:18 +00:00
Nextcloud bot
3a7f04ed82
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-06-10 04:19:16 +00:00
Andy Scherzinger
5d41b0fae2
rename HashMap
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-09 13:50:28 +02:00
Andy Scherzinger
047372ad37
flip string com pare for null-safety
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-09 13:50:27 +02:00
Andy Scherzinger
893f015edf
shorten Log Tag
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-09 13:50:25 +02:00
Andy Scherzinger
cf24965f7f
code formatting, make TAG final
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-09 13:50:24 +02:00
Andy Scherzinger
f3dd482476
link swipe-to-reply to messages replyable-flag
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-09 13:50:18 +02:00
Marcel Hibbe
e03f048126
fix displaying of large images
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-09 13:19:49 +02:00
Nextcloud bot
ec976fcbdd
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-06-09 04:08:06 +00:00
Andy Scherzinger
db231ed12b
update after rebase, lower detekt score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 23:26:09 +02:00
Andy Scherzinger
7372d108a7
housekeeping to improve codacy/detekt score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 23:21:20 +02:00
Andy Scherzinger
bc20e0438f
replace magic numbers with constants
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 23:20:55 +02:00
Andy Scherzinger
292bee8396
Swipe to reply for chat messages (incoming/outgoing/preview)
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 23:20:54 +02:00
Andy Scherzinger
b513d0f154
improve detekt score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:37:06 +02:00
Andy Scherzinger
e4da772882
ignore detekt for"Detekt.TooGenericExceptionCaught" in scenarios where we need to handle NPE explicitly
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:37:05 +02:00
Andy Scherzinger
40a08394bc
hardened view binding interaction
...in case of asynchronous UI interaction with already destroyed UI

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:37:02 +02:00
Andy Scherzinger
7b7eaa455d
binding isn't nullable
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:37:01 +02:00
Andy Scherzinger
ebc3dbdf79
improve readability of toolbar/searchbar handling code
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:58 +02:00
Andy Scherzinger
266a9f73ee
add destruction check before accessing the binding object
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:53 +02:00
Andy Scherzinger
faf9ce2884
combine nested ifs
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:48 +02:00
Andy Scherzinger
46a18ca3a0
organize imports
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:45 +02:00
Andy Scherzinger
f8a8b81ef7
line length 1220 characters
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:43 +02:00
Andy Scherzinger
f4cfc9cef3
improve spotbugs
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:41 +02:00
Andy Scherzinger
cfe00937c5
comment unused, overridden methods and respect 120 character line length
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:39 +02:00
Andy Scherzinger
e7ea57bf85
reformat kotlin
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:37 +02:00
Andy Scherzinger
45a88c0722
replace menu switch statements with if/else
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:34 +02:00
Andy Scherzinger
3c0ef1d1e0
add linebreak
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:32 +02:00
Andy Scherzinger
63fabeda09
convert lock controller to kotlin
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:31 +02:00