Commit graph

295 commits

Author SHA1 Message Date
Marcel Hibbe
8381e0b541
add logging for calls
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-22 22:41:17 +01:00
Marcel Hibbe
477100ccd8
delete unused method leaveRoom
delete redundant if-check

cleanup of commit ca9a622030

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-16 19:53:45 +01:00
Marcel Hibbe
41ff61be5f
set pipGroupCallOverlay to gone when not needed
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-16 16:19:18 +01:00
Marcel Hibbe
9499b8117b
fix that call controls appear on touch when connecting
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-16 16:19:17 +01:00
Marcel Hibbe
e2668c4000
delete zlevel of call controls (not needed)
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-16 16:19:17 +01:00
Marcel Hibbe
48cda08854
delete if-checks for view bindings
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-16 16:19:17 +01:00
Marcel Hibbe
f2e75a7b71
add workaround to start videocalls when PIP is disabled
this is a dirty workaround for issue #1677

Somehow onUserLeaveHint is executed when the user starts a videocall. If PIP is disabled, the logic inside enterPipMode would finish the activity right after it was started.
This workaround suppresses the execution of enterPipMode right after the activity was started.
However if a user would press the home button in the first three seconds, the call would continue in background without the ability to recover the UI.

To better fix this bug it must be found out why onUserLeaveHint is executed on start (this should not happen!).

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-15 12:19:40 +01:00
Andy Scherzinger
d0f52c8eba
make sure to torn of torch after taking a picture
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:53 +01:00
Andy Scherzinger
dd9501590b
replace resolution and crop icons and preserve state in lifecycle
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:53 +01:00
Adam Serbinski
c3a37222b3
Crop and 2MP buttons to go away when reviewing
Signed-off-by: Adam Serbinski <adam@serbinski.com>
2021-11-11 22:10:52 +01:00
Adam Serbinski
7edd87fa4e
Add crop and low res (2MP) drawables
Signed-off-by: Adam Serbinski <adam@serbinski.com>
2021-11-11 22:10:52 +01:00
Adam Serbinski
13d376b25b
Add toggles for crop and lowres
Upper left -- crop
Upper right -- lowres (1920x?)

Signed-off-by: Adam Serbinski <adam@serbinski.com>
2021-11-11 22:10:51 +01:00
Adam Serbinski
d2d98314ee
Upload from camera: pinch to zoom, apect ratio
This implements pinch to zoom in the full range supported by the
camera HAL, fixes aspect ration handling on rotation, and sets up
for multiple resolution and aspect ratio support.

Signed-off-by: Adam Serbinski <adam@serbinski.com>
2021-11-11 22:10:51 +01:00
Andy Scherzinger
03cb3a66c6
move flash/flip-cam toggles
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:49 +01:00
Andy Scherzinger
14a3e488cc
limit image size for cam uploads to FHD
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:47 +01:00
Andy Scherzinger
7e688c43af
update cam libs to sdk=30 versions, improve previews and removal of temp images in case of cancellations
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:47 +01:00
Andy Scherzinger
67c421a067
add retake, send actions and preview
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:46 +01:00
Andy Scherzinger
547e9ebf8b
improve camera layout
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:46 +01:00
Andy Scherzinger
56d57c0b37
improve code check score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-11 22:10:45 +01:00
Andy Scherzinger
0b8add1f69
Adding upload from camera action
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Co-Authored-by: Stefan Niedermann <info@niedermann.it>
2021-11-11 22:10:41 +01:00
Marcel Hibbe
14abe52b6a
rename CallActivityBase to CallBaseActivity
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:52:18 +01:00
Marcel Hibbe
36c5f0814b
remove avatar blurring for background (=fix blocking of call controls)
no blurring or other background color calculation is done any more. BlurPostProcessor took too long for the used image size. If this is a requirement in the future, use ScalingBlurPostprocessor instead of  BlurPostprocessor (so fresco lib fork from nextcloud has to be updated!), see https://frescolib.org/docs/modifying-image.html

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:52:18 +01:00
Marcel Hibbe
9070153d5c
create abstract class for CallActivity and CallNotificationActivity
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:52:18 +01:00
Marcel Hibbe
be9971ad7a
disable back button when pip is not available
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:52:18 +01:00
Marcel Hibbe
e6da2fcc19
replace hardcoded applicationId for pip permission check
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:52:18 +01:00
Marcel Hibbe
89d0bcfc78
hide navigation bar if pip is not available
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:52:18 +01:00
Marcel Hibbe
f5106e6050
check if pip mode is granted on device, otherwise hide button
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:52:18 +01:00
Marcel Hibbe
f9a28cb0aa
fix to hide selfVideo when pip-view is tapped
on some devices (reproduced with Pixel2 on api level30) the own video became visible when the pip view was tapped. This fix should hide the own video.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:52:18 +01:00
Marcel Hibbe
289bd2fa00
fix klint error
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
63593df03e
hide peer name when in pip mode
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
052dc588aa
remove comment
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
b822eb8417
reformat code in CallNotificationActivity
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
b3f8a36c62
load avatar again in CallNotificationActivity
was only disabled for debugging. still needs to be fixed with https://github.com/nextcloud/talk-android/issues/1234

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
7a7888f5d1
reformat code in CallActivity
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
71ae7eddc2
move code from onStart to onCreate
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
0bfeb1b320
add action button to mute/unmute in pip mode
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
4a1c637efc
add checks if pip is supported by device
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
a0c95113bf
display overlay instead of grid in pip view for group calls
this is a quick and dirty solution until "speaker view" is introduced in the future which should be used for the pip view.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
57804c8d62
dismiss keyguard for CallNotificationActivity (WIP, see TODO)
Whenever i click the button to accept the call, CallActivity is started by intent.
CallActivity itself has the same logic to dismiss the keyguard.

The problem is: When switching from CallNotificationActivity to CallActivity the lockscreen is shown indeed!
So i guess Android recognizes "oh, CallNotificationActivity is gone. Let's show the lockscreen" before it recognizes that
the new activity also dismiss the lockscreen ?!

I fear for this scenario it was not the best idea to have 2 different activies.. (before it was only 1 activity and 2 condcutor controllers..)

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
e05334cb9a
enable pip support for CallNotificationActivity
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
7e68ecbde9
rename "runAllThings"
:D :D
setUpAfterConversationIsKnown might not be the best name, but i'm not sure when in onCreate the currentConversation can be null. depending on that it might even not be necessary to have the "things" in a method..

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
3326b6a7f3
rename design for CallActivity
move methods

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
c7e38e4859
replace CallNotificationController with Activity (WIP)
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
251d41f7fb
replace CallController with CallActivity etc. (WIP)
- delete MagicCallActivity
- replace butterknife with viewbinding for CallActivity

TODO:
- also switch CallNotificationController to Activity
- check if CallActivity and CallNotificationActivity are called correctly
- testing!

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
03913b40a2
fix to enable pip for CallNotification Controller
methods to update UI are not yet implemented. maybe it's better to make two Activities: one for Call and one for CallNotification...

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
0d1e0af9d1
fix NPE when call is joined by notification
add ability to have PIP mode for calls joined by notification

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
2c1b45491d
start pip mode when back button is pressed
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
1ae5f51a81
hide pip button for android < 8
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
3ba599be98
rename old "pip*"-stuff to "selfVideo*"
improve design-logic for pip-mode and normal mode when switched back from pip

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00
Marcel Hibbe
d482d8603e
modify call screen design for pip mode
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-11-11 13:23:40 +01:00