mirrors/nextcloud-talk-android
1
0
Fork 0
mirror of https://github.com/nextcloud/talk-android.git synced 2024-12-17 14:12:00 +03:00
Code Issues Projects Releases Packages Wiki Activity
4701 commits 94 branches 415 tags 79 MiB
Commit graph

2276 commits

Author SHA1 Message Date
Andy Scherzinger
aebebe5410 Migrate OperationsMenuController to kotlin 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-05-07 11:21:29 +00:00
Andy Scherzinger
0c5429bd7b
Merge pull request #2001 from nextcloud/bugfux/1975/fixNPEforMimetype 
make attributes of file nullable and handle null values
 2022-05-07 12:54:56 +02:00
Marcel Hibbe
59f1f003ca
avoid NPE 
trying to avoid #1976

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-05-06 23:48:44 +02:00
Marcel Hibbe
a5f7ecc5d8
make attributes of file nullable and handle null values 
nullable attributes of files can be found at https://github.com/nextcloud/server/blob/master/lib/public/RichObjectStrings/Definitions.php#L303-L351

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-05-06 23:21:10 +02:00
Marcel Hibbe
30f65424a5
fix NPE for viewbinding 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-05-06 14:58:30 +02:00
Andy Scherzinger
6cdce6db50
Merge pull request #1928 from nextcloud/bugfix/noid/removeButterknife 
remove unused butterknife binding
 2022-05-06 14:39:55 +02:00
Andy Scherzinger
fafbcbd1cd
Merge pull request #1957 from nextcloud/bugfix/1956/hideReactionsForReadOnlyConversations 
Hide reactions from menu if conversation is read-only
 2022-05-06 14:38:15 +02:00
Andy Scherzinger
8f654937de
Always show reaction count 
Resolves #1983

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-05-05 22:51:20 +02:00
drone
be1b075234 Merge commit 'e52b2d8b7ffbad4e4343bb6b97d40663ddc58149' 2022-05-05 11:06:39 +00:00
Tim Krüger
e52b2d8b7f
Add null checks and extract constants 
Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-05-05 13:06:15 +02:00
Tim Krüger
4f5a344a20
Add handling for "event.participants.update.all" 
In case a moderator of a restricted room ends the call for all
participants a update participants event with the field 'all=true' will
be thrown by the HPB.

    {
      "type": "event"
      "event": {
        "target": "participants",
        "type": "update",
        "update": [
          "roomid": "the-room-id",
          "incall": new-incall-state,
          "all": true
        ]
      }
    }

In that case the call can be ended directly without handling every
single participant.

Resolves: #1881

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-05-04 13:49:04 +02:00
Tim Krüger
0c1303e0af
Fix Detekt issues in LocationPickerController 
- LongMethod - 94/60 - [initMap]
- ComplexMethod - 15/10 - [initMap]
- ReturnCount - [areAllGranted]

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-05-04 11:30:17 +02:00
Tim Krüger
377e171156
Fix Detekt issues in ChatUtils 
- ComplexMethod - 11/10 - [getParsedMessage]
- NestedBlockDepth - 4/4 - [getParsedMessage]

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-05-04 11:30:06 +02:00
Marcel Hibbe
d6a4e54957
fix klint 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-05-03 12:47:04 +02:00
Tim Krüger
8e981f04b0
Catch NPE on ServerSelection view binding 
Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-05-03 12:47:03 +02:00
Tim Krüger
b60de3858b
Catch NPE on Chat view binding 
Resolves: #1960

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-05-03 12:47:03 +02:00
Tim Krüger
5cb36d0801
Catch NPE on Profile view binding 
Resolves: #1959

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-05-03 12:47:03 +02:00
Tim Krüger
ff5f686d7c
Catch NPE on webLogin view binding 
Resolves: #1958

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-05-03 12:47:03 +02:00
Marcel Hibbe
7f2b337565
fix to load conversations when servers status app is disabled 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-05-03 11:16:54 +02:00
Andy Scherzinger
572a212fc1
hide reactions from menu if conversation is read-only 
Fixes #1956

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-05-02 23:01:58 +02:00
Andy Scherzinger
38146dabf0
remove unused butterknife binding 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-05-02 18:09:58 +02:00
Daniel Calviño Sánchez
3274c1e1fa
Fix typo in name of method to check if video should not be received 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2022-05-02 13:36:13 +02:00
Marcel Hibbe
d539161768
fix NumberFormatException 
fix NumberFormatException for files >2,14 GB (=limit that can be represented by Int)

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-05-02 10:54:49 +02:00
Marcel Hibbe
2e54c456d1
fix klint warning 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-29 15:32:54 +02:00
Marcel Hibbe
e0d1f16106
show progress bar also when user left and re-entered the media tab screen 
how to test:
1. click on file with big file size that was not clicked before (so it's not in the cache)
2. leave media tab view or just select other tab.
3. go back to the clicked file
4. --> see that progress bar is still spinning (otherwise it's already finished and a click should oen the file directly without showing the progress bar)

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-29 15:24:56 +02:00
Marcel Hibbe
734f33caba
add fallback image for mimetype if drawee request fails 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-29 14:24:14 +02:00
Tim Krüger
a64e22c820
Fix ktlin issues 
Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-04-29 14:09:36 +02:00
Tim Krüger
afe61b7aa1
Unify naming of shared item layouts 
Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-04-29 14:03:59 +02:00
Tim Krüger
58acf3edc8
Rename 'SharedItemsAdapter' to 'SharedItemsGridAdapter' 
Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-04-29 13:44:11 +02:00
Tim Krüger
721797c078
Hide tabs without content in shared items view 
Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-04-29 13:41:54 +02:00
Marcel Hibbe
b22ed7399d
fix to close media view when press back button 
when starting media tab from conversation info, the back button opened media tab again. to fix this FLAG_ACTIVITY_CLEAR_TOP was set as flag

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-29 13:21:30 +02:00
Marcel Hibbe
b49a1bbbde
fix klint warnings 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-29 12:26:30 +02:00
Marcel Hibbe
a91ff9e920
make tabbar full width 
improve design

hide "Other" tab

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-29 11:53:59 +02:00
Marcel Hibbe
8c20180545
show mimetype icons from DrawableUtils 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-29 11:53:59 +02:00
Marcel Hibbe
fd08ad965a
add filesize and date to listview for shared items 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-29 10:53:00 +02:00
Tim Krüger
962e43857e
Check for spreed capability "rich-object-list-media" 
If the capability is not available the shared items can't shown.

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-04-29 10:04:56 +02:00
Andy Scherzinger
5c662427f8
improve detekt score 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-04-28 21:29:54 +02:00
Andy Scherzinger
eaab887765
refactor duplicated code 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-04-28 21:18:29 +02:00
Andy Scherzinger
48c7ccb4b0
improve detekt score 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-04-28 21:10:21 +02:00
Andy Scherzinger
f5d70dab0c
mediaItems can be null 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-04-28 18:36:34 +02:00
Tim Krüger
6f277cbe92
Fix new introduced SpotBugs error and warnings 
Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-04-28 17:57:30 +02:00
Tim Krüger
000184a338
Remove lint error for using 'Hashmap#forEach' 
Call requires API level 24 (current min is 21): java.util.HashMap#forEach

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-04-28 17:37:22 +02:00
Tim Krüger
6b671191e9
Fix ktlint warning 
Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-04-28 17:14:10 +02:00
Tim Krüger
a322a2ad73
Load shared items while scrolling 
Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-04-28 17:09:26 +02:00
Marcel Hibbe
d92f5546e9
add progress bar for other items than media 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-28 15:56:23 +02:00
Marcel Hibbe
9edffc5e64
add progress bar for media items 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-28 15:42:55 +02:00
Marcel Hibbe
29f5d73f05
add adapter + design for list view 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-28 14:29:07 +02:00
Andy Scherzinger
b304e8facb
make shared items tabs translatable 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-04-28 13:44:13 +02:00
Marcel Hibbe
52b257d027
define other order of tabs 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-28 12:19:58 +02:00
Marcel Hibbe
0e75337caf
show items other than "media" as list (WIP) 
extract hardcoding

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-28 12:16:31 +02:00
Marcel Hibbe
fa90155195
hide location and deck for now 
because other fileParameters need to be handled

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-28 11:40:03 +02:00
Marcel Hibbe
b22b600352
initially load audio 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-28 10:58:27 +02:00
Marcel Hibbe
0ba74b1a30
replace hardcoded value for file previews 
request maximum_file_preview_size instead hardcoded 100px for file previews

but somehow this his no effect because many file previews are not found on sermo?!

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-28 10:48:00 +02:00
Marcel Hibbe
cc2e0348e5
fix to show also files 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-28 10:40:23 +02:00
Andy Scherzinger
69b0cc683a
properly theme bars 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-04-27 23:25:06 +02:00
Marcel Hibbe
cad7b4cb3d
add tabLayout for file types (WIP) 
quick&dirty, needs to be improved and might contain bugs

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-27 19:40:55 +02:00
Marcel Hibbe
3a1f3242d8
add fallback images for mimetypes if no preview image was found 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-27 17:17:34 +02:00
Marcel Hibbe
912bc3c8fe
open files from media view 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-27 14:16:22 +02:00
Marcel Hibbe
3a5a3cebfb
extract logic for downloading and opening files to helper class 
this is done because in a next step this logic should also be used by the SharedItemsAdapter

extracting is not yet done in a clean way. in a next step some better architecture patterns must be used to separate layers

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-27 14:15:59 +02:00
Tim Krüger
cf91e2390e
Fix ktlint issues 
Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-04-27 13:36:58 +02:00
Tim Krüger
df5c0044c1
Add app bar to view 'Shared items' 
Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-04-27 12:38:21 +02:00
Tim Krüger
d14f4b38ea
Check that header 'x-chat-last-given' exists 
Without that check a null pointer exception occurs if the header is not
set.

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-04-27 12:31:24 +02:00
Tim Krüger
53a1725606
Correct order of items in grid view 
Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-04-26 12:13:41 +02:00
Tim Krüger
a1b7e1260c
Add overview for shared items of a conversation 
Via the conversation info or the menu entry in the conversation menu a
overview of shared items can be opened.

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-04-25 16:15:44 +02:00
Tim Krueger
73b772dfa1
Merge pull request #1941 from nextcloud/fix-call-flags-in-video-calls 
Fix call flags in video calls
 2022-04-25 12:38:46 +02:00
Daniel Calviño Sánchez
07ca8c1e29
Fix call flags in video calls 
The call flags describe the streams provided by the client, so in a
video call both audio and video are provided, not just video.

Note that as publishing permissions are currently not implemented in the
Android app the provided flags do not take into account the available
permissions. Nevertheless, the server restricts the flags based on the
permissions, so the other participants would see the appropriate flags.
In the future it would be better to send the right flags directly from
the Android app.

Similarly, for now, it is just assumed that both audio and video tracks
will be provided by the Android app, but the flags should reflect the
actually available tracks (for example, if it was not possible to get a
video track for some reason the call flags should not include
"WITH_VIDEO").

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2022-04-25 11:54:22 +02:00
Andy Scherzinger
6316c709ad
fix npe if message has no self reactions initially 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-04-24 21:51:56 +02:00
Andy Scherzinger
e43c838fe7
convert into constant 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-04-23 13:22:25 +02:00
Marcel Hibbe
2495c25f22
add workaround to avoid emoji picker to take the full screen height 
The toggleEmojiPopup method is a hacky workaround to avoid bug #1914
As the bug happens only for the very first time when the popup is opened,
it is closed after some milliseconds and opened again.

200 milliseconds seems to be a good value to initialize the popup correctly with the desired size

downside: there is even some flickering when opening the "more emojis" window

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-22 19:09:37 +02:00
Tim Krueger
f7dcf58d3c
Merge pull request #1940 from nextcloud/fix-trying-to-establish-a-connection-before-a-participant-joins-the-call 
Fix trying to establish a connection before a participant joins the call
 2022-04-22 17:16:08 +02:00
Daniel Calviño Sánchez
5bd920142c Create a connection only for offers instead of for any message 
The Android app creates a connection with a participant when that
participant joins the call and ends it when the participant leaves the
call. However, it also created a connection when any signaling message
was received from a participant that had no connection yet. Due to this
if a signaling message was received from a participant before that
participant was in the call the Android app tried to establish a
connection too soon, which would be rejected by the HPB.

Similarly, if a signaling message was received from a participant after
that participant left the call a connection will try to be established.
That would fail, but the connection object was not removed, and if that
participant joined the call again no connection would be established, as
a connection for that participant was already found, even if it was not
usable.

To solve that now a connection is created when a signaling message is
received only if that message is an offer (which is necessary without
HPB if the other participant sends the offer before this participant
"noticed" that she is in the call); otherwise the message is ignored.

Besides that a connection will no longer be created either when setting
up the video stream. However, this would be just for correctness and it
should not make any difference, as the MediaStreamEvents that cause that
are only emitted by changes in peer connections, so they should be
already created.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2022-04-22 14:38:26 +02:00
Andy Scherzinger
fc0df0a9b3
remove reaction in case of already reacted 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-04-22 11:28:08 +02:00
Andy Scherzinger
6f246a1001
add visual to reactions bottom sheet if self is true 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-04-22 11:28:08 +02:00
Andy Scherzinger
2df414cb63
format kotlin 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-04-22 11:28:08 +02:00
Andy Scherzinger
e2015f2810
further improve padding/margin of reactions 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-04-22 11:28:08 +02:00
Andy Scherzinger
9ec7feaaee
prevent NPE when adding the very first own reaction to a message 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-04-22 11:28:07 +02:00
Marcel Hibbe
55a48585a7
don't dismiss dialog when clicked on reaction of someone else 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-22 11:28:07 +02:00
Marcel Hibbe
b136465415
fix more emojis ("...") color 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-22 11:28:07 +02:00
Marcel Hibbe
31bb614bac
highlight own emoji immediately when reacted via app 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-22 11:28:07 +02:00
Andy Scherzinger
dd59d2dd20
improve reactions alignment 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-04-22 11:28:07 +02:00
Andy Scherzinger
a5aecbcaa1
replace further contexts for proper day/night theming 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-04-22 11:28:06 +02:00
Andy Scherzinger
583b52588c
use proper context to be day/night aware 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-04-22 11:28:06 +02:00
Marcel Hibbe
fd98ccc816
add chip styled background to self reaction (wip) 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-22 11:28:05 +02:00
Marcel Hibbe
454200d797
add error message to log 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-22 11:28:05 +02:00
Marcel Hibbe
f945694a14
fix textcolor for reaction amount 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-22 11:28:04 +02:00
Daniel Calviño Sánchez
a8045880f9 Rename method to a more consistent name with its sibling method 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2022-04-22 02:31:21 +02:00
Daniel Calviño Sánchez
c769ff0fd0 Rename method to a more accurate name 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2022-04-22 02:30:46 +02:00
Marcel Hibbe
1cf55c6e8e
fix text for reaction notification 
hide content title for one2one rooms and reactions

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-21 17:12:50 +02:00
Marcel Hibbe
93e9b362b6
avoid crash when clicking on header in conversation search mode 
fix #1893

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-20 20:58:11 +02:00
Andy Scherzinger
300e7da172
extract method to reduce complexity 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-04-19 18:14:18 +02:00
Andy Scherzinger
c93041d402
move to a more hardened null-handling profile data handling 
Fixes #1908

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-04-19 17:40:14 +02:00
Andy Scherzinger
746c3a8a4e
catch NPE when UI is already teared down 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-04-19 17:09:16 +02:00
Dariusz Olszewski
5dca8bcb7d
Use setBackstack when starting new MainActivity from notification 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-04-19 12:57:32 +02:00
Marcel Hibbe
3d4f3eeb54
open reactions menu when long click on emojis in message 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-09 23:05:32 +02:00
Marcel Hibbe
7dd7738c04
use toggle for emoji popup 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-08 17:11:40 +02:00
Marcel Hibbe
17a8c48078
order emojis by amount 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-08 14:57:02 +02:00
Marcel Hibbe
54c40e99ef
hide amount in message if it's only 1 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-08 14:56:18 +02:00
Marcel Hibbe
07299bb32a
use light textcolor for reactions for outgoing message 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-08 13:59:24 +02:00
Marcel Hibbe
3f987fcdad
fix import of coil 
this must have been removed when auto cleaning imports while there was a problem to find the coil lib

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-08 13:56:57 +02:00
Marcel Hibbe
73d50c4f0e
add reactions for LocationMessageViewHolders 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-08 13:22:26 +02:00
Marcel Hibbe
c4de77ce00
fix to hide MessageActionsDialog for system messages 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-08 12:19:52 +02:00
Marcel Hibbe
65fb284c6c
add reactions for previewMessageHolders 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-08 09:21:15 +02:00
Andy Scherzinger
b4316ecaad
fix code checks warnings 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-04-08 09:21:14 +02:00
Andy Scherzinger
2068faa80e
correct tab listerner initialization 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-04-08 09:21:14 +02:00
Andy Scherzinger
660c3401f2
sort reaction lists 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-04-08 09:21:14 +02:00
Marcel Hibbe
2aa7a5eb67
rename adapter interface for voice messages 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-08 09:21:14 +02:00
Andy Scherzinger
0051d1d686
pin size of the bottom sheet 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-04-08 09:21:13 +02:00
Andy Scherzinger
6bda280d15
Add "all" tab for reactions 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-04-08 09:21:13 +02:00
Marcel Hibbe
357c67db83
fix to update UI only if reaction was actually added 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-08 09:21:13 +02:00
Marcel Hibbe
36b786616a
support reactions for TextMessages (in+out) and VoiceMessages (in+out) 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-08 09:21:13 +02:00
Andy Scherzinger
f17e892acd
improve detekt and format kotlin code 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-04-08 09:21:13 +02:00
Andy Scherzinger
500d651d69
replace emoji selection with tab layout 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-04-08 09:21:12 +02:00
Marcel Hibbe
aa5046cf27
add ability to delete reactions 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-08 09:21:12 +02:00
Marcel Hibbe
4e727924c2
fix to send reaction for message that has no reactions yet 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-08 09:21:12 +02:00
Marcel Hibbe
4670854848
show emoji picker to send reaction (buggy) 
emoji picker SOMETIMES opens in full height.
this is a bug inside the emoji picker lib, see https://github.com/vanniktech/Emoji/issues/474

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-08 09:21:12 +02:00
Marcel Hibbe
f4ab037a44
add ability to send emoji 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-08 09:21:12 +02:00
Andy Scherzinger
65e447b6a5
add some margins to the reactions on a message 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-04-08 09:21:11 +02:00
Andy Scherzinger
deac2059ff
improve lint/detekt 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-04-08 09:21:11 +02:00
Marcel Hibbe
eb961b0452
minor cleanup after merge 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-08 09:21:11 +02:00
Marcel Hibbe
9c0ea73b5d
fix parsing of json of emoji voters 
basic update for emoji voters in UI

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-08 09:21:11 +02:00
Marcel Hibbe
f61872af7c
remove redundant code for reactions recyclerview 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-08 09:21:10 +02:00
Andy Scherzinger
c4632f5d42
load avatars of reaction actors, optimize layout 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-04-08 09:21:10 +02:00
Andy Scherzinger
06f42a4c00
Render list of reactions in recycler view in bottom sheet 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-04-08 09:21:09 +02:00
Andy Scherzinger
c19dd5fc71
hide reactions when not supported by server 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-04-08 09:21:09 +02:00
Marcel Hibbe
4abe8ae41d
add details view for reactions (WIP) 
TODO: encoding for emoji is wrong to send it to server
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-08 09:21:09 +02:00
Andy Scherzinger
402a1bd3c3
organize imports 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-04-08 09:21:08 +02:00
Andy Scherzinger
3daaa8152e
fic kotlin formatting 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-04-08 09:21:08 +02:00
Andy Scherzinger
60b277637b
improve detekt score 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-04-08 09:21:08 +02:00
Andy Scherzinger
b06927726c
emoji bar for chat message bottomsheet 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-04-08 09:21:08 +02:00
Marcel Hibbe
d845422097
open dialog when clicked on reactions (WIP) 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-08 09:21:08 +02:00
Marcel Hibbe
382f17ca55
add margin between reactions 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-08 09:21:07 +02:00
Marcel Hibbe
818a8341a7
fix to hide avatar for 1to1conversations when reaction is received by system message 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-08 09:21:07 +02:00
Marcel Hibbe
34422f7b20
fix to removeAllViews also for messages without emojis 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-08 09:21:06 +02:00
Marcel Hibbe
2a1f2becbd
show max 4 emojis under message 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-08 09:21:06 +02:00
Marcel Hibbe
f45b48898f
update emojis when system message arrived 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-08 09:21:06 +02:00
Marcel Hibbe
dd603f25cf
add reactions to incoming text message (wip) 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-08 09:21:05 +02:00
Marcel Hibbe
0b898616a2
hide system messages related to reactions 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-08 09:21:05 +02:00
Marcel Hibbe
2986f7c3a5
add system messages for reactions 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-04-08 09:21:05 +02:00
Andy Scherzinger
9dc493b2f7
move popup menu to custom bottom sheet 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-04-01 11:33:18 +02:00
Marcel Hibbe
49fd2640bf
rename method 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-03-30 12:08:54 +02:00
Tim Krüger
346089cecf
Use Transceivers instead of constraints to discard received video tracks 
After the migration from WebRTC from plan b to unified plan in commit 86f20dc
the media constraints are ignored for creating an answer on a peer
connection:

> Offer to Receive Options/Constraints
>
> These constraints are passed to PeerConnection’s methods for creating SDP to
> add placeholder media sections in case a sending track would not have already
> created one.
>
> With Unified Plan semantics, these are still supported for creating offers
> using a backwards compatibility shim (basically creating an RtpTransceiver if
> one doesn’t exist). It is recommended to switch to the RtpTransceiver API
> (example below). _They are no longer supported when creating answers._
>
> [1]

Because of that now all transceivers of type VIDEO will be stopped if it
is only an audio call. After stopping the transceivers the status for the
video tracks will be automatically set to ENDED.

In the 'ParticipantsAdapter' it will be checked if the video tracks are
ENDED. In that case the user avatar will be shown like before.

Resolves: #1852
See: #1773, commit 86f20dc, [1]

[1] https://docs.google.com/document/d/1PPHWV6108znP1tk_rkCnyagH9FK205hHeE9k5mhUzOg/edit#heading=h.9dcmkavg608r

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-03-30 12:08:54 +02:00
Andy Scherzinger
2884c6e01c
Migrate search models to kotlin 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-29 17:37:59 +02:00
Andy Scherzinger
3935ce7955
remove unused resource 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-29 17:37:57 +02:00
Andy Scherzinger
9a2a3f3b6d
migrate userprofile to kotlin and align icon work with latest server 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-29 17:37:51 +02:00
Tim Krüger
4f80430018
Use correct API endpoint for predefined status 
Resolves: #1830

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-03-17 21:39:11 +01:00
Andy Scherzinger
af0065b664
Merge pull request #1873 from nextcloud/bugfix/noid/kotlinConversion3 
Migrate ProfileController to Kotlin
 2022-03-17 20:44:41 +01:00
Andy Scherzinger
5472097279
Merge pull request #1876 from nextcloud/bugfix/1853/fixQueryMap 
Bugfix/1853/fix query map
 2022-03-17 20:36:08 +01:00
Andy Scherzinger
47a02a93a0
shorten method to comply with detekt 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-17 18:45:00 +01:00
Andy Scherzinger
4685bced16
reformat kotlin 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-17 18:37:15 +01:00
Marcel Hibbe
1b30a6ef62
allow getPeersForCall without QueryMap 
- null was not allowed for query map (led to Illegal Argument Exception which caused issue #1853)

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-03-17 15:17:32 +01:00
Marcel Hibbe
5a90f999dc
add error logging 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-03-17 13:53:20 +01:00
Andy Scherzinger
bafa1559db
reformat kotlin 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-16 18:13:42 +01:00
Andy Scherzinger
766d07d3fa
prevent null-pointer in case remote file listing UI gets closed before the async loading comes back 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-16 16:57:13 +01:00
Andy Scherzinger
7db5c5ed76
migrate ProfileController to kotlin 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-16 16:50:37 +01:00
Andy Scherzinger
eed209428e
splitting up complex methods into smaller, easier to understand methods 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-15 18:21:29 +01:00
Andy Scherzinger
ac703a6ac7
extract magic numbers 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-15 17:46:40 +01:00
Andy Scherzinger
0ac5009242
reformat kotlin 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-15 17:45:06 +01:00
Andy Scherzinger
6b7dd29b07
migrate WebViewLoginController to kotlin 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-15 17:45:05 +01:00
Andy Scherzinger
ed4d27aff0
fix author mail 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-15 17:45:05 +01:00
Andy Scherzinger
cfe4847732
migrate RingtoneSelectionController to kotlin 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-15 17:44:52 +01:00
Tim Krüger
60e4ec9086
Use 'val' for never modified variables 
Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-03-15 14:35:08 +01:00
Dariusz Olszewski
1e76b45fb4
Switch to chat w/o animation when app opened from notification 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-03-15 14:35:08 +01:00
Dariusz Olszewski
ddcf1c48aa
Workaround for crash when loading avatar 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-03-15 13:33:30 +01:00
Andy Scherzinger
f36b7750de
format kotlin code 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-14 10:23:08 +01:00
Andy Scherzinger
ba3e24bbc7
replace too long paramter lists with data classes 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-14 10:23:07 +01:00
Andy Scherzinger
6e02c5de41
reformat kotlin 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-14 10:23:07 +01:00
Andy Scherzinger
6206e4910d
simplify complex conditions for readability 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-14 10:23:06 +01:00
Andy Scherzinger
454dbc5db2
unify http(s) protocoll prefix check on urls 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-14 10:23:06 +01:00
Andy Scherzinger
a10b67456c
ignore generic exception handling 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-14 10:23:05 +01:00
Andy Scherzinger
2102f0fbc8
document empty blocks 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-14 10:23:01 +01:00
Tim Krueger
08dc22c30f
Merge pull request #1841 from nextcloud/bugfix/1839/fail-to-set-empty-status-message 
Bugfix/1839/fail to set empty status message
 2022-03-11 15:33:58 +01:00
Tim Krüger
cb1dd8e5b5
Avoid empty status message 
Enable the 'Set status message' button only if a message is set.
Currently the API don't allow us to set an empty message [1].

See:
  [1] nextcloud/server#31452
  #1839

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-03-10 17:08:02 +01:00
Tim Krüger
f8e8a95b34
Use '==' instead of 'equals' in Kotlin 
In Kotlin for a check of the structural equality '==' should be used.
Referential equality is checked with '==='.

See:
 - https://kotlinlang.org/docs/equality.html

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-03-10 17:05:14 +01:00
Tim Krueger
70a30f146a
Merge pull request #1851 from nextcloud/bugfix/1848/showSystemMessageAddedGroup 
add groups and circles to system messages ("add"+"remove")
 2022-03-09 10:37:19 +01:00
Andy Scherzinger
0fe562d415
remove unused method parameters 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-07 13:40:42 +01:00
Tim Krüger
5ad6da86f1
Use Boolean constant values directly 
From the SpotBugs report:

> NAB_NEEDLESS_BOOLEAN_CONSTANT_CONVERSION: Method needlessly boxes a boolean
> constant
>
> This method assigns a Boxed boolean constant to a primitive boolean variable,
> or assigns a primitive boolean constant to a Boxed boolean variable. Use the
> correct constant for the variable desired. Use
>
>
> boolean b = true;
> boolean b = false;
>
> or
>
>
> Boolean b = Boolean.TRUE;
> Boolean b = Boolean.FALSE;
>
> Be aware that this boxing happens automatically when you might not expect it.
> For example,
>
>
> Map statusMap = ...
>
> public Boolean someMethod() {
>     statusMap.put("foo", true);  //the "true" here is boxed
>     return false;  //the "false" here is boxed
> }
>
> has two cases of this needless autoboxing. This can be made more efficient by
> simply substituting in the constant values:
>
>
> Map statusMap = ...
>
> public Boolean someMethod() {
>     statusMap.put("foo", Boolean.TRUE);
>     return Boolean.FALSE;
> }

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-03-07 13:11:23 +01:00
Andy Scherzinger
8e11f21233
adapt to java->kotlin changes regarding null-ability 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-07 09:55:30 +01:00
Andy Scherzinger
15e875f974
Migrate push models to kotlin data classes 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-07 09:50:19 +01:00
Marcel Hibbe
a1e694104c
add groups and circles to system messages ("add"+"remove") 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-03-04 14:58:46 +01:00
Marcel Hibbe
0079107461
revert commit d76203a0 
fix to support older conversationApi versions for canLeave and canDelete

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-03-04 09:23:42 +01:00
Marcel Hibbe
86caa48636
add logging for onError 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-03-04 09:23:41 +01:00
Andy Scherzinger
aa2a08692f
migrate statuses overall to kotlin data classes 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-03 18:00:53 +01:00
Andy Scherzinger
2008fb0c2a
migrate remaining status models to kotlin 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-03 12:50:58 +01:00
Marcel Hibbe
508f519468
set fixed avatar sizes for requests 
necessary because of https://github.com/nextcloud/server/pull/31010

known issue: avatars in chat messages are too big atm

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-03-02 15:15:22 +01:00
Andy Scherzinger
00c4b13f17
don't resize avatar views dynamically 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-02 14:33:53 +01:00
Tim Krüger
3411728597
Pass 'null' for unset icon in custom status message 
The OCS Status API  expect an valid emoji or 'null' for the status icon
in a custom message:

> field: statusIcon
> type: string/null
> Description: The icon picked by the user (must be an emoji, at most one)

See [1] for more details.

Resolves: #1839
See:
 [1] https://docs.nextcloud.com/server/latest/developer_manual/client_apis/OCS/ocs-status-api.html#set-a-custom-message-user-defined

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-03-02 09:50:08 +01:00
Dariusz Olszewski
93556da33a
Re-use existing ChatController from notification 
NotificationWorker provides the user information under KEY_USER_ENTITY parameter of the notification intent, but does not set the KEY_INTERNAL_USER_ID parameter.
With this change existing ChatController instance that has been opened manually from the conversation list is properly reused when a notification is opened.
Otherwise two instances of the ChatController were running in parallel for the same room, causing unintended side effects.

Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-03-01 13:19:18 +01:00
Dariusz Olszewski
c95d286de4
ktlint 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-03-01 13:19:18 +01:00
Dariusz Olszewski
a7bd6393df
Prevent overlapping pullChatMessages calls 
Sometimes pullChatMessages may be called before response to a previous call is received.
In such cases just ignore the second call. Message processing will continue when response to the earlier call is received.

Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-03-01 13:19:18 +01:00
Dariusz Olszewski
b2aef87b24
Re-organize sessionId handling 
- clean session Id when leaving the room rather than in onAttach
- invoke leaveRoom in onDetach only when we have a valid sessionId
This avoid calling joinRoom twice in some scenarios, or calling leaveRoom before joinRoom completes successfully.

Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-03-01 13:19:17 +01:00
Dariusz Olszewski
d31e6de5c4
Second attempt to fix the issue 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-03-01 13:19:17 +01:00
Dariusz Olszewski
d064ad3f65
Simplified code to avoid NullPointerException when server response arrives after the view was unbound. 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-03-01 13:19:17 +01:00
Dariusz Olszewski
606c6b0b9e
Avoid NullPointerException when server response arrives after the view was unbound. 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-03-01 13:19:17 +01:00
Dariusz Olszewski
505bcdfe20
Yet more diagnostic logging 
Also in ConversationsListController

Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-03-01 13:19:16 +01:00
Dariusz Olszewski
cfcfcf5bc4
Even more diagnostic logging 
Info to correlate calls and responses
Log errors

Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-03-01 13:19:16 +01:00
Dariusz Olszewski
b88530da6f
More diagnostic logging 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-03-01 13:19:16 +01:00
Dariusz Olszewski
b10d0cb98a
Revert "Notifications from lock screen - initial attempt to fix the issue" 
This reverts commit ce8bec73

Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-03-01 13:19:16 +01:00
Dariusz Olszewski
dfa14e7c52
Notifications from lock screen - initial attempt to fix the issue 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-03-01 13:19:15 +01:00
Dariusz Olszewski
be6e5d78cb
Additional logging to diagnose opening chat view from notification 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-03-01 13:19:14 +01:00
Andy Scherzinger
b750f41efd
kotlin code foermatting 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-03-01 10:21:09 +01:00
Andy Scherzinger
243e6161a6
Migrate AccountVerificationController to kotlin 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-02-28 18:25:53 +01:00
Andy Scherzinger
f76d25974e
migrate EntryMenuController to Kotlin 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-02-28 17:21:06 +01:00
Tim Krüger
45085b7e0b
Remove Parceler from model notifications 
Resolves: #1548

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-02-28 16:54:24 +01:00
Tim Krüger
d9587e9d18
Remove Parceler from model mention 
Resolves: #1548

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-02-28 16:54:24 +01:00
Tim Krüger
003d4c6af2
Remove unneeded not-null assertion operator (!!) 
Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-02-28 16:54:23 +01:00
Tim Krüger
94f2339baa
Remove unneeded package definition 
Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-02-28 16:54:23 +01:00
Tim Krüger
9f62df3a53
Suppress lint for unused result 
Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-02-28 16:54:22 +01:00
Tim Krüger
dad4f56e6a
Remove Parceler from model hovercard 
Resolves: #1548

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-02-28 16:54:22 +01:00
Andy Scherzinger
18f180bfe7
rename UserItem to ContactsItem to reflect its use case 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-02-28 13:26:40 +01:00
Andy Scherzinger
da39d12a7f
remove unneeded null checks 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-02-28 13:23:35 +01:00
Andy Scherzinger
92a2c44415
remove unused classes 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-02-28 13:23:10 +01:00
Andy Scherzinger
76270077a1
migrate view items to native view bindings 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-02-28 09:52:49 +01:00
Andy Scherzinger
7374176083
remove unused getter 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-02-28 09:52:48 +01:00
Andy Scherzinger
f47690db22
use seperate xml designs for Items (+use viewbinding) 
Resolves #1829

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-02-28 09:52:45 +01:00
Marcel Hibbe
9d29cbf9cd
fix vertical alignments for UserItem 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:28:33 +01:00
Andy Scherzinger
5c86629b53
fix license header mail format 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-02-25 12:25:52 +01:00
Andy Scherzinger
a3e86d841f
correct enum comparisons and add constants for fixed values 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-02-25 12:23:56 +01:00
Marcel Hibbe
0dc42a1b1e
fix NPE if status is null 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:11:46 +01:00
Andy Scherzinger
7ce1b9e916
adapt license header to app 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-02-25 12:11:46 +01:00
Andy Scherzinger
0677607dc4
migrate FlexibleItems to native view bindings 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-02-25 12:11:46 +01:00
Marcel Hibbe
d4f9f996c3
fix vertical alignment for MentionAutocompleteItem's 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:11:46 +01:00
Marcel Hibbe
ec438b0a9d
add rounded colors to online status buttons 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:11:45 +01:00
Marcel Hibbe
4984ba4dde
avoid linebreaks for "clear at" calculation 
because:
- can lead to wrong calculations!

- avoid klint complaining about indentation

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:11:45 +01:00
Marcel Hibbe
b7b92eb623
fix textcolor for highlighted online status button 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:11:45 +01:00
Marcel Hibbe
305ceedc75
align username etc vertical if no status message is set 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:11:44 +01:00
Marcel Hibbe
c746b95ac2
add author to license headers 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:11:44 +01:00
Marcel Hibbe
a7792cb66e
fix lint and spotbugs warnings 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:11:44 +01:00
Marcel Hibbe
ce002318a2
fix NPE for contacts view 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:11:44 +01:00
Marcel Hibbe
fc8462e0a5
use StatusDrawable for conversationInfo and mention autocomplete 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:11:44 +01:00
Marcel Hibbe
1da8c3b206
modify StatusDrawable and use it for conversationList 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:11:43 +01:00
Marcel Hibbe
73ce2716de
fix klint warnings 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:11:43 +01:00
Marcel Hibbe
4f1a188a38
fix lint/spotbug warnings 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:11:43 +01:00
Marcel Hibbe
4c07ccec11
fix NPE when opening Contacts view. 
because UserItem is used for ContactsController and ConversationInfoController it differs between two different xml designs in method getLayoutRes()
because of this there need to be checks which xml element exists or not. These are added with this commit.

In the long term UserItem should not use two different xml designs. This might also be a problem for view binding?!

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:11:43 +01:00
Marcel Hibbe
7820bc7c51
hide status of "Talk updates" conversation 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:11:43 +01:00
Marcel Hibbe
452baf4550
improve autocomplete mentions UI 
add status message and emoji
match parent
improve design
use rv_item_mention_conversation_info_participant instead of rv_item_mention.xml

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:11:42 +01:00
Marcel Hibbe
0078778c99
show status for autocomplete mentions 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:11:42 +01:00
Marcel Hibbe
6a9dea7522
fix autocomplete mentions 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:11:42 +01:00
Marcel Hibbe
e3fd9a7592
fix onlinestatus color for night mode 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:11:41 +01:00
Marcel Hibbe
ffbe39bd01
change UserStatusCapability to kotlin data class 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:11:41 +01:00
Marcel Hibbe
21af8381b0
hide secondary text for normal users 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:11:41 +01:00
Marcel Hibbe
22c770fa8a
set "away" / "dnd" as status message if it's empty 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:11:41 +01:00
Marcel Hibbe
176568b628
show online status AND emoji in conversations info 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:11:40 +01:00
Marcel Hibbe
d453773a1d
show user statuses in conversation info (wip) 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:11:40 +01:00
Marcel Hibbe
6057306ab3
show user statuses in conversation list 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:11:40 +01:00
Marcel Hibbe
e27ede75ff
tidy up 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:11:40 +01:00
Marcel Hibbe
546f3fe1f2
fix to be able to set only "icon" / only "clear at" for status 
api seems to set single modification for icon or "clear at" only if status message is not empty (must be at least whitespace)

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:11:40 +01:00
Marcel Hibbe
bce0d276f3
fix to be able to modify status message after predefined status was selected 
so api to set a predefined status is not used at all..

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:11:40 +01:00
Marcel Hibbe
ea634ff43c
delete comments 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:11:39 +01:00
Marcel Hibbe
45cfbc7257
add ability to set status type 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:11:39 +01:00
Marcel Hibbe
19060bddbd
delete comments 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:11:39 +01:00
Marcel Hibbe
622eaa1d7f
check capabilities to set status support 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:11:39 +01:00
Marcel Hibbe
dad53a77e6
fix wrong calculation for "in 4h" (=remove linebreak) 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:11:38 +01:00
Marcel Hibbe
967b63b017
draw status in ChooseAccountDialogFragment 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:11:38 +01:00
Marcel Hibbe
7cc8751a1f
disable set status button until status is received 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:11:38 +01:00
Marcel Hibbe
df5ac64712
fix to clear the status 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:11:37 +01:00
Marcel Hibbe
454c6cd8e6
add ability to send predefined and custom status 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:11:37 +01:00
Marcel Hibbe
8117c775a7
notifyDataSetChanged after predefines statuses were loaded 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:11:37 +01:00
Marcel Hibbe
57a408ac97
add predefined statuses 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:11:37 +01:00
Tim Krüger
a94f0f1bf1
Adopt more parts from files app [WIP] 
Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-02-25 12:11:36 +01:00
Marcel Hibbe
05586ccf47
add user status option to account dialog (WIP) 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-25 12:11:36 +01:00
Tim Krüger
3d76ba3571
Close localStream after peerConnection 
The peerConnection get passed the tracks of the localStream. So to make
sure that the tracks are not released before the connection is closed it
will now done after closing the peerConnection.

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-02-23 12:34:04 +01:00
Tim Krüger
f08a9ef463
Rename MagicPeerConnectionWrapper to PeerConnectionWrapper 
Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-02-23 12:21:41 +01:00
Tim Krüger
0ea29ee0cd
Remove unused fields remoteVideoOn and remoteAudioOn 
Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-02-23 12:21:41 +01:00
Tim Krüger
844cf09a2b
Rename remoteMediaStream to remoteStream 
Align naming to the names used in WebRTC example code and documentation.

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-02-23 11:36:42 +01:00
Tim Krüger
5580c15ea6
Rename magicDataChannel to dataChannel 
There is no 🧙 in a data channel.

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-02-23 11:36:42 +01:00
Tim Krüger
272ea7e846
Rename sdpConstraints to mediaConstraints 
SDP is a native detail of the native WebRTC library.

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-02-23 11:36:42 +01:00
Tim Krüger
890dda0c68
Remove unused method 'restartIce' 
The method 'restartIce' is dead code since years. So this and related
fields are removed.

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-02-23 11:36:42 +01:00
Tim Krüger
557602d1bf
Make fields final 
Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-02-23 11:36:42 +01:00
Tim Krüger
5e778c94fb
Make use of Objects#requireNonNull to check for null references 
Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-02-23 11:36:41 +01:00
Tim Krüger
5b95b5675d
Rename localMediaStream to localStream 
Align naming to the names used in WebRTC example code and documentation.

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-02-23 11:36:41 +01:00
Tim Krüger
86f20dcfd3
Migrate WebRTC from plan b to unified plan 
The in 'MagicPeerConnectionWrapper#removePeerConnection' used method
'PeerConnection#removeStream' was not longer available in the unified
plan. So to make sure that the local stream is disposed, it will now be
done in 'CallActivity#hangup'.

Resolves: #1773
See: [1]

[1] https://webrtc.org/getting-started/unified-plan-transition-guide
Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-02-23 11:36:41 +01:00
Tim Krüger
bad5b5f9bc
Update WebRTC library 
The  updated libwebrtc will be load from the talk-clients-webrtc repository [1]
and not from a dependency repository. The 'lint' task must now depend on the
'perBuild' task to make sure that the WebRTC library is downloaded from the
configured URL.

To get the new version to work a change is needed because of this announcement:

> Google is planning to transition Chrome’s WebRTC implementation from the
> current SDP format (called “Plan B”) to a standards conformant format
> (“Unified Plan”, draft-ietf-rtcweb-jsep) over the next couple of quarters.
>
> - [2]

Currently we are in phase 4 of the transition [3]. So actually 'Plan B'
must be used to avoid bigger changes to our code base at this time. But
'Plan B' is depracted and will be removed in phase 5 of the transition
[4].

Resolves: #1773
See:
  - [1] https://github.com/nextcloud-releases/talk-clients-webrtc
  - [2] https://webrtc.org/getting-started/unified-plan-transition-guide
  - [3] https://webrtc.org/getting-started/unified-plan-transition-guide#phase_4_make_%E2%80%9Cplan_b%E2%80%9D_throw
  - [4] https://webrtc.org/getting-started/unified-plan-transition-guide#phase_5_remove_%E2%80%9Cplan_b%E2%80%9D

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-02-23 11:34:30 +01:00
Tim Krüger
964367189f
Fix klint errors 
Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-02-21 17:17:47 +01:00
Tim Krüger
e49d014ec9
Remove Parceler from model capabilities 
Resolves: #1548

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-02-17 22:36:27 +01:00
Tim Krüger
dcc0a0fdd0
Remove Parceler from model autocomplete 
Resolves: #1548

Signed-off-by: Tim Krüger <t@timkrueger.me>
 2022-02-17 22:36:26 +01:00
Andy Scherzinger
b745e0677b
reformat kotlin 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-02-17 17:29:12 +01:00
Andy Scherzinger
7b64fbd7e0
spotbugs: checks the size of a collection against zero rather than using isEmpty() 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-02-17 17:23:46 +01:00
Andy Scherzinger
a18987dc0a
also show server address and placeholder avatar for account import 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-02-17 17:21:48 +01:00
Andy Scherzinger
43f57931fd
add empty lines for formatting 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-02-17 15:25:24 +01:00
Andy Scherzinger
ef4b08d752
convert switch account controller to kotlin 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-02-17 15:25:24 +01:00
Andy Scherzinger
377a983ac8
convert server selection controller to kotlin 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-02-17 15:25:21 +01:00
Marcel Hibbe
e1f8c41b60
fix to mark conversation as read 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-16 11:45:58 +01:00
Marcel Hibbe
0f6efabf38
avoid wildcard imports 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-16 11:34:11 +01:00
Marcel Hibbe
30b34adaf6
make ConversationOperationEnum imports static 
rename enums

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-16 11:34:11 +01:00
Marcel Hibbe
a22b93f363
fix to hide dialog automatically after 2,5 seconds 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-16 11:34:11 +01:00
Marcel Hibbe
73894bd4c0
fix to don't partly hide input dialogs behind keyboard 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-16 11:34:11 +01:00
Marcel Hibbe
2348919d97
modify copyright headers authors 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-16 11:34:10 +01:00
Marcel Hibbe
eceb545589
remove (hopefully unused) code regarding GUEST and USER_FOLLOWING_LINK 
I can't reproduce or think of scenarios when this code was used. because bottom dialog is replaced it wouldn't work anymore anyway.
If there appear scenarios when the code would have executed, it should be fixed similar like ConversationsListBottomDialog was implemented.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-16 11:34:10 +01:00
Andy Scherzinger
142c362474
solve detekt issues 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-02-16 11:34:09 +01:00
Marcel Hibbe
809e277855
rename enum, add todo 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-16 11:34:09 +01:00
Marcel Hibbe
8ea9663d5e
fix to fetch conversations list after executing bottom sheet operations 
BottomSheetLockEvent was only used for old bottom dialog with "kennyc" lib

instead ConversationsListFetchDataEvent.kt is now used to fetch the data in ConversationsListController whenever needed

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-16 11:34:09 +01:00
Marcel Hibbe
4728600021
fix to show searchbar after bottom dialog textinput 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-16 11:34:08 +01:00
Marcel Hibbe
6bc5d324b5
fix to show searchbar after bottom dialog operations 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-16 11:34:08 +01:00
Marcel Hibbe
4335e44701
replace operationCode's (int) by Enums 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-16 11:34:08 +01:00
Andy Scherzinger
66795bb48b
correct code formatting and license header added 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-02-16 11:34:07 +01:00
Andy Scherzinger
4fb61ed046
improve detekt score 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2022-02-16 11:34:07 +01:00
Marcel Hibbe
ea7575b266
remove dependency com.github.Kennyc1012:BottomSheet 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-16 11:34:06 +01:00
Marcel Hibbe
ac0c961557
open Conversation after being created via ContactsController 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-16 11:34:06 +01:00
Marcel Hibbe
dbf6b91260
rename ConversationOperationDialog to ConversationsListBottomDialog 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-16 11:34:06 +01:00
Marcel Hibbe
9423376ca7
tidy up 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
 2022-02-16 11:34:06 +01:00