Commit graph

9897 commits

Author SHA1 Message Date
Marcel Hibbe
94d62a943f
fix position and animation of typing indicator
Without this fix, typing indicator moves up and wont go down

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2024-09-27 16:51:45 +02:00
Julius Linus
246d496024
Merge pull request #4273 from nextcloud/fix-reminder-refactor
[Bug Fix] Fix wrong value when choosing custom reminder date
2024-09-27 09:45:30 -05:00
Sowjanya Kota
b0f0ef5c0c
Merge pull request #4281 from nextcloud/file_name_audio_recordings
fix file name of voice recording
2024-09-27 14:21:39 +02:00
sowjanyakch
de582f8b0b
use variable "VOICE_MESSAGE_PREFIX_MAX_LENGTH" to restrict length of voice recording file name
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
2024-09-27 12:41:36 +02:00
sowjanyakch
2478aa884b
put file length value in utils
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
2024-09-27 12:41:36 +02:00
sowjanyakch
ce8c4b2b84
fix file name of voice recording
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
2024-09-27 12:41:36 +02:00
Sowjanya Kota
f44885bd78
Merge pull request #4278 from nextcloud/set_empty_status_message
Set empty status message
2024-09-27 12:40:20 +02:00
sowjanyakch
25846fe23f
set default emoji only when status icon is null
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
2024-09-27 12:24:38 +02:00
sowjanyakch
1347ec29c4
Set empty status message and default emoji
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
2024-09-27 12:13:32 +02:00
Marcel Hibbe
cfd04e51c1
Merge pull request #4284 from nextcloud/bugfix/noid/addMissingReuseCopyright
add copyright header to fix reuse
2024-09-27 10:43:10 +02:00
Marcel Hibbe
78e738bd51
add copyright to fix reuse
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2024-09-27 09:37:42 +02:00
Nextcloud bot
ca747af78c
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-27 02:51:56 +00:00
github-actions[bot]
39c219c2be
Merge pull request #4283 from nextcloud/renovate/ubuntu-24.x
Update dependency ubuntu to v24
2024-09-26 23:29:17 +02:00
renovate[bot]
0c39083b35
Update dependency ubuntu to v24
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-09-26 21:22:11 +00:00
github-actions[bot]
0c172e6ada
Merge pull request #4282 from nextcloud/renovate/com.github.nextcloud.android-common-ui-0.x
Update dependency com.github.nextcloud.android-common:ui to v0.23.1
2024-09-26 20:23:23 +02:00
renovate[bot]
28bb0d7106
Update dependency com.github.nextcloud.android-common:ui to v0.23.1
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-09-26 15:16:35 +00:00
Marcel Hibbe
21bb71fba4
Merge pull request #4277 from nextcloud/bugfix/4272/fixToHandleOldServerVersions
Bugfix/4272/fix to handle old server versions
2024-09-26 13:34:21 +02:00
Marcel Hibbe
16c49bc430
bump versions for SERVER_VERSION_MIN_SUPPORTED + SERVER_VERSION_SUPPORT_WARNING
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2024-09-26 13:27:45 +02:00
Marcel Hibbe
ebc2fd2702
Add test for conversation conversion
This test respects different API versions and checks if default values are set as expected.

- remove deprecated+unused methods
- remove comments
- remove unnecessary double-bang operator

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2024-09-26 13:27:44 +02:00
Marcel Hibbe
0354501b41
Merge pull request #4259 from nextcloud/password_improvement
Password improvement
2024-09-26 13:16:36 +02:00
sowjanyakch
ebace8713a
Rounded corners for change password dialog
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
2024-09-26 13:13:57 +02:00
sowjanyakch
8c967c4f56
use open lock icon for set password
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
2024-09-26 13:13:56 +02:00
sowjanyakch
c165e9fe0c
UI improvements
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
2024-09-26 13:13:56 +02:00
sowjanyakch
31c0d74356
Add change password dialog
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
2024-09-26 13:13:56 +02:00
sowjanyakch
381804c892
Add Change Password dialogue
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
2024-09-26 13:13:56 +02:00
github-actions[bot]
454c829313
Merge pull request #4275 from nextcloud/renovate/actions-checkout-4.x
Update actions/checkout action to v4.2.0
2024-09-25 21:37:29 +02:00
renovate[bot]
eaae8b923d
Update actions/checkout action to v4.2.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-09-25 19:25:31 +00:00
parneet-guraya
856c0761c9
Fix logic for date time retrieval
Signed-off-by: parneet-guraya <gurayaparneet@gmail.com>
2024-09-25 22:04:11 +05:30
github-actions[bot]
a463e95f0b
Merge pull request #4270 from nextcloud/renovate/junit5-monorepo
Update dependency org.junit.vintage:junit-vintage-engine to v5.11.1
2024-09-25 10:30:28 +02:00
renovate[bot]
45d7969890
Update dependency org.junit.vintage:junit-vintage-engine to v5.11.1
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-09-25 07:53:51 +00:00
Sowjanya Kota
2592f72039
Merge pull request #4265 from nextcloud/bugfix/noid/fixCrashWhenExtSignalingEmpty
Fix crash when externalSignalingServer is empty
2024-09-25 09:48:56 +02:00
Nextcloud bot
b1cc652657
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-25 02:53:27 +00:00
github-actions[bot]
3ca515bf9a
Merge pull request #4267 from nextcloud/renovate/com.github.spotbugs.snom-spotbugs-gradle-plugin-6.x
Update dependency com.github.spotbugs.snom:spotbugs-gradle-plugin to v6.0.23
2024-09-25 04:08:45 +02:00
renovate[bot]
372fc3a0db
Update dependency com.github.spotbugs.snom:spotbugs-gradle-plugin to v6.0.23
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-09-25 02:03:28 +00:00
github-actions[bot]
419e9ac162
Merge pull request #4266 from nextcloud/renovate/github-codeql-action-3.x
Update github/codeql-action action to v3.26.9
2024-09-24 22:15:38 +02:00
renovate[bot]
8e9c152988
Update github/codeql-action action to v3.26.9
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-09-24 20:07:01 +00:00
github-actions[bot]
47ea807324
Merge pull request #4264 from nextcloud/renovate/actions-setup-java-4.x
Update actions/setup-java action to v4.4.0
2024-09-24 16:41:55 +02:00
Marcel Hibbe
7dc7051481
Fix crash when externalSignalingServer is empty
Otherwise, following crash happened, as it was tried to deal with the empty url:

2024-09-24 15:10:30.719 17765-17765 WebSocketInstance       com.nextcloud.talk2                  D  restartWebSocket: /spreed
2024-09-24 15:10:30.722 17765-17765 System.err              com.nextcloud.talk2                  W  java.lang.IllegalArgumentException: Expected URL scheme 'http' or 'https' but no scheme was found for /spree...
2024-09-24 15:10:30.723 17765-17765 System.err              com.nextcloud.talk2                  W  	at okhttp3.HttpUrl$Builder.parse$okhttp(HttpUrl.kt:1261)

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2024-09-24 16:25:33 +02:00
renovate[bot]
1302c85166
Update actions/setup-java action to v4.4.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-09-24 14:19:56 +00:00
Sowjanya Kota
c3270079b4
Merge pull request #4261 from nextcloud/bugfix/4190/avoidNpeCurrentConversation
try to avoid NPE for currentConversation
2024-09-24 16:19:01 +02:00
Marcel Hibbe
b78267d96f
try to avoid NPE for currentConversation
On gplay console the following NPE was reported for the line

participantPermissions = ParticipantPermissions(spreedCapabilities, currentConversation!!)

 E  FATAL EXCEPTION: main
          Process: com.nextcloud.talk2, PID: 6626
          java.lang.NullPointerException
          at com.nextcloud.talk.chat.ChatActivity.initObservers$lambda$13(ChatActivity.kt:583)
          at com.nextcloud.talk.chat.ChatActivity.$r8$lambda$QKH5JCFLmCzRMlSJ-EV-m4IW5ig(Unknown Source:0)

which seems that currentConversation was null. If it would have been spreedCapabilities, then the error would have been thrown in the line before..

A reason MAY BE that the observer is triggered before setData on the ViewModel is executed.
While this fix is just not executing code when currentConversation is null, it's unsure if it will follow up problems (like an empty chat) or if the observer is triggered another time when currentConversation is available.

So it's just a hotfix.
To improve the situation in the long term, we should move more logic to viewModel and only use Flow instead to mix it with LiveData.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2024-09-24 15:52:49 +02:00
Sowjanya Kota
68627ad752
Merge pull request #4263 from nextcloud/bugfix/4262/UninitializedPropertyAccessExceptionSpreedCapabilities
avoid UninitializedPropertyAccessException for spreedCapabilities
2024-09-24 15:47:37 +02:00
Marcel Hibbe
aeacfa09b6
avoid UninitializedPropertyAccessException for spreedCapabilities
reported issue on gplay console was:

Exception kotlin.UninitializedPropertyAccessException: lateinit property spreedCapabilities has not been initialized
  at com.nextcloud.talk.chat.ChatActivity.getSpreedCapabilities (ChatActivity.kt:284)
  at com.nextcloud.talk.chat.ChatActivity.processExpiredMessages (ChatActivity.kt:2536)
  at com.nextcloud.talk.chat.ChatActivity.access$processExpiredMessages (ChatActivity.kt:204)
  at com.nextcloud.talk.chat.ChatActivity$initObservers$10$1.invokeSuspend (ChatActivity.kt:820)

This is just a hotfix while hoping processExpiredMessages is executed again while spreedCapabilities are available.

To improve the situation in the long term, we should move more logic to viewModel and have better control over sequence of actions.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2024-09-24 15:25:42 +02:00
Marcel Hibbe
3d9d6942e4
Merge pull request #4256 from nextcloud/solve_static_code_warnings
Fix Codacy Warnings -  Ensure Composable Function Names Start with a Capital Letter
2024-09-24 14:26:03 +02:00
sowjanyakch
78a55c016f
change functionPattern to support composable functions and ktlintFormat
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
2024-09-24 13:43:30 +02:00
github-actions[bot]
715017d65f
Merge pull request #4260 from nextcloud/renovate/gradle-8.x
Update dependency gradle to v8.10.2
2024-09-24 01:00:38 +02:00
renovate[bot]
4f9122b685
Update dependency gradle to v8.10.2
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-09-23 22:55:13 +00:00
Marcel Hibbe
3b09da75a7
Merge pull request #4250 from nextcloud/conversation_creation_modification
Conversation creation modification
2024-09-23 16:44:59 +02:00
sowjanyakch
8bf9e3552e
rename variable selectedImageUri
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
2024-09-23 16:40:06 +02:00
sowjanyakch
384ba6945f
ktlint format
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
2024-09-23 16:40:06 +02:00