Commit graph

2871 commits

Author SHA1 Message Date
Andy Scherzinger
bc20e0438f
replace magic numbers with constants
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 23:20:55 +02:00
Andy Scherzinger
292bee8396
Swipe to reply for chat messages (incoming/outgoing/preview)
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 23:20:54 +02:00
Andy Scherzinger
9173bfbdaf
Merge pull request #1268 from nextcloud/viewBindingController
View binding controller implementation
2021-06-08 23:16:34 +02:00
Andy Scherzinger
4d8e70840c
Merge pull request #1305 from nextcloud/updatzeKlint
[no-ci] Update ktlint formatter + documenting update steps
2021-06-08 23:05:09 +02:00
Andy Scherzinger
b513d0f154
improve detekt score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:37:06 +02:00
Andy Scherzinger
e4da772882
ignore detekt for"Detekt.TooGenericExceptionCaught" in scenarios where we need to handle NPE explicitly
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:37:05 +02:00
Andy Scherzinger
40a08394bc
hardened view binding interaction
...in case of asynchronous UI interaction with already destroyed UI

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:37:02 +02:00
Andy Scherzinger
7b7eaa455d
binding isn't nullable
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:37:01 +02:00
Andy Scherzinger
ebc3dbdf79
improve readability of toolbar/searchbar handling code
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:58 +02:00
Andy Scherzinger
15d2c94d19
update code check scores
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:56 +02:00
Andy Scherzinger
266a9f73ee
add destruction check before accessing the binding object
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:53 +02:00
Andy Scherzinger
1ebc2bac24
lower detekt threshold based on latest improvements
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:50 +02:00
Andy Scherzinger
faf9ce2884
combine nested ifs
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:48 +02:00
Andy Scherzinger
46a18ca3a0
organize imports
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:45 +02:00
Andy Scherzinger
f8a8b81ef7
line length 1220 characters
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:43 +02:00
Andy Scherzinger
f4cfc9cef3
improve spotbugs
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:41 +02:00
Andy Scherzinger
cfe00937c5
comment unused, overridden methods and respect 120 character line length
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:39 +02:00
Andy Scherzinger
e7ea57bf85
reformat kotlin
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:37 +02:00
Andy Scherzinger
45a88c0722
replace menu switch statements with if/else
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:34 +02:00
Andy Scherzinger
3c0ef1d1e0
add linebreak
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:32 +02:00
Andy Scherzinger
63fabeda09
convert lock controller to kotlin
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:31 +02:00
Andy Scherzinger
7669108d38
add author infos
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:29 +02:00
Andy Scherzinger
85fe560fc1
reformat code for 120 line length
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:27 +02:00
Andy Scherzinger
14fc3c8146
move back to User java entity definition
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:26 +02:00
Andy Scherzinger
d372335d57
hardening chat controller by null-checking any UI access due to asynchronous UI accesses
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:24 +02:00
Andy Scherzinger
8d6b526576
use capabilities helper
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:22 +02:00
Andy Scherzinger
1134172faa
adapt to rebase
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:21 +02:00
Andy Scherzinger
e2c6fd7c25
migrate chat controller to native view binding
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:19 +02:00
Andy Scherzinger
0e92e5ea2d
code format kotlin code
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:18 +02:00
Andy Scherzinger
4784a22e18
update headers and format code
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:16 +02:00
Andy Scherzinger
ca8d6cb782
Move controller to new view binding utilizing logic
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:10 +02:00
Andy Scherzinger
d8d44c8404
update ktlint formatter + documenting update steps
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 10:38:05 +02:00
Nextcloud bot
0a72959b78
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-06-08 04:08:35 +00:00
Andy Scherzinger
3299565444
Merge pull request #1311 from nextcloud/dependabot/gradle/coilKtVersion-1.2.2
Bump coilKtVersion from 1.2.1 to 1.2.2
2021-06-07 23:03:23 +02:00
Nextcloud bot
fc6d08f024
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-06-07 04:04:51 +00:00
dependabot[bot]
c546fc16cb
Bump coilKtVersion from 1.2.1 to 1.2.2
Bumps `coilKtVersion` from 1.2.1 to 1.2.2.

Updates `coil` from 1.2.1 to 1.2.2
- [Release notes](https://github.com/coil-kt/coil/releases)
- [Changelog](https://github.com/coil-kt/coil/blob/main/CHANGELOG.md)
- [Commits](https://github.com/coil-kt/coil/compare/1.2.1...1.2.2)

Updates `coil-gif` from 1.2.1 to 1.2.2
- [Release notes](https://github.com/coil-kt/coil/releases)
- [Changelog](https://github.com/coil-kt/coil/blob/main/CHANGELOG.md)
- [Commits](https://github.com/coil-kt/coil/compare/1.2.1...1.2.2)

Updates `coil-svg` from 1.2.1 to 1.2.2
- [Release notes](https://github.com/coil-kt/coil/releases)
- [Changelog](https://github.com/coil-kt/coil/blob/main/CHANGELOG.md)
- [Commits](https://github.com/coil-kt/coil/compare/1.2.1...1.2.2)

---
updated-dependencies:
- dependency-name: io.coil-kt:coil
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: io.coil-kt:coil-gif
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: io.coil-kt:coil-svg
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-06-07 01:05:08 +00:00
Nextcloud bot
f65bc5ae46
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-06-06 04:05:52 +00:00
Nextcloud bot
548c65a98e
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-06-05 04:08:40 +00:00
Andy Scherzinger
670922bc5c
Merge pull request #1310 from nextcloud/dependabot/gradle/org.mockito-mockito-core-3.11.0
Bump mockito-core from 3.10.0 to 3.11.0
2021-06-04 14:53:37 +02:00
Nextcloud bot
86d691826c
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-06-04 04:13:49 +00:00
dependabot[bot]
2d5d3f3d08
Bump mockito-core from 3.10.0 to 3.11.0
Bumps [mockito-core](https://github.com/mockito/mockito) from 3.10.0 to 3.11.0.
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](https://github.com/mockito/mockito/compare/v3.10.0...v3.11.0)

---
updated-dependencies:
- dependency-name: org.mockito:mockito-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-06-04 01:04:41 +00:00
Nextcloud bot
85961da9ae
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-06-03 04:10:51 +00:00
Nextcloud bot
25ca3e3ced
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-06-02 08:40:35 +00:00
Andy Scherzinger
715eea917f
Merge pull request #1304 from nextcloud/improvePreviews
Improve Preview Screens
2021-06-01 10:36:11 +02:00
Andy Scherzinger
ac936114ef
Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-31 17:21:36 +02:00
Andy Scherzinger
cd5f083a49
make text preview dark/light aware, overall improvement of preview screens
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-31 15:29:00 +02:00
Andy Scherzinger
a092f30d56
Merge pull request #1303 from nextcloud/bugfix/1274/preventTextSelection
Prevent text selection on messages
2021-05-31 13:53:55 +02:00
Andy Scherzinger
44533b889c
prevent text selection on messages
Resolves #1274

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-31 11:34:36 +02:00
Andy Scherzinger
563f476b35
Merge pull request #1302 from nextcloud/fixupBot
Block fixup and squash commits
2021-05-31 11:05:58 +02:00
Andy Scherzinger
d7fc6f90a4
Block fixup and squash commits
original by https://github.com/skjnldsv

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-31 09:50:27 +02:00