Commit graph

3411 commits

Author SHA1 Message Date
Marcel Hibbe
23883c582c
Merge pull request #1114 from nextcloud/fix-own-peer-handling-when-hpb-is-used
Fix own peer handling when HPB is used
2021-07-02 15:16:03 +02:00
Daniel Calviño Sánchez
6087167d6e
Simplify condition
Now that "newSessions" only contains remote participants it is no longer
needed to check if the participant is an MCU publisher or not, as it
will never be.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-07-02 14:59:05 +02:00
Daniel Calviño Sánchez
9687a9453d
Fix treating the local session as a remote session when the HPB is used
When processing the participants in a room the signaling sessions of the
participants were compared against the Nextcloud session of the local
participant to find out which were the remote sessions. However, when
the HPB is used the signaling session is not the same as the Nextcloud
session, so the signaling session of the local participant never matched
her Nextcloud session, so it was always seen as a remote participant.

This caused the call state to be changed to "in conversation" (which,
for example, stopped the calling sound), when only the local participant
was in the call.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-07-02 14:59:05 +02:00
Daniel Calviño Sánchez
004c7b296a
Move "hasMCU" update to the top of the method
"hasMCU" was used before being updated, so this caused an unneeded call
to "getPeersForCall" when processing the users in the room for the first
time even if the MCU is actually used.

A better fix might be moving "hasMCU" to a method instead of relying on
the cached value, but just moving the update to the top of the method
should have no side effects (as calling "getPeersForCall" just updates
"participantMap", which is unused when the MCU is used, and sets the
avatars, which has no effect until the peer layout is set, which also
sets the avatar), so this is good enough for now.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-07-02 14:59:05 +02:00
Marcel Hibbe
8adfb7c2cd
Merge pull request #1387 from nextcloud/bugfix/1308/improveGridViewDesign
Bugfix/1308/improve grid view design
2021-07-02 14:56:33 +02:00
Andy Scherzinger
d1d81b947f
reformat code and use app-defined color-white
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-07-02 14:36:05 +02:00
drone
61fd18a0ca Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <noreply@drone>
2021-07-02 12:12:55 +00:00
Marcel Hibbe
c07ef4acc8
define call controls height in dimens.xml
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-07-02 13:23:46 +02:00
Marcel Hibbe
47f535fdc9
limit text length of participant name
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-07-02 13:23:46 +02:00
Marcel Hibbe
99b247850b
set minHeight for call item by dp
reduce number of possible columns to avoid design issues

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-07-02 13:23:46 +02:00
Marcel Hibbe
8e8fd882f9
return false for ridView.setOnTouchListener
NOT TESTED

should allow both click and scrolling?

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-07-02 13:23:46 +02:00
Marcel Hibbe
98f8a29eae
set constants for min item height and call controls height
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-07-02 13:23:46 +02:00
Marcel Hibbe
64d98aefb4
- set bottom margin for grid for voicecall
- temporarily comment out setOnTouchListener for grid (disables toggle of controls for now)
- set android:scrollbars="vertical" for gridview
- add callControlsHeight for item height calculation
- add fake height to item that scrolling is testable

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-07-02 13:23:46 +02:00
Andy Scherzinger
7874aa713f
Merge pull request #1383 from nextcloud/dependabot/gradle/androidx.test.espresso-espresso-core-3.4.0
Bump espresso-core from 3.3.0 to 3.4.0
2021-07-01 14:08:51 +02:00
Andy Scherzinger
3cf20258b9
Merge pull request #1380 from nextcloud/feature/noid/shortenedLaucherLabel
Shortened launcher label
2021-07-01 10:58:30 +02:00
dependabot[bot]
e10f77a61f
Bump espresso-core from 3.3.0 to 3.4.0
Bumps espresso-core from 3.3.0 to 3.4.0.

---
updated-dependencies:
- dependency-name: androidx.test.espresso:espresso-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-07-01 01:06:09 +00:00
Andy Scherzinger
394a640555
shorten app label Nextcloud Talk -> Talk while keeping "Nextcloud Talk" as a label within the app itself
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 18:07:54 +02:00
Andy Scherzinger
e1a2d5f098
Merge pull request #1370 from nextcloud/bugfix/1233/checkViewNotNull
Check if view is (still) available
2021-06-30 17:35:49 +02:00
Andy Scherzinger
996770e470
check if view is (still) available
...since grid initialization is called in various places throughout the lifecycle

Fixes #1233

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 16:54:57 +02:00
Andy Scherzinger
e9fb3eda84
Merge pull request #1369 from nextcloud/a11y-contrastBubble-HitBoxSize
Improve Chat Accessibility
2021-06-30 16:48:41 +02:00
Andy Scherzinger
60def3cc0c
optimize message input for size+a11y
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 15:53:30 +02:00
Andy Scherzinger
9a4d7b78a2
a11y - raise hitbox of icons to 48dp
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 15:53:29 +02:00
Andy Scherzinger
9c9d2f8a8f
a11y - raise contrast text/bubble in dark mode
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 15:53:24 +02:00
Marcel Hibbe
8955015159
Merge pull request #1377 from nextcloud/bugfix/1013/stopLogFlooding
temporarily disable logging to file
2021-06-30 15:10:19 +02:00
drone
1b71fd39c3 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <noreply@drone>
2021-06-30 13:07:09 +00:00
Marcel Hibbe
bebf716da7
temporarily disable logging to file
see issue
https://github.com/nextcloud/talk-android/issues/1376

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-30 14:24:53 +02:00
Andy Scherzinger
b989c62055
Merge pull request #1373 from nextcloud/bugfix/1343/stopVoiceMessage
Bugfix/1343/stop voice message
2021-06-30 13:53:13 +02:00
Andy Scherzinger
60d14f3b35
SuppressLint("SetTextI18n")
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 13:44:00 +02:00
Andy Scherzinger
d37783d7a0
fix ktlint
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 13:38:48 +02:00
Andy Scherzinger
3e57018615
remove unused member variables
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 13:12:15 +02:00
Andy Scherzinger
195bdfb05a
extract visibility toggle for play/pause Vs. loading-animation
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 13:03:17 +02:00
Andy Scherzinger
86d3501553
use stable release of popup bubble lib
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 13:03:16 +02:00
Andy Scherzinger
78cc0df7bd
spotbugs: use literal as comparison base
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 13:03:14 +02:00
Andy Scherzinger
7bca54373f
Improve ktlint
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 13:02:57 +02:00
Andy Scherzinger
a393685a63
else/if rather than if/if
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 13:01:32 +02:00
Andy Scherzinger
5b457a67cb
remove unused member variable
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 13:01:31 +02:00
Andy Scherzinger
f435646b23
Add license header 2021-06-30 13:01:26 +02:00
Andy Scherzinger
40d76c6436
Merge pull request #1372 from nextcloud/bugfix/1371/hardenTitleCalculation
Harden Chat Title Calculation
2021-06-30 00:03:01 +02:00
Marcel Hibbe
6fc83bbca0
fix klint warnings
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-29 23:09:39 +02:00
Marcel Hibbe
741748137a
fix lint/spotbugs warnings
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-29 22:49:33 +02:00
Marcel Hibbe
c7bb6402fe
stop mediaPlayer in onDestroy
a voice message now continues to play if app goes to background, but whenever the user returns he can pause or stop the playback (UI is updated).
Also, the playback survives a screen orientation change.

instead stopping the mediaPlayer in onDetach would stop playback when moving app to background but also stop the playback on a screen orientation change.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-29 22:49:33 +02:00
Marcel Hibbe
6be66fdcff
fix voicemessage design for landscape mode
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-29 22:49:33 +02:00
Marcel Hibbe
e34443f0a3
fix spinner color for outgoing voice messages
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-29 22:49:33 +02:00
Marcel Hibbe
d47deb42c8
move mediaPlayer and download-logic for voicemessages to ChatController
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-29 22:49:33 +02:00
Andy Scherzinger
3514d6b3fc
Catch IllegalStateException in case EmojiCompat hasn't been initialized yet
Fixes #1371

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-29 13:00:32 +02:00
John Molakvoæ
f9449db82a
Merge pull request #1366 from nextcloud/feat/workflow-auto-update
Updating command-rebase.yml workflow from template
2021-06-29 11:08:44 +02:00
Marcel Hibbe
3c75830e60
Merge pull request #1364 from nextcloud/conversationIcons
Add dark/light aware high-res conversation icons
2021-06-29 10:00:15 +02:00
Andy Scherzinger
394797405f
Merge pull request #1365 from nextcloud/feature/noid/chatLoadingShimmer
Add shimmer for chat content loading
2021-06-29 09:54:45 +02:00
skjnldsv
c65a225f76 Updating command-rebase.yml workflow from template
Signed-off-by: GitHub <noreply@github.com>
2021-06-29 07:47:06 +00:00
Andy Scherzinger
73d4674bda
Add shimmer for chat content loading
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-28 23:54:40 +02:00