Commit graph

4814 commits

Author SHA1 Message Date
Andy Scherzinger
cd638591ea
Merge pull request #2007 from nextcloud/bugfix/2004/hideActionsReactionOnDeletedMessages
Hide actions reaction on deleted messages
2022-05-09 17:44:11 +02:00
Andy Scherzinger
b84589a831
improve detekt score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-05-09 16:51:05 +02:00
Andy Scherzinger
5a76f3a3d3
extract checks to separate methods
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-05-09 16:46:16 +02:00
Andy Scherzinger
c3dd263b3f
proper kotlin code formatting
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-05-09 16:36:38 +02:00
Andy Scherzinger
cbad775669
extract react-able message type check
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-05-09 16:36:38 +02:00
Andy Scherzinger
44d47bf74c
hide forward action on deleted messages
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-05-09 16:36:38 +02:00
Andy Scherzinger
5afb4b68cf
extract UI build logic blocks
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-05-09 16:36:37 +02:00
Andy Scherzinger
649d8831ac
hide reactions on deleted and command messages
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-05-09 16:36:34 +02:00
Andy Scherzinger
973d13f902
Merge pull request #2005 from nextcloud/bugfix/1978/fixNPEpeerConnectionWrapper
Bugfix/1978/fix npe in peerConnectionWrapper
2022-05-09 15:31:59 +02:00
Andy Scherzinger
a5db665571
Merge pull request #2006 from nextcloud/bugfix/1977/fixNPEinBrowserFile
Bugfix/1977/fix NPE in BrowserFile
2022-05-09 15:31:05 +02:00
Marcel Hibbe
d88c01367c
fix NPE #1977
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-05-09 13:19:46 +02:00
Marcel Hibbe
a1c5e942cd
reformat code
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-05-09 13:15:11 +02:00
Marcel Hibbe
a43a51b931
try to fix #1978
i suspect that peerConnectionFactory could have been null because e.g. "hangup()" was already called which sets it to null. Because of some async task getOrCreatePeerConnectionWrapperForSessionIdAndType might still be called afterwards and it failed because peerConnectionFactory was already null.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-05-09 13:00:01 +02:00
Marcel Hibbe
4414002b8a
reformat code
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-05-09 12:44:51 +02:00
Nextcloud Android Bot
470dbe89c2 Weekly 14.1.0 Alpha 05 2022-05-09 03:14:25 +00:00
Nextcloud bot
54c87b7ee2
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-08 04:15:13 +00:00
Andy Scherzinger
4c199b1369
Merge pull request #1922 from nextcloud/bugfix/noid/kotlinConversion5
Migrate OperationsMenuController to kotlin
2022-05-07 13:29:04 +02:00
Tim Krüger
370c51ec2d Use 'lateinit' for injected properties
Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-05-07 11:21:29 +00:00
Tim Krüger
f9020dbc2b Reduce number of Detekt issues
Reduce the number of Detekt issues for the 'OperationsMenuController' by
splitting the function 'processOperation' into smaller pieces. But in
the end it is not enough, because also the now short function
'processOperation' is too complex for Detekt. Because of that the
suppress annotation is set.

Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-05-07 11:21:29 +00:00
drone
e4b5fd2867 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-05-07 11:21:29 +00:00
drone
09de19c1cd Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-05-07 11:21:29 +00:00
Andy Scherzinger
aebebe5410 Migrate OperationsMenuController to kotlin
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-05-07 11:21:29 +00:00
Andy Scherzinger
0c5429bd7b
Merge pull request #2001 from nextcloud/bugfux/1975/fixNPEforMimetype
make attributes of file nullable and handle null values
2022-05-07 12:54:56 +02:00
Andy Scherzinger
0de1e6e44d
Merge pull request #2002 from nextcloud/bugfix/1976/fixNPE
avoid NPE
2022-05-07 12:49:42 +02:00
Nextcloud bot
e8fe758b6c
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-07 04:12:59 +00:00
Marcel Hibbe
59f1f003ca
avoid NPE
trying to avoid #1976

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-05-06 23:48:44 +02:00
Marcel Hibbe
a5f7ecc5d8
make attributes of file nullable and handle null values
nullable attributes of files can be found at https://github.com/nextcloud/server/blob/master/lib/public/RichObjectStrings/Definitions.php#L303-L351

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-05-06 23:21:10 +02:00
Andy Scherzinger
bddbf48198
Merge pull request #1998 from nextcloud/bugfix/1974/fixViewBindingNPE
fix NPE for viewbinding
2022-05-06 16:03:32 +02:00
Marcel Hibbe
30f65424a5
fix NPE for viewbinding
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-05-06 14:58:30 +02:00
Andy Scherzinger
aa38df61be
Merge pull request #1997 from nextcloud/changelog
Changelog 14.0.1 / 14.0.0
2022-05-06 14:54:31 +02:00
Andy Scherzinger
0db9c4240f
Changelog 14.0.1
Changelog 14.0.0

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-05-06 14:53:45 +02:00
Andy Scherzinger
6cdce6db50
Merge pull request #1928 from nextcloud/bugfix/noid/removeButterknife
remove unused butterknife binding
2022-05-06 14:39:55 +02:00
Andy Scherzinger
fafbcbd1cd
Merge pull request #1957 from nextcloud/bugfix/1956/hideReactionsForReadOnlyConversations
Hide reactions from menu if conversation is read-only
2022-05-06 14:38:15 +02:00
Andy Scherzinger
7140f184cb
Merge pull request #1950 from nextcloud/feature/noid/hideToolbarOnScroll
Hide shared items toolbar on scroll
2022-05-06 14:37:25 +02:00
Andy Scherzinger
41a00f43ac
Merge pull request #1989 from nextcloud/bugfix/1983/alwaysShowCount
Always show reaction count
2022-05-06 14:33:25 +02:00
Nextcloud bot
edd0ba1335
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-06 04:14:54 +00:00
Andy Scherzinger
8f654937de
Always show reaction count
Resolves #1983

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-05-05 22:51:20 +02:00
Tim Krueger
0a091ca1cf
Merge pull request #1969 from nextcloud/bugfix/noid/remove-old-screenshots-from-fdroid
Add old screenshot from F-Droid
2022-05-05 17:34:57 +02:00
Tim Krueger
ac76fd8bc9
Merge pull request #1979 from nextcloud/bugfix/1881/handling-for-event-participants-update-all-from-hpb
Add handling for "event.participants.update.all"
2022-05-05 15:47:07 +02:00
drone
3213bfaea9
Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2022-05-05 15:31:37 +02:00
drone
be1b075234 Merge commit 'e52b2d8b7ffbad4e4343bb6b97d40663ddc58149' 2022-05-05 11:06:39 +00:00
Tim Krüger
e52b2d8b7f
Add null checks and extract constants
Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-05-05 13:06:15 +02:00
Nextcloud bot
8408f5f657
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-05 04:15:50 +00:00
Tim Krüger
92943af01a
Add old screenshot from F-Droid
In the F-Droid store screenshots can only be added or updated. So to get
rid of the old screenshots a 1x1px version is added. After the next
release to the F-Droid store they can be deleted. From that point on
existing screenshots should only be updated!

See: https://gitlab.com/fdroid/fdroidserver/-/issues/490

Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-05-04 13:54:34 +02:00
Tim Krueger
04abd84d52
Merge pull request #1973 from nextcloud/bugfix/noid/reduce-number-of-detekt-issues
Reduce number of Detekt issues
2022-05-04 13:53:35 +02:00
Tim Krüger
4f5a344a20
Add handling for "event.participants.update.all"
In case a moderator of a restricted room ends the call for all
participants a update participants event with the field 'all=true' will
be thrown by the HPB.

    {
      "type": "event"
      "event": {
        "target": "participants",
        "type": "update",
        "update": [
          "roomid": "the-room-id",
          "incall": new-incall-state,
          "all": true
        ]
      }
    }

In that case the call can be ended directly without handling every
single participant.

Resolves: #1881

Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-05-04 13:49:04 +02:00
Tim Krüger
0c1303e0af
Fix Detekt issues in LocationPickerController
- LongMethod - 94/60 - [initMap]
- ComplexMethod - 15/10 - [initMap]
- ReturnCount - [areAllGranted]

Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-05-04 11:30:17 +02:00
Tim Krüger
377e171156
Fix Detekt issues in ChatUtils
- ComplexMethod - 11/10 - [getParsedMessage]
- NestedBlockDepth - 4/4 - [getParsedMessage]

Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-05-04 11:30:06 +02:00
Andy Scherzinger
14841a99eb
Merge pull request #1970 from nextcloud/dependabot/gradle/org.jlleitschuh.gradle-ktlint-gradle-10.3.0
Bump ktlint-gradle from 10.2.1 to 10.3.0
2022-05-04 09:48:46 +02:00
Tim Krüger
8febcdf8d8
Replace deprecated Detekt configuration options
Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-05-04 09:18:18 +02:00