Commit graph

1816 commits

Author SHA1 Message Date
Marcel Hibbe
27bbb399be catch FileNotFoundException in copyFileToCache
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-07-09 18:35:47 +00:00
Joas Schilling
976ca95959
Merge pull request #1442 from nextcloud/bugfix/1429/fix-capability-check-for-14-to-18
Fix capability check for 14-18
2021-07-09 20:24:07 +02:00
Joas Schilling
4f94d7f96c
Fix capability check for 14-18
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-07-09 19:45:05 +02:00
Andy Scherzinger
f8ae4ca8a3
Merge pull request #1420 from nextcloud/bugfix/1417/botSystemConversationIcon
Use launcher icon as bot-avatar/system-conversation-icon
2021-07-09 16:28:33 +02:00
Andy Scherzinger
1333ce768a
Merge pull request #1425 from nextcloud/bugfix/1424/conversationInfoViewBindingNPE
Binding can be null due to async call
2021-07-09 11:30:18 +02:00
Andy Scherzinger
c47a686db1
replace printStackTrace with Log-statement
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-07-09 10:54:39 +02:00
Andy Scherzinger
324cd95f43
binding can be null do to async call
Fixes #1424

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-07-08 23:58:34 +02:00
Andy Scherzinger
e1962883b0
Only parse baseURl if not empty
Fixes #1422

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-07-08 14:49:59 +02:00
Andy Scherzinger
5e88dc6f57
Use launcher icon as bot-avatar/system-conversation-icon on pre-Android O
Fixes #1417

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-07-08 14:31:12 +02:00
Marcel Hibbe
e721aa5df6
fix to expand attachment menu in landscape mode
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-07-05 14:57:11 +02:00
Marcel Hibbe
83001990b0
set locationName to "Shared location" when geocoding failed
e.g. when someone shares a location from the ocean the name is not "null" anymore

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-07-05 13:03:18 +02:00
Daniel Calviño Sánchez
6087167d6e
Simplify condition
Now that "newSessions" only contains remote participants it is no longer
needed to check if the participant is an MCU publisher or not, as it
will never be.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-07-02 14:59:05 +02:00
Daniel Calviño Sánchez
9687a9453d
Fix treating the local session as a remote session when the HPB is used
When processing the participants in a room the signaling sessions of the
participants were compared against the Nextcloud session of the local
participant to find out which were the remote sessions. However, when
the HPB is used the signaling session is not the same as the Nextcloud
session, so the signaling session of the local participant never matched
her Nextcloud session, so it was always seen as a remote participant.

This caused the call state to be changed to "in conversation" (which,
for example, stopped the calling sound), when only the local participant
was in the call.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-07-02 14:59:05 +02:00
Daniel Calviño Sánchez
004c7b296a
Move "hasMCU" update to the top of the method
"hasMCU" was used before being updated, so this caused an unneeded call
to "getPeersForCall" when processing the users in the room for the first
time even if the MCU is actually used.

A better fix might be moving "hasMCU" to a method instead of relying on
the cached value, but just moving the update to the top of the method
should have no side effects (as calling "getPeersForCall" just updates
"participantMap", which is unused when the MCU is used, and sets the
avatars, which has no effect until the peer layout is set, which also
sets the avatar), so this is good enough for now.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-07-02 14:59:05 +02:00
Marcel Hibbe
c07ef4acc8
define call controls height in dimens.xml
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-07-02 13:23:46 +02:00
Marcel Hibbe
99b247850b
set minHeight for call item by dp
reduce number of possible columns to avoid design issues

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-07-02 13:23:46 +02:00
Marcel Hibbe
8e8fd882f9
return false for ridView.setOnTouchListener
NOT TESTED

should allow both click and scrolling?

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-07-02 13:23:46 +02:00
Marcel Hibbe
98f8a29eae
set constants for min item height and call controls height
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-07-02 13:23:46 +02:00
Marcel Hibbe
64d98aefb4
- set bottom margin for grid for voicecall
- temporarily comment out setOnTouchListener for grid (disables toggle of controls for now)
- set android:scrollbars="vertical" for gridview
- add callControlsHeight for item height calculation
- add fake height to item that scrolling is testable

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-07-02 13:23:46 +02:00
Andy Scherzinger
394a640555
shorten app label Nextcloud Talk -> Talk while keeping "Nextcloud Talk" as a label within the app itself
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 18:07:54 +02:00
Andy Scherzinger
996770e470
check if view is (still) available
...since grid initialization is called in various places throughout the lifecycle

Fixes #1233

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 16:54:57 +02:00
Andy Scherzinger
60def3cc0c
optimize message input for size+a11y
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 15:53:30 +02:00
Marcel Hibbe
bebf716da7
temporarily disable logging to file
see issue
https://github.com/nextcloud/talk-android/issues/1376

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-30 14:24:53 +02:00
Andy Scherzinger
b989c62055
Merge pull request #1373 from nextcloud/bugfix/1343/stopVoiceMessage
Bugfix/1343/stop voice message
2021-06-30 13:53:13 +02:00
Andy Scherzinger
60d14f3b35
SuppressLint("SetTextI18n")
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 13:44:00 +02:00
Andy Scherzinger
d37783d7a0
fix ktlint
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 13:38:48 +02:00
Andy Scherzinger
3e57018615
remove unused member variables
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 13:12:15 +02:00
Andy Scherzinger
195bdfb05a
extract visibility toggle for play/pause Vs. loading-animation
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 13:03:17 +02:00
Andy Scherzinger
78cc0df7bd
spotbugs: use literal as comparison base
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 13:03:14 +02:00
Andy Scherzinger
7bca54373f
Improve ktlint
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 13:02:57 +02:00
Andy Scherzinger
a393685a63
else/if rather than if/if
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 13:01:32 +02:00
Andy Scherzinger
5b457a67cb
remove unused member variable
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-30 13:01:31 +02:00
Andy Scherzinger
f435646b23
Add license header 2021-06-30 13:01:26 +02:00
Marcel Hibbe
6fc83bbca0
fix klint warnings
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-29 23:09:39 +02:00
Marcel Hibbe
741748137a
fix lint/spotbugs warnings
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-29 22:49:33 +02:00
Marcel Hibbe
c7bb6402fe
stop mediaPlayer in onDestroy
a voice message now continues to play if app goes to background, but whenever the user returns he can pause or stop the playback (UI is updated).
Also, the playback survives a screen orientation change.

instead stopping the mediaPlayer in onDetach would stop playback when moving app to background but also stop the playback on a screen orientation change.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-29 22:49:33 +02:00
Marcel Hibbe
d47deb42c8
move mediaPlayer and download-logic for voicemessages to ChatController
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-29 22:49:33 +02:00
Andy Scherzinger
3514d6b3fc
Catch IllegalStateException in case EmojiCompat hasn't been initialized yet
Fixes #1371

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-29 13:00:32 +02:00
Andy Scherzinger
c4057b7ac4
Add dark/light aware high-res conversation icons for share:password and document
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-28 23:09:18 +02:00
Andy Scherzinger
0b49b65094
check if attendeePin exists
resolves #1314

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-24 16:27:51 +02:00
Joas Schilling
9411614175
Show the bridge-bot avatar for bridged messages
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-06-23 10:13:20 +02:00
Joas Schilling
c2125f9a81
Always fallback to the guest avatar instead of none
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-06-23 10:12:58 +02:00
Joas Schilling
7e1cc872bd
Add tracking circles support
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-06-22 11:40:40 +02:00
Andy Scherzinger
2db4cbf4d1
reformat kotlin
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-22 11:18:07 +02:00
Andy Scherzinger
fc0962780c
improve lint score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-22 11:18:07 +02:00
Andy Scherzinger
4ebc64de1c
improve codacy score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-22 11:18:06 +02:00
Andy Scherzinger
2cf5952fae
bump detekt score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-22 11:18:05 +02:00
Andy Scherzinger
2b71d30637
reformat kotlin
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-22 11:18:04 +02:00
Andy Scherzinger
19dcd8267a
replace deprecated method calls
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-22 11:18:02 +02:00
Andy Scherzinger
db68b4e93d
improve voice message UI
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-22 11:18:02 +02:00
Marcel Hibbe
7709967712
fix imports
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-22 11:18:00 +02:00
Joas Schilling
9fbf9ef492
add voice messages
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-22 11:17:59 +02:00
Andy Scherzinger
df6b0980ac
improve contacts preview UI
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-21 17:35:05 +02:00
Joas Schilling
b9893e031c
Show "contact-name" and "contact-photo" when applicable
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-06-21 17:35:04 +02:00
Marcel Hibbe
0e66d75b7d
improve handling for missing location permissions
add fallback to gps if no NETWORK_PROVIDER was found

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-21 13:14:38 +02:00
Andy Scherzinger
dd162e8c61
@Suppress("Detekt.TooGenericExceptionCaught")
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 16:38:52 +02:00
Andy Scherzinger
005dfa9397
prevent crash on async callback
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 15:29:26 +02:00
Andy Scherzinger
57ddb317fd
hide icon on location picker
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 15:16:45 +02:00
Andy Scherzinger
cedc54dbb6
Improve codacy
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 12:53:27 +02:00
Andy Scherzinger
fb04505663
reformat kotlin
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:59:11 +02:00
Andy Scherzinger
f242b5fcec
hide deletion action ob object_share messages popup menu
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:55:32 +02:00
Marcel Hibbe
80e1bc6505
add ACCESS_COARSE_LOCATION for LocationPickerController
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:51:30 +02:00
Andy Scherzinger
f52d7f29d9
replace nominatimClient with copied/pacthes version replacing legacy httpClient with okhttp3
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:58 +02:00
Andy Scherzinger
ba64d693ef
further codacy improvements
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:56 +02:00
Andy Scherzinger
03fda89a22
reformat kotlin
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:55 +02:00
Andy Scherzinger
a8368e626e
improve codacy score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:52 +02:00
Andy Scherzinger
01a552b8d3
reformat code for ktlint compliance
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:47 +02:00
Andy Scherzinger
f899ee1d2f
make httpclient compileOnly since it ships with the OS
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:46 +02:00
Andy Scherzinger
6ba541b6b1
Move message holders to native view bindings
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:44 +02:00
Andy Scherzinger
71bffc0ea8
suppress generic exception handling warnings
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:42 +02:00
Andy Scherzinger
3c4714f716
fix after rebase
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:39 +02:00
Andy Scherzinger
ac986c61aa
cleanup to new base controller logic
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:36 +02:00
Andy Scherzinger
73e0b4e719
polish location map and move to native view bindings
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:34 +02:00
Andy Scherzinger
9f8a98ba07
remove unused imports
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:32 +02:00
Andy Scherzinger
adda60c7fb
Use native view bindings for GeocodingController
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:30 +02:00
Andy Scherzinger
43bf2ca7ae
use right context to be day/night theme aware
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-11 10:22:27 +02:00
Marcel Hibbe
94e466598e
add copyright headers
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:26 +02:00
Marcel Hibbe
4cdd13c92e
use CapabilitiesUtil for geo-location-sharing
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:23 +02:00
Marcel Hibbe
0568ea6e72
update location when gps changed
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:21 +02:00
Marcel Hibbe
751cd1268e
replace current-position icon
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:19 +02:00
Marcel Hibbe
22333d2f57
disable text fields for location messages (workaround)
i tried to suppress that zip codes are shown as clickable telephopne numbers. but
  android:autoLink="none"
and
  messageText!!.linksClickable = false
don't seem to work.
as a workaround i disabled the text field completely. so the links are still underlined but nut clickable. and it's also not possible now to mark text and get the context menu.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:18 +02:00
Marcel Hibbe
3cb0fe75b1
remove unnecessary logic from LocationMessageViewHolders
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:16 +02:00
Marcel Hibbe
4190cf1dfe
add FLAG_ACTIVITY_NEW_TASK for incoming location message
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:14 +02:00
Marcel Hibbe
2154b6cf94
improve design of share location button / location description
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:12 +02:00
Marcel Hibbe
9ffd5a7579
hide location sharing when capability is missing
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:09 +02:00
Marcel Hibbe
d4e49a20bb
decrease lint warnings
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:06 +02:00
Marcel Hibbe
fdf6b04fb8
decrease spotbugs warnings
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:22:02 +02:00
Marcel Hibbe
60827afe5c
decrease lint warnings
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:59 +02:00
Marcel Hibbe
ffdc630b76
avoid UNSAFE_HASH_EQUALS reported by SpotBugs
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:58 +02:00
Marcel Hibbe
ab63a1970b
extract hardcodings
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:56 +02:00
Marcel Hibbe
49b2455a23
reverse-geocode before sharing if address-name is empty
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:54 +02:00
Marcel Hibbe
d7a8935709
show geocoded location on map before sharing
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:53 +02:00
Marcel Hibbe
96e5e544ea
share geocoding-result on click
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:51 +02:00
Marcel Hibbe
26ae4fa548
share geocoded location
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:50 +02:00
Marcel Hibbe
2f0105abd3
add location search with nominatim
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:49 +02:00
Marcel Hibbe
d5face5941
improve design for locationpicker screen
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:47 +02:00
Marcel Hibbe
e8a9fa6303
add "...sent a location" strings for Conversation list
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:46 +02:00
Marcel Hibbe
095c13172c
share location to chat by button click
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:44 +02:00
Marcel Hibbe
ae485d1d80
delete example activity for leaflet
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:43 +02:00
Marcel Hibbe
1aa15ebd95
differ between incoming and outcoming messages for location
logic was copied from:
- MagicIncomingTextMessageViewHolder.kt
- MagicOutcomingTextMessageViewHolder.kt

xml design was copied from:
- item_custom_incoming_text_message.xml
- item_custom_outcoming_text_message.xml

... and extended for location related things.

because of copying there is now quite a lot of redundant code! But ViewHolders should generally be refactored in the future.. (better inheritance(?) and analyze which of Marios changes to the Chatkit lib were really necessary or if this can be done in an other way..)

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:42 +02:00
Marcel Hibbe
7540e57dd8
open geolink on click + minor refactoring
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:40 +02:00
Marcel Hibbe
04fb57df7a
pass java to javascript params with URLEncoder
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:39 +02:00
Marcel Hibbe
5da43d1760
wip. show leaflet inside webview in message
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:37 +02:00
Marcel Hibbe
ba7bfe3150
chnage LocationMessageViewHolder to kotlin
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:36 +02:00
Marcel Hibbe
4d29a4b638
add LocationMessageViewHolder for ChatKit
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:35 +02:00
Marcel Hibbe
1e2960a72a
add example for leaflet in WebView
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:33 +02:00
Marcel Hibbe
73becd432d
add logic for geolocation message
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:32 +02:00
Marcel Hibbe
965692ce7e
set location picker icon over map
show location when clicked on button

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:31 +02:00
Marcel Hibbe
0742afe58c
add map via osmdroid
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:30 +02:00
Marcel Hibbe
c6d3abf421
add entry to share location
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-11 10:21:25 +02:00
Andy Scherzinger
5d41b0fae2
rename HashMap
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-09 13:50:28 +02:00
Andy Scherzinger
047372ad37
flip string com pare for null-safety
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-09 13:50:27 +02:00
Andy Scherzinger
893f015edf
shorten Log Tag
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-09 13:50:25 +02:00
Andy Scherzinger
cf24965f7f
code formatting, make TAG final
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-09 13:50:24 +02:00
Andy Scherzinger
f3dd482476
link swipe-to-reply to messages replyable-flag
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-09 13:50:18 +02:00
Marcel Hibbe
e03f048126
fix displaying of large images
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-06-09 13:19:49 +02:00
Andy Scherzinger
db231ed12b
update after rebase, lower detekt score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 23:26:09 +02:00
Andy Scherzinger
7372d108a7
housekeeping to improve codacy/detekt score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 23:21:20 +02:00
Andy Scherzinger
bc20e0438f
replace magic numbers with constants
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 23:20:55 +02:00
Andy Scherzinger
292bee8396
Swipe to reply for chat messages (incoming/outgoing/preview)
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 23:20:54 +02:00
Andy Scherzinger
b513d0f154
improve detekt score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:37:06 +02:00
Andy Scherzinger
e4da772882
ignore detekt for"Detekt.TooGenericExceptionCaught" in scenarios where we need to handle NPE explicitly
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:37:05 +02:00
Andy Scherzinger
40a08394bc
hardened view binding interaction
...in case of asynchronous UI interaction with already destroyed UI

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:37:02 +02:00
Andy Scherzinger
7b7eaa455d
binding isn't nullable
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:37:01 +02:00
Andy Scherzinger
ebc3dbdf79
improve readability of toolbar/searchbar handling code
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:58 +02:00
Andy Scherzinger
266a9f73ee
add destruction check before accessing the binding object
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:53 +02:00
Andy Scherzinger
faf9ce2884
combine nested ifs
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:48 +02:00
Andy Scherzinger
46a18ca3a0
organize imports
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:45 +02:00
Andy Scherzinger
f8a8b81ef7
line length 1220 characters
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:43 +02:00
Andy Scherzinger
f4cfc9cef3
improve spotbugs
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:41 +02:00
Andy Scherzinger
cfe00937c5
comment unused, overridden methods and respect 120 character line length
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:39 +02:00
Andy Scherzinger
e7ea57bf85
reformat kotlin
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:37 +02:00
Andy Scherzinger
45a88c0722
replace menu switch statements with if/else
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:34 +02:00
Andy Scherzinger
3c0ef1d1e0
add linebreak
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:32 +02:00
Andy Scherzinger
63fabeda09
convert lock controller to kotlin
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:31 +02:00
Andy Scherzinger
7669108d38
add author infos
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:29 +02:00
Andy Scherzinger
85fe560fc1
reformat code for 120 line length
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:27 +02:00
Andy Scherzinger
14fc3c8146
move back to User java entity definition
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:26 +02:00
Andy Scherzinger
d372335d57
hardening chat controller by null-checking any UI access due to asynchronous UI accesses
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:24 +02:00
Andy Scherzinger
8d6b526576
use capabilities helper
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:22 +02:00
Andy Scherzinger
1134172faa
adapt to rebase
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:21 +02:00
Andy Scherzinger
e2c6fd7c25
migrate chat controller to native view binding
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:19 +02:00
Andy Scherzinger
0e92e5ea2d
code format kotlin code
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:18 +02:00
Andy Scherzinger
4784a22e18
update headers and format code
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:16 +02:00
Andy Scherzinger
ca8d6cb782
Move controller to new view binding utilizing logic
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-08 17:36:10 +02:00
Andy Scherzinger
cd5f083a49
make text preview dark/light aware, overall improvement of preview screens
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-31 15:29:00 +02:00
tobiasKaminsky
46790c9bde
Correct fix for not showing bold on read ConversationItem
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-05-28 10:00:57 +02:00
Marcel Hibbe
1673d15e5e
dont show deletion option for attachments
(deletion for attachments in talk is not supported by server)

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-05-27 09:30:04 +02:00
Andy Scherzinger
98e5ff5771
remove unsed imports
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-26 14:39:18 +02:00
Andy Scherzinger
02a129c3fc
Add error logging when reading user profile from server
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-26 14:26:37 +02:00
Andy Scherzinger
c3e336b716
align avatar placeholders with dark/light theme and add placeholder to settings avatar
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-26 11:04:31 +02:00
Andy Scherzinger
93a1d411e0
set fallback avatar icon
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-25 17:41:30 +02:00
Andy Scherzinger
45ed897c34
reformat kotlin code
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-25 12:38:07 +02:00
Marcel Hibbe
8c99dde497
remove toasts from worker
(were accidentally added in PR #1284)

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-05-25 12:26:23 +02:00
Marcel Hibbe
c1f55aa02e
add toast messages when exceptions were thrown
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-05-25 11:17:14 +02:00
Marcel Hibbe
59ccc19ebe
add ability to share plain text
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-05-25 11:03:25 +02:00
Marcel Hibbe
36fdd6d82b
add ability to "share to" files to nextcloud talk app
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-05-25 11:03:21 +02:00
Andy Scherzinger
0662e9bd39
Merge pull request #1275 from nextcloud/bugfix/1272/instantDarkLightConversationIconAdaption
Instant adoption of dark/light theming for default conversation icons
2021-05-21 15:47:09 +02:00
Joas Schilling
3ca56793ff
Merge pull request #1276 from nextcloud/conversationActions
Make observer type save
2021-05-21 09:49:30 +02:00
Andy Scherzinger
123ef3d0ce
set user icon to have a fallback for account switcher icon in search bar
Fixes #1139

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-21 00:03:12 +02:00
Andy Scherzinger
d0a6c96668
make observer type save
fixes #1270

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-20 22:12:06 +02:00
Andy Scherzinger
ef9021340e
instant adaption of dark/light theming for default conversation icons
Fixes #1272

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-20 15:16:12 +02:00
Andy Scherzinger
a36ef3e4a9
remove duplicate null check
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-20 11:57:05 +02:00
Andy Scherzinger
6e56731f15
use short-syntax for loops and reformat code to 120 character line limt
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-20 11:26:41 +02:00
Joas Schilling
de6683815a
Add support for signaling v3
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-20 11:26:40 +02:00
Andy Scherzinger
d923a41696
move magic numbers to value objects
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-18 18:23:33 +02:00
Andy Scherzinger
833ebbc9e3
use native view bindings in activities
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-18 17:58:09 +02:00
Andy Scherzinger
e74aa09879
remove custom password animation and use default/component one
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-18 09:34:46 +02:00
Andy Scherzinger
f87815753d
Merge pull request #1261 from nextcloud/codacy
Codacy
2021-05-18 09:34:23 +02:00
Andy Scherzinger
ec5a98e22b
proper indentation
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-17 15:19:12 +02:00
Andy Scherzinger
f540aa9305
improve logging, empty method documentation and new codacy issues
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-17 14:56:46 +02:00
Andy Scherzinger
7bd6076795
codacy: improve identation
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-17 14:30:16 +02:00
Andy Scherzinger
2ffdd5199c
housekeeping: removed any use of org.jetbrains.annotations
(including a java-to-kotlin rewrite)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-17 14:21:21 +02:00
Andy Scherzinger
7563dc5fba
codacy: Avoid unused local variables such as 'finalCredentials'.
Use correct annotation

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-17 13:48:53 +02:00
Andy Scherzinger
8cb0293e83
codacy: Generics names should be a one letter long and upper case.
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-17 13:40:55 +02:00
Andy Scherzinger
dcadf5d1a3
codacy: NoSemicolons
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-17 13:39:09 +02:00
Andy Scherzinger
4999916f27
codacy: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-17 13:38:05 +02:00
Andy Scherzinger
0bc3be1b6e
codacy: Avoid unused imports
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-17 13:35:34 +02:00
Andy Scherzinger
cb455a7104
Add annotation where needed
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-17 13:11:50 +02:00
Andy Scherzinger
443cf8b227
user proper activity context to grab themed color for item header for mention items
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-17 13:11:44 +02:00
Andy Scherzinger
d8b167ebfa
spotbugs: improve exception handling
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-14 17:05:02 +02:00
Joas Schilling
4790e7b7e4
Fix "NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE" SpotBugs complaint
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-14 14:40:28 +02:00
Joas Schilling
16ca03cb5c
Adjust title depending on the view
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-14 14:20:30 +02:00
Joas Schilling
8f7873ab9b
Add circles support
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-14 14:20:30 +02:00
Joas Schilling
98fa8642d3
Allow to add emails as particpants
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-14 14:19:22 +02:00
Joas Schilling
d06935fd78
Fix ktlint
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-14 14:06:35 +02:00
Joas Schilling
a44e714f13
Fix position and icon of the PopupMenu
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-14 13:54:35 +02:00
Joas Schilling
7bbe954d47
Reply privately
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-14 13:47:28 +02:00
Andy Scherzinger
ed2f53bff4
make popup menu respect the defined style definition by using the right context and referencing the style definition
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-14 13:27:39 +02:00
Joas Schilling
39a848afa4
Fix participant list call state
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-14 13:27:37 +02:00
Marcel Hibbe
8fc963290b
fix navigation bar color for call screen.
remove blue launcher screen for calls.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-05-14 11:14:32 +02:00
Joas Schilling
213d11358a
Fix "own message" detection with guests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-12 16:21:55 +02:00
Joas Schilling
97117eb90c
Use the correct signaling information and user+ticket for "Join via link" as well
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-12 16:21:55 +02:00
Joas Schilling
c335a69413
Connect the buttons with the actions also for guests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-12 16:21:54 +02:00
Joas Schilling
932afc2b58
Remove duplicate call
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-12 16:21:54 +02:00
Joas Schilling
01813d4165
Use injected capabilities
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-12 16:21:54 +02:00
Joas Schilling
2fd0933383
Remove unused capability checking
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-12 16:21:54 +02:00
Joas Schilling
a4cc7f2816
Remove non reachable "initiateCall()"
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-12 16:21:54 +02:00
Joas Schilling
b98ff4c56a
Fix joining a public chat as a guest
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-12 16:21:54 +02:00
Joas Schilling
bc2fadb4c5
Add (read-only for now) description to the conversation info
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-12 14:35:50 +02:00
Andy Scherzinger
dc78f615cb
set proper colors for unread-messages for edge case of theme switch
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-12 09:15:31 +02:00
Andy Scherzinger
2b44a295a4
add account switcher in search bar
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-12 09:15:31 +02:00
Joas Schilling
90ad596f90
Merge pull request #1229 from nextcloud/feature/apiv4/calls
[apiv4] ☎️ Calls
2021-05-11 10:37:40 +02:00
Joas Schilling
172d8da1cf
"chat-v2" capability is available since Nextcloud 13
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-11 09:57:05 +02:00
Andy Scherzinger
386ef5dc96
explicitely set header color
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-10 21:39:09 +02:00
Andy Scherzinger
a5d14a67f8
add mail icon for mail users
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-10 21:24:24 +02:00
Joas Schilling
72705dbaf5
Fix "calls equals on an enum instance"
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-10 12:36:19 +02:00
Joas Schilling
112a5662ad
Fix null reference when a participant leaves
java.lang.NullPointerException: Attempt to invoke virtual method
'void com.nextcloud.talk.adapters.ParticipantDisplayItem.setAudioEnabled(boolean)'
on a null object reference

Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-10 11:47:09 +02:00
Joas Schilling
79be753493
Fix some more getUserId() calls
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-10 11:35:17 +02:00
Joas Schilling
dde79b5671
Fix joining a call
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-10 11:35:16 +02:00
Joas Schilling
335afb03dd
Test calling with apiv4
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-10 11:35:16 +02:00
Andy Scherzinger
8bb7af4eef
use stringbuilder
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-09 21:59:59 +02:00
Andy Scherzinger
c91631a642
lint: Set locale
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-09 21:56:35 +02:00
Andy Scherzinger
ef273cf9ff
rewrite to for-loop due to former dignature collision kotlin1.5<>java8
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-09 21:54:35 +02:00
Andy Scherzinger
3cb2023680
improve codacy score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-09 17:41:56 +02:00
Joas Schilling
d29905d0fa
Split the method to be short *roll eyes*
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-09 17:32:22 +02:00
Joas Schilling
9596e298f2
Deduplicate the subscriber to make the method shorter
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-09 17:32:21 +02:00
Joas Schilling
a1bee6a776
Only show the server host in the account switcher as well
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-09 17:32:20 +02:00
Joas Schilling
21093282f9
Less deprecated usage
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-09 17:32:19 +02:00
Joas Schilling
875c66ea8a
Remove unsupported !"empty-group-room" case and finish conversation support for apiv4
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-09 17:32:18 +02:00
Joas Schilling
8e80c9fb99
Split calls to another API function
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-09 17:32:17 +02:00
Joas Schilling
c1e0b07df9
Check the canDeleteConversation flag
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-09 17:32:16 +02:00
Joas Schilling
6072d091a2
Fix adding users/groups to a conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-09 17:32:16 +02:00
Joas Schilling
32bb98e43e
Display the pin if the participant has one
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-09 17:32:15 +02:00
Joas Schilling
4ad96cc347
Fix available actions for groups, owners and self-joined users
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-09 17:32:14 +02:00
Joas Schilling
596772c5c6
Fix promoting and demoting on apiv4
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-09 17:32:13 +02:00
Joas Schilling
6f48ff9070
Fix removing an attendee from a conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-09 17:32:13 +02:00
Andy Scherzinger
7a574285db
Update kotlin usage of okhttp due to bump 3.x->4.xwhich is binary compatible but not source compatible
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-08 12:52:13 +02:00
Andy Scherzinger
9858860604
replace imports due to changed packaging
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-08 12:52:12 +02:00
Joas Schilling
4bf570ac35
Merge pull request #1219 from nextcloud/feature/apiv4/add-apiv4-for-easy-conversation-api-calls
[apiv4] Add apiv4 for easy conversation api calls
2021-05-07 22:18:49 +02:00
Andy Scherzinger
a247509aa1
add nullchecks since elements are annotated as nullable
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-07 21:56:27 +02:00
Andy Scherzinger
34041b0358
Code changes due to conductor update to 3.0.1
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-07 21:56:26 +02:00
Joas Schilling
e9fa343fce
Add APIv4 to easy conversation API calls
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-07 21:56:23 +02:00
Joas Schilling
704266ae85
Merge pull request #1218 from nextcloud/techdebt/apiv4/remove-props-which-are-not-there-anymore
[apiv4] Remove props which are not there anymore
2021-05-07 20:00:29 +02:00
Joas Schilling
e9e64771d5
Fix ktlint
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-07 16:00:17 +02:00
Joas Schilling
f32c0867e5
Remove participants usage outside the conversation usage
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-07 15:56:05 +02:00
Joas Schilling
5399723ea7
Deprecate props and remove already whats not used anymore
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-07 15:56:05 +02:00
Joas Schilling
ca9a622030
Capability multi-room-users was introduced 2018
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-07 15:53:48 +02:00
Joas Schilling
61a2d389b4
Remove fallback code for "no-ping" not being available
The capability was introduces 2018 for Nextcloud 14

Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-07 15:53:47 +02:00
Joas Schilling
6434630709
Merge pull request #1156 from nextcloud/techdebt/noid/api-v4-compatibility
v4️⃣ - Add option for APIv4 compatibility
2021-05-07 15:52:48 +02:00
Joas Schilling
b0ab1de0f1
Merge pull request #1224 from nextcloud/bugfix/noid/define-all-system-messages
Define all system messages as such
2021-05-07 12:57:50 +02:00
Joas Schilling
0f7965f4f9
Readd SuppressLint
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-07 11:57:39 +02:00
Joas Schilling
fc736b2aff
Fix missing import
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-07 11:57:39 +02:00
Joas Schilling
9f0c760c49
Fix capability checking when there could be no user
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-07 11:57:39 +02:00
Joas Schilling
6aab2d0834
Fix more ktlint
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-07 11:57:39 +02:00
Joas Schilling
5d366d0dbf
Fix coding styles
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-07 11:57:39 +02:00
Joas Schilling
ee3dc43530
Throw the exception up
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-07 11:57:38 +02:00
Joas Schilling
fb2fbf3152
LongLogTag
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-07 11:56:13 +02:00
Joas Schilling
b5c1e623c5
Fix undefined symbol
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-07 11:56:13 +02:00
Joas Schilling
bc641e2d07
Fix Code style
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-07 11:56:13 +02:00
Joas Schilling
529541d896
Change version to be specific to conversations api
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-07 11:56:11 +02:00
Joas Schilling
e6d869d431
Allow to inject the version into the chat api
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-07 11:55:50 +02:00
Joas Schilling
cf23a3d87d
Inject API version into signaling API calls
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-07 11:55:48 +02:00
Joas Schilling
f0eb3fec37
Inject api version in call api
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-07 11:54:26 +02:00
Joas Schilling
33de3ed330
Final batch of API version injection
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-07 11:51:02 +02:00
Joas Schilling
1766125149
Move account verification to capabilities
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-07 11:49:51 +02:00
Joas Schilling
ccd752b4ca
Fix some kotlin files to allow api switching
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-07 11:49:51 +02:00
Joas Schilling
115154331d
Fix more java calls
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-07 11:49:51 +02:00
Joas Schilling
f32b25c455
Fix old APIs
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-07 11:49:51 +02:00
Joas Schilling
68369873f4
Use new method instead of copied behaviour
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-07 11:49:51 +02:00
Joas Schilling
ad71cc3a97
Log an error when an API call didn't check APIv4
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-07 11:49:51 +02:00
Joas Schilling
c3061df60b
Allow to inject the api version into all methods for the room api
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-07 11:49:51 +02:00
Joas Schilling
1a15bd9f5f
Deprecate all APIs without a specified version
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-07 11:49:51 +02:00
Joas Schilling
3cd18d50ca
APIv4 compatibility
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-07 11:49:50 +02:00
Marcel Hibbe
b8e4c4da56
add grid view for calls. make own video movable
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-05-07 09:45:51 +02:00
Joas Schilling
8d99f0b98f
Define all system messages as such
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-06 21:24:50 +02:00
Andy Scherzinger
39de278b7d
remove lock icon in conversations list
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-06 18:10:55 +02:00
Andy Scherzinger
1d734485bb
properly parse encryption/favorite flags
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-06 13:29:19 +02:00
Andy Scherzinger
202d98d478
wrap warning in cardview and add warning icon for extra visual
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-05 15:48:52 +02:00
Joas Schilling
c368af6bab
Move dialog into a new function
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-05 15:44:49 +02:00
Joas Schilling
c789152122
Exit the app when there is only this EOL account
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-05 15:44:14 +02:00
Joas Schilling
1f8905394e
Add dedicated methods for the EOL version checks
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-05 15:44:13 +02:00
Joas Schilling
37dc7d1df0
Add a warning on the conversations list as well
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-05 15:44:12 +02:00
Joas Schilling
01b760f97e
Add a warning when the server version is (almost) EOL
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-05 15:44:11 +02:00
Andy Scherzinger
19cd3e4c79
Improve descriptive strings based on review feedback
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-05 09:06:54 +02:00
Andy Scherzinger
188e33538e
a11y dynamic content descriptions for scope toggles on profile
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-04 18:16:17 +02:00
Andy Scherzinger
d54b3f3d0a
a11y dynamically set call state info on user items
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-04 15:11:11 +02:00
Andy Scherzinger
1e702f1d1d
a11y conversation-emojie and read/sent status of messages
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-04 12:56:07 +02:00
Andy Scherzinger
bf4f2f87fe
add missing annotation
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-04 12:56:07 +02:00
Andy Scherzinger
4ddd181146
improve generic link/group circular icon display
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-03 21:55:52 +02:00
Marcel Hibbe
5914f01524
add info about permissions on api level 30 for resolveActivity
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-05-03 21:37:42 +02:00
Marcel Hibbe
b97e670253
add support for all files that can be handled by an external app
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-05-03 21:37:42 +02:00
Marcel Hibbe
6a387e4cb8
add support for PDF (by intent)
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-05-03 21:37:42 +02:00
Marcel Hibbe
4f0a813512
set showUnauthorizedDialog to modal
avoid crash when login view is shown after coming from showUnauthorizedDialog

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-05-03 21:22:32 +02:00
Marcel Hibbe
c2032b6554
extract methods and add log commands in AccountRemovalWorker
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-05-03 21:22:32 +02:00
Joas Schilling
cb11c36400
Pop a dialog to log in again or delete the account
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-03 21:22:32 +02:00
Joas Schilling
3f5c03f1ef
Start the reauth webview also when there is no getParentController()
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-03 21:22:32 +02:00
Andy Scherzinger
f119adf974
show search bar when closing bottom sheet
Fixes #1172

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-03 15:05:29 +02:00
Andy Scherzinger
e1ac6c2f09
use plus icon/primary for new group conversation
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-03 13:47:17 +02:00
Andy Scherzinger
79e5c3bcaf
change order/icon of public conversation creation item
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-03 10:55:13 +02:00
Andy Scherzinger
8766bf2eb1
add contacts shimmer and improve link-based conversation creation items
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-02 21:40:33 +02:00
Andy Scherzinger
712fdfeac4
adapt to de-lomboked code-base
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-04-30 08:50:24 +02:00
Joas Schilling
90bf76e013
Support delete-multiple push notification
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-30 01:16:16 +02:00
Andy Scherzinger
d2edd6010c
show contacts icon for vcf file
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-04-29 23:48:42 +02:00
Andy Scherzinger
8442a5a65e
reformat class
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-04-29 23:48:41 +02:00
Andy Scherzinger
c46cf9125b
spotbugs: remove: needlessly boxes a boolean constant
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-04-29 17:40:23 +02:00
Andy Scherzinger
b350a4c86e
remove default constructors (generated by the compiler) and simplify if-statements of equals-methods
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-04-29 16:37:57 +02:00
Andy Scherzinger
61aaae4dc2
Update code base for Android Studio 4.1.3
Remove lombock @Data annotations
Replace FindBugs with SpotBugs
Update Lombock version

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-04-29 00:46:35 +02:00
Andy Scherzinger
f1f5c3b19c
improve logging, remove unused member var
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-04-27 22:45:14 +02:00
Andy Scherzinger
9e587a4385
use 24h format
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-04-27 19:12:03 +02:00
Andy Scherzinger
e82808080d
reformat kotlin code to comply with ktlint
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-04-27 18:16:51 +02:00
Andy Scherzinger
fa1360090a
improve logging for LoganSquareJodaTimeConverter
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-04-27 12:59:21 +02:00
dependabot[bot]
ac9c0cc8ea
Bump coil-gif from 0.9.1 to 1.2.0 and update code to changed coil 1.2.0 API
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-04-27 10:13:39 +02:00
Andy Scherzinger
f8319b663d
add contribution info
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-04-27 07:56:00 +02:00
Andy Scherzinger
1ab96016ac
optimize lock-screen layout/colors
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-04-27 07:55:54 +02:00
Andy Scherzinger
5b6760e4b8
Merge pull request #1141 from nextcloud/shimmerAndUploadBottomSheet
Optimize Shimmer and upload bottom sheet
2021-04-26 20:59:46 +02:00
Dariusz Olszewski
0385c951b4
Enable enlarging the image more than default 3x maximumScale.
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2021-04-26 17:25:37 +02:00
Andy Scherzinger
5aa28e4477
Make sound choice icons simple radio buttons
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-04-26 15:52:55 +02:00
Andy Scherzinger
e1d4331f16
properly set pull-to-refresh-spinner-background-color
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-04-26 15:52:54 +02:00
Marcel Hibbe
7a26165d39
delete log command
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-04-23 15:57:19 +02:00
Marcel Hibbe
51b1f988ea
reduce lint errors
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-04-23 15:33:43 +02:00
Marcel Hibbe
3f6f492143
open files inside app
Open files directly inside the app.
Download file into cache beforehand if not already done.

supported file types:
jpg, .png, .gif, .mp3, .mp4, .mov, .wav, .txt, .md

thanks to @tobiasKaminsky and @starypatyk

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-04-23 15:33:43 +02:00
Andy Scherzinger
3f7d9ee76f
highlight quotes from oneself
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-04-18 13:45:20 +02:00
Andy Scherzinger
da5dad4e9b
improve quoted message design
Resolves  #945

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-04-18 13:45:00 +02:00
Andy Scherzinger
661c0cb04a
add GUEST_MODERATOR to participant list sorting criteria
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-04-15 15:29:14 +02:00
Andy Scherzinger
141458047f
documentation for color-meanings
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-04-15 15:29:14 +02:00
Andy Scherzinger
a51e9f7042
align sorting with webUI
(as far as possible atm)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-04-15 15:29:14 +02:00
Andy Scherzinger
914bb44514
add documentation to comparator
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-04-15 15:29:14 +02:00
Andy Scherzinger
f118cc7dd3
raise sizes to minimal hit-area of 48dp and tint icons at 60%/87% alpha (like active/inactive states)
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-04-15 15:29:14 +02:00
Andy Scherzinger
b80396b34b
sort participants list
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-04-15 15:29:14 +02:00
Andy Scherzinger
690d09eb60
optimize grey tones regarding WCAG guidelines and material design standard colors
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-04-15 15:29:14 +02:00
Andy Scherzinger
62f50fa35d
Add splash screen to Talk App
Resolves #836

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-04-15 00:29:29 +02:00
Andy Scherzinger
fde49c0694
add space to have whitespace between toolbar-avatar and title for conversation and conversation info screen
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-04-13 23:43:01 +02:00
Andy Scherzinger
02483c134d
update empty conversations screen and added shimmer effect for loading conversations initially
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-04-13 11:12:57 +02:00
Marcel Hibbe
604dfd7a38
Merge branch 'master' into loginTextfieldDesign_master 2021-04-13 10:27:56 +02:00
Andy Scherzinger
5b214ccfec
make adding users easier to discover
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-04-12 17:52:10 +02:00
Andy Scherzinger
e3a9e79f31
Show proper title for personal info screen
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-04-12 17:41:04 +02:00
Andy Scherzinger
c812372db5
backport/enhance login screen
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-04-09 17:40:44 +02:00
Marcel Hibbe
983509396d
show only fieldname in toast when saving failed
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-04-08 15:07:18 +02:00
tobiasKaminsky
ea50cf60e5
Upon error on saving, revert value
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-04-08 14:15:27 +02:00
Andy Scherzinger
b1a60b6cf1
use proper logging API
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-04-08 09:48:22 +02:00
Andy Scherzinger
c461ddca5b
respect light/dark theming
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-04-08 09:48:21 +02:00
Andy Scherzinger
d497cdd895
move variable declaration up to fix compile issue
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-04-08 09:43:37 +02:00
tobiasKaminsky
43108661e9
Clear cached avatar
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-04-08 09:43:37 +02:00
Tobias Kaminsky
6fb5d3f9bb
Fixed some spotbugs, excluded some bug categories to be consistent with Files
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-04-08 09:43:37 +02:00
tobiasKaminsky
a57253e0df
Fix bugs found by Marcel
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-04-08 09:43:37 +02:00
tobiasKaminsky
4f0923ba0d
Add user profile, allow to edit it, if server supports it
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-04-08 09:43:37 +02:00
Andy Scherzinger
6bbc7dd84a
spotbugs: remove unused code, replace multiple strings with constants
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-04-07 17:10:56 +02:00
Andy Scherzinger
85c22ea1a1
optimized system/navigation bar coloring
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-04-07 14:52:51 +02:00
Andy Scherzinger
7751e108e8
properly theme navigation/systembar for system default theme
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-04-07 14:52:50 +02:00
Andy Scherzinger
a125185915
Introduce SearchBar/Toolbar dark/light design
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-04-07 14:52:43 +02:00
Marcel Hibbe
2158a809fa
Merge pull request #1100 from nextcloud/fixScrolling
On Recyclerview everything needs to be set explicitly
2021-04-07 11:32:15 +02:00
Marcel Hibbe
723ee303d4
Merge pull request #1095 from nextcloud/avoidSharingRestrictedFiles
do not allow selecting files that are not allowed to be reshared
2021-04-07 10:58:13 +02:00
Marcel Hibbe
cc5d3d968e
log exceptions
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-04-07 10:00:29 +02:00
Marcel Hibbe
1038612569
use name from theming capability for "Share from..", set fallback to nc_server_product_name
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-04-07 09:47:39 +02:00
Marcel Hibbe
f24addbcf6
avoid hardcoded product name in "Share from Nextcloud"
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-04-06 10:45:17 +02:00
Marcel Hibbe
bd8edbc17f
avoid read redundant string
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-04-06 10:43:53 +02:00
tobiasKaminsky
ada5aeebe5
On Recyclerview everything needs to be set explicitly
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-04-06 08:39:48 +02:00
Marcel Hibbe
68c09d8e81
do not allow selecting files in files browser that are not allowed to be reshared
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-03-31 13:18:41 +02:00
Marcel Hibbe
17f3dae165
delete all account-links when disabling phonebooksync
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2021-03-26 15:47:11 +01:00