From e2735e8cb286c06c07e444ff698224ba232e2b24 Mon Sep 17 00:00:00 2001
From: Marcel Hibbe <dev@mhibbe.de>
Date: Fri, 29 Apr 2022 10:52:39 +0200
Subject: [PATCH] improve list view design for shared items

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
---
 .../main/res/layout/attachment_list_item.xml    | 17 +++++++++++++----
 app/src/main/res/values/dimens.xml              |  3 ++-
 2 files changed, 15 insertions(+), 5 deletions(-)

diff --git a/app/src/main/res/layout/attachment_list_item.xml b/app/src/main/res/layout/attachment_list_item.xml
index 4a2088aaa..7f1d2513f 100644
--- a/app/src/main/res/layout/attachment_list_item.xml
+++ b/app/src/main/res/layout/attachment_list_item.xml
@@ -43,10 +43,11 @@
         <com.facebook.drawee.view.SimpleDraweeView
             xmlns:fresco="http://schemas.android.com/apk/res-auto"
             android:id="@+id/file_image"
-            android:layout_width="@dimen/file_icon_size"
-            android:layout_height="@dimen/file_icon_size"
+            android:layout_width="@dimen/mediatab_file_icon_size"
+            android:layout_height="@dimen/mediatab_file_icon_size"
             android:padding="4dp"
             android:src="@drawable/ic_mimetype_file"
+            android:layout_marginEnd="@dimen/standard_margin"
             app:layout_constraintTop_toTopOf="parent"
             app:placeholderImageScaleType="fitCenter"
             fresco:actualImageScaleType="centerCrop"
@@ -67,6 +68,7 @@
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:orientation="vertical"
+        android:layout_centerVertical="true"
         android:layout_toEndOf="@id/preview_container">
 
         <androidx.emoji.widget.EmojiTextView
@@ -77,6 +79,7 @@
             android:lines="1"
             android:textAlignment="viewStart"
             android:textAppearance="@style/ListItem"
+            android:textSize="@dimen/two_line_primary_text_size"
             tools:text="Filename" />
 
         <LinearLayout
@@ -88,12 +91,16 @@
                 android:id="@+id/file_size"
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
+                android:textColor="@color/textColorMaxContrast"
+                android:textSize="12sp"
                 tools:text="filesize"/>
 
             <TextView
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
-                android:layout_marginStart="@dimen/margin_between_elements"
+                android:layout_marginStart="@dimen/standard_quarter_margin"
+                android:textColor="@color/textColorMaxContrast"
+                android:textSize="12sp"
                 android:text="|"
                 tools:ignore="HardcodedText" />
 
@@ -101,7 +108,9 @@
                 android:id="@+id/file_date"
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
-                android:layout_marginStart="@dimen/margin_between_elements"
+                android:layout_marginStart="@dimen/standard_quarter_margin"
+                android:textColor="@color/textColorMaxContrast"
+                android:textSize="12sp"
                 tools:text="date"/>
 
         </LinearLayout>
diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml
index a37207455..e4dc99eb7 100644
--- a/app/src/main/res/values/dimens.xml
+++ b/app/src/main/res/values/dimens.xml
@@ -35,7 +35,6 @@
     <dimen name="avatar_size">40dp</dimen>
     <dimen name="avatar_size_app_bar">30dp</dimen>
     <dimen name="avatar_size_big">96dp</dimen>
-    <dimen name="file_icon_size">40dp</dimen>
 
     <dimen name="chat_text_size">14sp</dimen>
     <dimen name="message_bubble_corners_radius">6dp</dimen>
@@ -71,4 +70,6 @@
     <dimen name="activity_row_layout_height">48dp</dimen>
     <dimen name="reaction_bottom_sheet_layout_size">40dp</dimen>
     <dimen name="standard_eighth_margin">2dp</dimen>
+
+    <dimen name="mediatab_file_icon_size">50dp</dimen>
 </resources>