mirrors/nextcloud-talk-android
1
0
Fork 0
mirror of https://github.com/nextcloud/talk-android.git synced 2024-11-24 22:15:41 +03:00
Code Issues Projects Releases Packages Wiki Activity

Fix unintended deletion of conversations (+related messages&chatBlocks)

Browse source 
Mistake was, that the conversations from DB and sync could differ due to values.
E.g. when a user changed the status, the conversations from DB and sync would differ. So there were conversations (+related messages&chatBlocks) deleted sometimes.
This caused bugs that when entering a chat, all data was loaded again.

In the previous implementation (before this PR), this error was only visible in the UI when you were offline (in this case, nothing was displayed!).

To fix the bug, only the internalId's are compared.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
This commit is contained in:
Marcel Hibbe 2024-10-16 14:20:45 +02:00
parent 3d37cc0831
commit adf18020c1
No known key found for this signature in database
GPG key ID: C793F8B59F43CE7B
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
app/src/main/java/com/nextcloud/talk/conversationlist/data/network/OfflineFirstConversationsRepository.kt
View file

@ -131,10 +131,12 @@ class OfflineFirstConversationsRepository @Inject constructor(
}
private suspend fun deleteLeftConversations(conversationsFromSync: List<ConversationEntity>) {
val conversationsFromSyncIds = conversationsFromSync.map { it.internalId }.toSet()
val oldConversationsFromDb = dao.getConversationsForUser(user.id!!).first()
val conversationsToDelete = oldConversationsFromDb.filterNot { conversationsFromSync.contains(it) }
val conversationIdsToDelete = conversationsToDelete.map { it.internalId }
val conversationIdsToDelete = oldConversationsFromDb
.map { it.internalId }
.filterNot { it in conversationsFromSyncIds }
dao.deleteConversations(conversationIdsToDelete)
}