mirrors/nextcloud-talk-android
1
0
Fork 0
mirror of https://github.com/nextcloud/talk-android.git synced 2024-12-19 07:02:04 +03:00
Code Issues Projects Releases Packages Wiki Activity

style(detekt): Improve score

Browse source 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
This commit is contained in:
Andy Scherzinger 2024-11-29 12:19:53 +01:00 committed by Marcel Hibbe
parent 26876c21d7
commit 77d2632513
No known key found for this signature in database
GPG key ID: C793F8B59F43CE7B
4 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
app/src/main/java/com/nextcloud/talk/activities/CallActivity.kt
View file

@ -2121,7 +2121,7 @@ class CallActivity : CallBaseActivity() {
private fun startVideoCapture() { private fun startVideoCapture() {
if (videoCapturer != null) { if (videoCapturer != null) {
videoCapturer!!.startCapture(1280, 720, 30) videoCapturer!!.startCapture(WIDTH, HEIGHT, FRAME_RATE)
} }
} }
@ -3210,6 +3210,10 @@ class CallActivity : CallBaseActivity() {
private const val MICROPHONE_VALUE_THRESHOLD = 20 private const val MICROPHONE_VALUE_THRESHOLD = 20
private const val MICROPHONE_VALUE_SLEEP: Long = 1000 private const val MICROPHONE_VALUE_SLEEP: Long = 1000
private const val FRAME_RATE: Int = 30
private const val WIDTH: Int = 1280
private const val HEIGHT: Int = 720
private const val SIGNALING_MESSAGE_SPEAKING_STARTED = "speaking" private const val SIGNALING_MESSAGE_SPEAKING_STARTED = "speaking"
private const val SIGNALING_MESSAGE_SPEAKING_STOPPED = "stoppedSpeaking" private const val SIGNALING_MESSAGE_SPEAKING_STOPPED = "stoppedSpeaking"
private const val SIGNALING_MESSAGE_VIDEO_ON = "videoOn" private const val SIGNALING_MESSAGE_VIDEO_ON = "videoOn"

3
app/src/main/java/com/nextcloud/talk/chat/data/network/OfflineFirstChatRepository.kt
View file

@ -274,7 +274,8 @@ class OfflineFirstChatRepository @Inject constructor(
if (!monitor.isOnline.first() || itIsPaused) { if (!monitor.isOnline.first() || itIsPaused) {
Thread.sleep(HALF_SECOND) Thread.sleep(HALF_SECOND)
} else { } else {
// sync database with server (This is a long blocking call because long polling (lookIntoFuture) is set) // sync database with server
// (This is a long blocking call because long polling (lookIntoFuture) is set)
networkParams.putSerializable(BundleKeys.KEY_FIELD_MAP, fieldMap) networkParams.putSerializable(BundleKeys.KEY_FIELD_MAP, fieldMap)
Log.d(TAG, "Starting online request for long polling") Log.d(TAG, "Starting online request for long polling")

3
app/src/main/java/com/nextcloud/talk/utils/DisplayUtils.kt
View file

@ -79,6 +79,7 @@ object DisplayUtils {
private const val HTTP_MIN_LENGTH: Int = 7 private const val HTTP_MIN_LENGTH: Int = 7
private const val HTTPS_MIN_LENGTH: Int = 7 private const val HTTPS_MIN_LENGTH: Int = 7
private const val DATE_TIME_PARTS_SIZE = 2 private const val DATE_TIME_PARTS_SIZE = 2
private const val ONE_MINUTE_IN_MILLIS: Int = 60000
fun isDarkModeOn(context: Context): Boolean { fun isDarkModeOn(context: Context): Boolean {
val currentNightMode = context.resources.configuration.uiMode and Configuration.UI_MODE_NIGHT_MASK val currentNightMode = context.resources.configuration.uiMode and Configuration.UI_MODE_NIGHT_MASK
return currentNightMode == Configuration.UI_MODE_NIGHT_YES return currentNightMode == Configuration.UI_MODE_NIGHT_YES
@ -490,7 +491,7 @@ object DisplayUtils {
} }
// < 60 seconds -> seconds ago // < 60 seconds -> seconds ago
val diff = System.currentTimeMillis() - time val diff = System.currentTimeMillis() - time
dateString = if (diff > 0 && diff < 60 * 1000 && minResolution == DateUtils.SECOND_IN_MILLIS) { dateString = if (diff in 1..<ONE_MINUTE_IN_MILLIS && minResolution == DateUtils.SECOND_IN_MILLIS) {
return c.getString(R.string.secondsAgo) return c.getString(R.string.secondsAgo)
} else { } else {
DateUtils.getRelativeDateTimeString(c, time, minResolution, transitionResolution, flags) DateUtils.getRelativeDateTimeString(c, time, minResolution, transitionResolution, flags)

2
detekt.yml
View file

@ -1,7 +1,7 @@
# SPDX-FileCopyrightText: 2017-2024 Nextcloud GmbH and Nextcloud contributors # SPDX-FileCopyrightText: 2017-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: GPL-3.0-or-later # SPDX-License-Identifier: GPL-3.0-or-later
build: build:
maxIssues: 179 maxIssues: 202
weights: weights:
# complexity: 2 # complexity: 2
# LongParameterList: 1 # LongParameterList: 1