From 38146dabf091340ec56be076668c860d17e652d5 Mon Sep 17 00:00:00 2001 From: Andy Scherzinger Date: Tue, 19 Apr 2022 20:19:16 +0200 Subject: [PATCH 1/2] remove unused butterknife binding Signed-off-by: Andy Scherzinger --- .../talk/activities/CallNotificationActivity.java | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/app/src/main/java/com/nextcloud/talk/activities/CallNotificationActivity.java b/app/src/main/java/com/nextcloud/talk/activities/CallNotificationActivity.java index c0a824b51..075888eea 100644 --- a/app/src/main/java/com/nextcloud/talk/activities/CallNotificationActivity.java +++ b/app/src/main/java/com/nextcloud/talk/activities/CallNotificationActivity.java @@ -74,10 +74,10 @@ import javax.inject.Inject; import androidx.annotation.Nullable; import androidx.annotation.RequiresApi; import autodagger.AutoInjector; -import butterknife.OnClick; import io.reactivex.Observable; import io.reactivex.Observer; import io.reactivex.android.schedulers.AndroidSchedulers; +import io.reactivex.annotations.NonNull; import io.reactivex.disposables.Disposable; import io.reactivex.schedulers.Schedulers; import okhttp3.Cache; @@ -196,8 +196,7 @@ public class CallNotificationActivity extends CallBaseActivity { binding.callAnswerVoiceOnlyView.setVisibility(View.VISIBLE); } - @OnClick(R.id.hangupButton) - void hangup() { + private void hangup() { leavingScreen = true; finish(); } @@ -226,12 +225,12 @@ public class CallNotificationActivity extends CallBaseActivity { .takeWhile(observable -> !leavingScreen)) .subscribe(new Observer() { @Override - public void onSubscribe(Disposable d) { + public void onSubscribe(@NonNull Disposable d) { disposablesList.add(d); } @Override - public void onNext(ParticipantsOverall participantsOverall) { + public void onNext(@NonNull ParticipantsOverall participantsOverall) { boolean hasParticipantsInCall = false; boolean inCallOnDifferentDevice = false; List participantList = participantsOverall.getOcs().getData(); @@ -253,7 +252,7 @@ public class CallNotificationActivity extends CallBaseActivity { } @Override - public void onError(Throwable e) { + public void onError(@NonNull Throwable e) { Log.e(TAG, "error while getPeersForCall", e); } From 406ecc15ed978a065ee7edc53f84c7f2cbb35df7 Mon Sep 17 00:00:00 2001 From: drone Date: Mon, 2 May 2022 16:30:14 +0000 Subject: [PATCH 2/2] Drone: update Lint results to reflect reduced error/warning count [skip ci] Signed-off-by: drone --- scripts/analysis/lint-results.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/analysis/lint-results.txt b/scripts/analysis/lint-results.txt index 5a424f167..8c4822eac 100644 --- a/scripts/analysis/lint-results.txt +++ b/scripts/analysis/lint-results.txt @@ -1,2 +1,2 @@ DO NOT TOUCH; GENERATED BY DRONE - Lint Report: 1 error and 150 warnings + Lint Report: 1 error and 149 warnings