lint warnings

Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
This commit is contained in:
sowjanyakch 2024-11-18 18:20:58 +01:00
parent 135c158e02
commit 640cc82f63
No known key found for this signature in database
GPG key ID: F7AA2A8B65B50220
2 changed files with 8 additions and 4 deletions

View file

@ -202,7 +202,7 @@ class ConversationsListBottomDialog(
} }
} }
@SuppressLint("StringFormatInvalid") @SuppressLint("StringFormatInvalid", "TooGenericExceptionCaught")
private fun addConversationToFavorites() { private fun addConversationToFavorites() {
val apiVersion = ApiUtils.getConversationApiVersion(currentUser, intArrayOf(ApiUtils.API_V4, ApiUtils.API_V1)) val apiVersion = ApiUtils.getConversationApiVersion(currentUser, intArrayOf(ApiUtils.API_V4, ApiUtils.API_V1))
val url = ApiUtils.getUrlForRoomFavorite(apiVersion, currentUser.baseUrl!!, conversation.token) val url = ApiUtils.getUrlForRoomFavorite(apiVersion, currentUser.baseUrl!!, conversation.token)
@ -228,7 +228,7 @@ class ConversationsListBottomDialog(
} }
} }
@SuppressLint("StringFormatInvalid") @SuppressLint("StringFormatInvalid", "TooGenericExceptionCaught")
private fun removeConversationFromFavorites() { private fun removeConversationFromFavorites() {
val apiVersion = ApiUtils.getConversationApiVersion(currentUser, intArrayOf(ApiUtils.API_V4, ApiUtils.API_V1)) val apiVersion = ApiUtils.getConversationApiVersion(currentUser, intArrayOf(ApiUtils.API_V4, ApiUtils.API_V1))
val url = ApiUtils.getUrlForRoomFavorite(apiVersion, currentUser.baseUrl!!, conversation.token) val url = ApiUtils.getUrlForRoomFavorite(apiVersion, currentUser.baseUrl!!, conversation.token)

View file

@ -8,6 +8,7 @@
*/ */
package com.nextcloud.talk.utils.preferences.preferencestorage package com.nextcloud.talk.utils.preferences.preferencestorage
import android.annotation.SuppressLint
import android.text.TextUtils import android.text.TextUtils
import android.util.Log import android.util.Log
import autodagger.AutoInjector import autodagger.AutoInjector
@ -63,6 +64,7 @@ class DatabaseStorageModule(conversationUser: User, conversationToken: String) {
this.conversationToken = conversationToken this.conversationToken = conversationToken
} }
@SuppressLint("TooGenericExceptionCaught")
suspend fun saveBoolean(key: String, value: Boolean) { suspend fun saveBoolean(key: String, value: Boolean) {
if ("call_notifications_switch" == key) { if ("call_notifications_switch" == key) {
val apiVersion = getConversationApiVersion(conversationUser, intArrayOf(4)) val apiVersion = getConversationApiVersion(conversationUser, intArrayOf(4))
@ -73,7 +75,7 @@ class DatabaseStorageModule(conversationUser: User, conversationToken: String) {
try { try {
ncApiCoroutines!!.notificationCalls(credentials!!, url, notificationLevel) ncApiCoroutines!!.notificationCalls(credentials!!, url, notificationLevel)
Log.d(TAG, "Toggled notification calls") Log.d(TAG, "Toggled notification calls")
} catch (e: Throwable) { } catch (e: Exception) {
Log.e(TAG, "Error when trying to toggle notification calls", e) Log.e(TAG, "Error when trying to toggle notification calls", e)
} }
} }
@ -90,11 +92,12 @@ class DatabaseStorageModule(conversationUser: User, conversationToken: String) {
} }
} }
@SuppressLint("TooGenericExceptionCaught")
suspend fun saveString(key: String, value: String) { suspend fun saveString(key: String, value: String) {
when (key) { when (key) {
"conversation_settings_dropdown" -> { "conversation_settings_dropdown" -> {
try { try {
val apiVersion = getConversationApiVersion(conversationUser, intArrayOf(4)) val apiVersion = getConversationApiVersion(conversationUser, intArrayOf(API_VERSION_4))
val trimmedValue = value.replace("expire_", "") val trimmedValue = value.replace("expire_", "")
val valueInt = trimmedValue.toInt() val valueInt = trimmedValue.toInt()
withContext(Dispatchers.IO) { withContext(Dispatchers.IO) {
@ -202,5 +205,6 @@ class DatabaseStorageModule(conversationUser: User, conversationToken: String) {
private const val NOTIFICATION_NEVER = 3 private const val NOTIFICATION_NEVER = 3
private const val NOTIFICATION_MENTION = 2 private const val NOTIFICATION_MENTION = 2
private const val NOTIFICATION_ALWAYS = 1 private const val NOTIFICATION_ALWAYS = 1
private const val API_VERSION_4 = 4
} }
} }