mirrors/nextcloud-talk-android
1
0
Fork 0
mirror of https://github.com/nextcloud/talk-android.git synced 2024-11-28 09:38:14 +03:00
Code Issues Projects Releases Packages Wiki Activity

Fix handling of end call for all with external signaling

Browse source 
When the message applies to all participants the property is all in
lower case. The comparison is case sensitive, so the message was ignored
and the call was not left by the Talk Android app.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
This commit is contained in:
Daniel Calviño Sánchez 2024-10-23 12:59:56 +02:00 committed by backportbot[bot]
parent f14e849ea5
commit 4573d4be76
2 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/src/main/java/com/nextcloud/talk/signaling/SignalingMessageReceiver.java
View file

@ -373,7 +373,7 @@ public abstract class SignalingMessageReceiver {
long inCall; long inCall;
try { try {
inCall = Long.parseLong(updateMap.get("inCall").toString()); inCall = Long.parseLong(updateMap.get("incall").toString());
} catch (RuntimeException e) { } catch (RuntimeException e) {
// Broken message, this should not happen. // Broken message, this should not happen.
return; return;

12
app/src/test/java/com/nextcloud/talk/signaling/SignalingMessageReceiverParticipantListTest.java
View file

@ -322,7 +322,7 @@ public class SignalingMessageReceiverParticipantListTest {
Map<String, Object> updateMap = new HashMap<>(); Map<String, Object> updateMap = new HashMap<>();
updateMap.put("roomId", 108); updateMap.put("roomId", 108);
updateMap.put("all", true); updateMap.put("all", true);
updateMap.put("inCall", 0); updateMap.put("incall", 0);
eventMap.put("update", updateMap); eventMap.put("update", updateMap);
signalingMessageReceiver.processEvent(eventMap); signalingMessageReceiver.processEvent(eventMap);
@ -343,7 +343,7 @@ public class SignalingMessageReceiverParticipantListTest {
HashMap<String, Object> updateMap = new HashMap<>(); HashMap<String, Object> updateMap = new HashMap<>();
updateMap.put("roomId", 108); updateMap.put("roomId", 108);
updateMap.put("all", true); updateMap.put("all", true);
updateMap.put("inCall", 0); updateMap.put("incall", 0);
eventMap.put("update", updateMap); eventMap.put("update", updateMap);
signalingMessageReceiver.processEvent(eventMap); signalingMessageReceiver.processEvent(eventMap);
@ -370,7 +370,7 @@ public class SignalingMessageReceiverParticipantListTest {
HashMap<String, Object> updateMap = new HashMap<>(); HashMap<String, Object> updateMap = new HashMap<>();
updateMap.put("roomId", 108); updateMap.put("roomId", 108);
updateMap.put("all", true); updateMap.put("all", true);
updateMap.put("inCall", 0); updateMap.put("incall", 0);
eventMap.put("update", updateMap); eventMap.put("update", updateMap);
signalingMessageReceiver.processEvent(eventMap); signalingMessageReceiver.processEvent(eventMap);
@ -393,7 +393,7 @@ public class SignalingMessageReceiverParticipantListTest {
HashMap<String, Object> updateMap = new HashMap<>(); HashMap<String, Object> updateMap = new HashMap<>();
updateMap.put("roomId", 108); updateMap.put("roomId", 108);
updateMap.put("all", true); updateMap.put("all", true);
updateMap.put("inCall", 0); updateMap.put("incall", 0);
eventMap.put("update", updateMap); eventMap.put("update", updateMap);
signalingMessageReceiver.processEvent(eventMap); signalingMessageReceiver.processEvent(eventMap);
@ -420,7 +420,7 @@ public class SignalingMessageReceiverParticipantListTest {
HashMap<String, Object> updateMap = new HashMap<>(); HashMap<String, Object> updateMap = new HashMap<>();
updateMap.put("roomId", 108); updateMap.put("roomId", 108);
updateMap.put("all", true); updateMap.put("all", true);
updateMap.put("inCall", 0); updateMap.put("incall", 0);
eventMap.put("update", updateMap); eventMap.put("update", updateMap);
signalingMessageReceiver.processEvent(eventMap); signalingMessageReceiver.processEvent(eventMap);
@ -449,7 +449,7 @@ public class SignalingMessageReceiverParticipantListTest {
HashMap<String, Object> updateMap = new HashMap<>(); HashMap<String, Object> updateMap = new HashMap<>();
updateMap.put("roomId", 108); updateMap.put("roomId", 108);
updateMap.put("all", true); updateMap.put("all", true);
updateMap.put("inCall", 0); updateMap.put("incall", 0);
eventMap.put("update", updateMap); eventMap.put("update", updateMap);
signalingMessageReceiver.processEvent(eventMap); signalingMessageReceiver.processEvent(eventMap);