mirrors/nextcloud-talk-android
1
0
Fork 0
mirror of https://github.com/nextcloud/talk-android.git synced 2024-11-21 20:45:29 +03:00
Code Issues Projects Releases Packages Wiki Activity

fix(spotbugs): Improve spotbugs scoring

Browse source 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
This commit is contained in:
Andy Scherzinger 2024-11-07 15:42:58 +01:00
parent cabd248e13
commit 3ac1b18d3d
No known key found for this signature in database
GPG key ID: 6CADC7E3523C308B
3 changed files with 29 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/src/main/java/com/nextcloud/talk/call/CallParticipantList.java
View file

@ -86,8 +86,8 @@ public class CallParticipantList {
callParticipants.remove(callParticipant.getSessionId()); callParticipants.remove(callParticipant.getSessionId());
// No need to copy it, as it will be no longer used. // No need to copy it, as it will be no longer used.
callParticipant.setInCall(Participant.InCallFlags.DISCONNECTED); callParticipant.setInCall(Participant.InCallFlags.DISCONNECTED);
left.add(callParticipant);
} }
left.addAll(knownCallParticipantsNotFound);
if (!joined.isEmpty() || !updated.isEmpty() || !left.isEmpty()) { if (!joined.isEmpty() || !updated.isEmpty() || !left.isEmpty()) {
callParticipantListNotifier.notifyChanged(joined, updated, left, unchanged); callParticipantListNotifier.notifyChanged(joined, updated, left, unchanged);

7
app/src/main/java/com/nextcloud/talk/presenters/MentionAutocompletePresenter.java
View file

@ -126,9 +126,12 @@ public class MentionAutocompletePresenter extends RecyclerViewPresenter<Mention>
@Override @Override
public void onNext(@NonNull MentionOverall mentionOverall) { public void onNext(@NonNull MentionOverall mentionOverall) {
if (mentionOverall.getOcs() != null) {
List<Mention> mentionsList = mentionOverall.getOcs().getData(); List<Mention> mentionsList = mentionOverall.getOcs().getData();
if (mentionsList.size() == 0) { if (mentionsList != null) {
if (mentionsList.isEmpty()) {
adapter.clear(); adapter.clear();
} else { } else {
List<AbstractFlexibleItem> internalAbstractFlexibleItemList = List<AbstractFlexibleItem> internalAbstractFlexibleItemList =
@ -150,6 +153,8 @@ public class MentionAutocompletePresenter extends RecyclerViewPresenter<Mention>
adapter.updateDataSet(internalAbstractFlexibleItemList); adapter.updateDataSet(internalAbstractFlexibleItemList);
} }
} }
}
}
@SuppressLint("LongLogTag") @SuppressLint("LongLogTag")
@Override @Override

6
app/src/main/java/com/nextcloud/talk/ui/dialog/ChooseAccountDialogFragment.java
View file

@ -109,7 +109,7 @@ public class ChooseAccountDialogFragment extends DialogFragment {
themeViews(); themeViews();
setupCurrentUser(user); setupCurrentUser(user);
setupListeners(user); setupListeners();
setupAdapter(); setupAdapter();
prepareViews(); prepareViews();
} }
@ -220,7 +220,7 @@ public class ChooseAccountDialogFragment extends DialogFragment {
adapter.updateDataSet(userItems, false); adapter.updateDataSet(userItems, false);
} }
private void setupListeners(User user) { private void setupListeners() {
// Creating listeners for quick-actions // Creating listeners for quick-actions
binding.currentAccount.getRoot().setOnClickListener(v -> dismiss()); binding.currentAccount.getRoot().setOnClickListener(v -> dismiss());
@ -240,7 +240,7 @@ public class ChooseAccountDialogFragment extends DialogFragment {
binding.setStatus.setOnClickListener(v -> { binding.setStatus.setOnClickListener(v -> {
dismiss(); dismiss();
if (status != null) { if (status != null && getActivity() != null) {
SetStatusDialogFragment setStatusDialog = SetStatusDialogFragment.newInstance(status); SetStatusDialogFragment setStatusDialog = SetStatusDialogFragment.newInstance(status);
setStatusDialog.show(getActivity().getSupportFragmentManager(), "fragment_set_status"); setStatusDialog.show(getActivity().getSupportFragmentManager(), "fragment_set_status");
} else { } else {