mirrors/nextcloud-server
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2024-05-18 17:30:49 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix(settings): Also verify that trusted_proxies only contains IP addresses (with range)

Browse source 
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
This commit is contained in:
Ferdinand Thiessen 2024-03-26 12:30:57 +01:00 committed by backportbot[bot]
parent bfa6ef8497
commit 3203db8160
1 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
apps/settings/lib/SetupChecks/ForwardedForHeaders.php
View file

@ -59,6 +59,16 @@ class ForwardedForHeaders implements ISetupCheck {
return SetupResult::error($this->l10n->t('Your "trusted_proxies" setting is not correctly set, it should be an array.'));
}
foreach ($trustedProxies as $proxy) {
$addressParts = explode('/', $proxy, 2);
if (filter_var($addressParts[0], FILTER_VALIDATE_IP) === false || !ctype_digit($addressParts[1] ?? '24')) {
return SetupResult::error(
$this->l10n->t('Your "trusted_proxies" setting is not correctly set, it should be an array of IP addresses - optionally with range in CIDR notation.'),
$this->urlGenerator->linkToDocs('admin-reverse-proxy'),
);
}
}
if (($remoteAddress === '') && ($detectedRemoteAddress === '')) {
if (\OC::$CLI) {
/* We were called from CLI */